[GitHub] [incubator-doris] yiguolei commented on a change in pull request #933: Optimize rowset usage

[GitBox <gi...@apache.org>]

yiguolei commented on a change in pull request #933: Optimize rowset usage
URL: https://github.com/apache/incubator-doris/pull/933#discussion_r275674877
 
 

 ##########
 File path: be/src/olap/rowset/rowset.h
 ##########
 @@ -113,13 +113,23 @@ class Rowset : public std::enable_shared_from_this<Rowset> {
 
     virtual int64_t txn_id() const = 0;
     
+    // flag for push delete rowset
     virtual bool delete_flag() = 0;
 
     virtual bool check_path(const std::string& path) = 0;
 
+    bool need_delete_file() {
+        return _need_delete_file;
+    }
+
+    void set_need_delete_file(bool need_delete_file) {
+        _need_delete_file = need_delete_file;
+    }
+
 
 Review comment:
   add a check here. if it is set need deleted it could not be reverted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org