You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/14 14:35:42 UTC
[GitHub] [kafka] mimaison opened a new pull request #11756: MINOR: Small cleanups in connect:runtime
mimaison opened a new pull request #11756:
URL: https://github.com/apache/kafka/pull/11756
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison merged pull request #11756: MINOR: Small cleanups in connect:runtime
Posted by GitBox <gi...@apache.org>.
mimaison merged pull request #11756:
URL: https://github.com/apache/kafka/pull/11756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #11756: MINOR: Small cleanups in connect:runtime
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #11756:
URL: https://github.com/apache/kafka/pull/11756#discussion_r807328392
##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java
##########
@@ -137,11 +137,6 @@
private int generation;
private SharedTopicAdmin ownTopicAdmin;
- @Deprecated
Review comment:
Do you know why we had this deprecated? Do we consider it a public API?
Below we have code which checks for null `SharedTopicAdmin`. Seems like we can probably get rid of that. The only usage I could see was in a test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on a change in pull request #11756: MINOR: Small cleanups in connect:runtime
Posted by GitBox <gi...@apache.org>.
mimaison commented on a change in pull request #11756:
URL: https://github.com/apache/kafka/pull/11756#discussion_r807883399
##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java
##########
@@ -137,11 +137,6 @@
private int generation;
private SharedTopicAdmin ownTopicAdmin;
- @Deprecated
Review comment:
It's not public API but looking at the history it looks like we're aware of external users and we decided to keep compatibility. For that reason, I've reverted this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org