You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/31 18:44:16 UTC
[GitHub] [arrow] nevi-me commented on pull request #7265: ARROW-8931: [Rust] add lexical sort support to arrow compute kernel
nevi-me commented on pull request #7265:
URL: https://github.com/apache/arrow/pull/7265#issuecomment-636511382
> For those who are interested, here is the datafusion sort expression support commit, which depends on this PR: [houqp@3fbe393](https://github.com/houqp/arrow/commit/3fbe393c6b6718a70028d311d659e506415666db)
This looks great, especially the `concat` kernel. I'll merge this PR tomorrow if there isn't another review, we can always address feedback in subsequent JIRAs.
I also updated the float-sort in #7193, may you please also look at it and see if we'd need to change anything to support floats in lexsort?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org