You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2026/08/20 06:24:40 UTC

[PR] fix(ui): remove unstable composer inline completion [maka]

jackwener opened a new pull request, #3292:
URL: https://github.com/apache/maka/pull/3292

   ## Summary
   
   - remove prompt-history inline completion from the composer
   - remove the ChatComposerInput dependency patch that mixed React state with manual contentEditable DOM reconciliation
   - keep prompt-history recall and same-document history clearing behavior unchanged
   - remove feature-specific tests, story, copy, and matching code
   
   ## Why
   
   The 0.1.11 renderer crash is React error #185 (Maximum update depth exceeded), with the component stack rooted at ChatComposerInput. The inline-completion patch runs a state-writing reconciliation effect after every render while also mutating the controlled contentEditable DOM. Under an unstable DOM/selection transition, the offer span can be withdrawn and reinserted repeatedly, and the live-region state schedules the next render.
   
   This auxiliary completion UX is not worth maintaining a second state machine inside the editor. Removing the feature eliminates the circular authority instead of adding another guard.
   
   ## Verification
   
   - `git diff --check`
   - verified the reduced `@astryxdesign/core@0.4.0` patch applies cleanly to the original npm package with `patch --dry-run`
   - targeted Chromium reproduction confirmed ordinary controlled input behavior is stable; no full test suite run
   
   The standalone UI typecheck was not treated as a signal because this isolated worktree reused stale build artifacts and reported existing workspace module-resolution/dependency-patch errors unrelated to this diff.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(ui): remove unstable composer inline completion [maka]

Posted by "M4n5ter (via GitHub)" <gi...@apache.org>.
M4n5ter commented on PR #3292:
URL: https://github.com/apache/maka/pull/3292#issuecomment-5353011889

   LGTM. I reviewed the removal across the Composer/history path and the Astryx patch. The unstable inline-completion state machine is removed cleanly, while prompt-history recall and clearing remain intact. I found no blocking issues.
   
   Non-blocking follow-up: `@maka/ui` can narrow its input-history barrel export to `clearGlobalInputHistory`, since the read, save, and subscribe APIs no longer have cross-package consumers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(ui): remove unstable composer inline completion [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #3292:
URL: https://github.com/apache/maka/pull/3292


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(ui): remove unstable composer inline completion [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #3292:
URL: https://github.com/apache/maka/pull/3292#discussion_r3819625281


##########
patches/README.md:
##########
@@ -28,7 +28,7 @@ Delete when that guard passes against an unpatched package.
 
 ## `@astryxdesign/core@0.4.0`
 
-Six published component seams drop host-owned state or semantics:
+Five published component seams drop host-owned state or semantics:

Review Comment:
   [P3] Keep the constraint this crash taught, now that the entry carrying it is gone. `patches/README.md` is where this repository records what each seam costs and when it may be deleted, and the removed bullet was the only written trace of the failure — that a patch which both writes React state from an unconditional effect and mutates the controlled `contentEditable` creates a render cycle the host cannot break from outside. The next patch that needs to draw something inside the editor has no reason not to reach for the same shape, and the reviewer of that patch has nothing to point at. One line near the top of this section stating the rule, rather than a bullet for a seam that no longer exists, costs nothing and is the only durable guard a removal-shaped fix can carry. Worth mentioning in the body too: since the fix is a deletion, the confirmation signal is the next release's crash rate, not a test — saying so, and linking the 0.1.11 crash report, is what lets someone verify 
 this landed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org