[GitHub] [helix] jiajunwang opened a new pull request #398: Change the rebalancer assignment record to be ResourceAssignment

[GitBox <gi...@apache.org>]

jiajunwang opened a new pull request #398: Change the rebalancer assignment record to be ResourceAssignment
URL: https://github.com/apache/helix/pull/398
 
 
   ### Issues
   
   - [ ] My PR addresses the following Helix issues and references them in the PR title:
   
   This change is related to #392 
   After the change, we will be able to refine the provider's PR.
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   Change the rebalancer assignment record to be ResourceAssignment instead of IdealState.
   ResourceAssignment fit the usage better. And there will be no unnecessary information to be recorded or read during the rebalance calculation.
   
   ### Tests
   
   - [ ] The following tests are written for this issue:
   
   No new test is required. The modified part has been covered by the WAGED rebalancer unit tests.
   
   - [ ] The following is the result of the "mvn test" command on the appropriate module:
   
   The feature has not been merged to master yet. Run unit tests only.
   All passed.
   TestAssignableNode
   TestAssignableReplica
   TestClusterContext
   TestClusterModel
   
   Default Suite
   Total tests run: 9, Failures: 0, Skips: 0
   
   
   ### Commits
   
   - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation in the following wiki page:
   
   https://github.com/apache/helix/wiki/Weight-aware-Globally-Evenly-distributed-Rebalancer
   
   ### Code Quality
   
   - [ ] My diff has been formatted using helix-style.xml
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org