You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/14 09:22:47 UTC

[GitHub] [pulsar] dragonls opened a new pull request #10226: [Issue 10221] Fix authorization error while using proxy and `Prefix` subscription authentication mode

dragonls opened a new pull request #10226:
URL: https://github.com/apache/pulsar/pull/10226


   Fixes #10221 
   
   ### Motivation
   If using pulsar proxy and `Prefix` subscription authentication mode, [org.apache.pulsar.broker.authorization.PulsarAuthorizationProvider#canConsumeAsync](https://github.com/apache/pulsar/blob/master/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java#L135) will throw exception which cause the consumer error.
   
   ### Modifications
   
   Update the `org.apache.pulsar.broker.authorization.PulsarAuthorizationProvider#allowTopicOperationAsync` logic, check `isSuperUser` first, then return `isAuthorizedFuture`.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dragonls commented on pull request #10226: [Issue 10221] Fix authorization error while using proxy and `Prefix` subscription authentication mode

Posted by GitBox <gi...@apache.org>.
dragonls commented on pull request #10226:
URL: https://github.com/apache/pulsar/pull/10226#issuecomment-820007423


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dragonls commented on pull request #10226: [Issue 10221] Fix authorization error while using proxy and `Prefix` subscription authentication mode

Posted by GitBox <gi...@apache.org>.
dragonls commented on pull request #10226:
URL: https://github.com/apache/pulsar/pull/10226#issuecomment-822135977


   @tuteng @codelipenghui Could you guys merge it if this PR is ok. Thanks a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #10226: [Issue 10221] Fix authorization error while using proxy and `Prefix` subscription authentication mode

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #10226:
URL: https://github.com/apache/pulsar/pull/10226#issuecomment-822136335


   @dragonls Merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #10226: [Issue 10221] Fix authorization error while using proxy and `Prefix` subscription authentication mode

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10226:
URL: https://github.com/apache/pulsar/pull/10226


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dragonls commented on pull request #10226: [Issue 10221] Fix authorization error while using proxy and `Prefix` subscription authentication mode

Posted by GitBox <gi...@apache.org>.
dragonls commented on pull request #10226:
URL: https://github.com/apache/pulsar/pull/10226#issuecomment-819549232


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org