You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by jvwing <gi...@git.apache.org> on 2016/02/22 19:44:37 UTC
[GitHub] nifi pull request: NIFI-786 AWS credential refactoring and enhance...
GitHub user jvwing opened a pull request:
https://github.com/apache/nifi/pull/244
NIFI-786 AWS credential refactoring and enhancements
Changes to AWS credential handling:
* Refactoring the creation of AWS Credentials into a factory class for use by AWSCredentialsProviderControllerService (included) and future shared use by processors or other components.
* Centralized the PropertyDescriptors used for AWS Credential configuration to standardize behavior and improve documentation.
* Improved self-documentation by making Default Credentials an explicit and visible option, while preserving the behavior of using it implicity if no other credential type is configured.
* In this commit, the explicit Use Default Credential option defaults to "false", to maintain backward compatibility upgrading to this implementation.
* Credential enhancements
* New credential option - Named Profile
* New credential option - Anonymous
* Added External ID as an optional parameter for Assume Role
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jvwing/nifi NIFI-786-refactor-aws-credentials
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/244.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #244
----
commit 164ebcd9c89a28ae6c1b40fb009044bc04de3195
Author: James Wing <jv...@gmail.com>
Date: 2016-02-22T18:14:47Z
NIFI-786 AWS credential refactoring and enhancements
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-786 AWS credential refactoring and enhance...
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the pull request:
https://github.com/apache/nifi/pull/244#issuecomment-221167882
@jskora, thanks for your help reviewing and merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-786 AWS credential refactoring and enhance...
Posted by jskora <gi...@git.apache.org>.
Github user jskora commented on the pull request:
https://github.com/apache/nifi/pull/244#issuecomment-220749583
I'm starting to review and test this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-786 AWS credential refactoring and enhance...
Posted by jskora <gi...@git.apache.org>.
Github user jskora commented on the pull request:
https://github.com/apache/nifi/pull/244#issuecomment-221163835
This is really nice, it was great being able to just provide the AWS CLI profile and have setting automatically picked up.
Great improvement, thanks James!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-786 AWS credential refactoring and enhance...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/244
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---