You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/13 16:19:44 UTC
[GitHub] [kafka] edoardocomar opened a new pull request, #13113: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted
edoardocomar opened a new pull request, #13113:
URL: https://github.com/apache/kafka/pull/13113
Do not recreate the BrokerTopicMetrics on creating the fetch response to a DelayedFetch request executed after a topic was deleted
Add a variant of MetricsTest.testBrokerTopicMetricsUnregisteredAfterDeletingTopic
where messages are consumed
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] edoardocomar commented on pull request #13113: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted
Posted by "edoardocomar (via GitHub)" <gi...@apache.org>.
edoardocomar commented on PR #13113:
URL: https://github.com/apache/kafka/pull/13113#issuecomment-1652693790
bump2 - @mimaison @rajinisivaram @tombentley @ijuma
I'd like this not to be closed by staleness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13113: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13113:
URL: https://github.com/apache/kafka/pull/13113#issuecomment-1585816388
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] edoardocomar commented on pull request #13113: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted
Posted by "edoardocomar (via GitHub)" <gi...@apache.org>.
edoardocomar commented on PR #13113:
URL: https://github.com/apache/kafka/pull/13113#issuecomment-1453510691
bump @mimaison @rajinisivaram @tombentley @ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] edoardocomar commented on pull request #13113: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted
Posted by GitBox <gi...@apache.org>.
edoardocomar commented on PR #13113:
URL: https://github.com/apache/kafka/pull/13113#issuecomment-1382078154
This PR comes adapted to current trunk many many years after https://github.com/apache/kafka/pull/4204
thanks to @mimaison @ijuma @rajinisivaram who had reviewed it.
That was never merged, as there is still the possibility of a race between topic deletion and metric being recreated,
although within a very small timing window. But a consensus appeared to have been recahed that it was worth considering.
The rationale for coming back to this is heuristic, as this patch has been adopted and used for more than 5 years in my organisation, where before this we were able to detect metrics leaking in long lived clusters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org