You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "jira-importer (via GitHub)" <gi...@apache.org> on 2025/04/02 08:01:56 UTC

[I] [MPOM-134] Add profile to use a different resource bundle for incubator projects [maven-apache-parent]

jira-importer opened a new issue, #326:
URL: https://github.com/apache/maven-apache-parent/issues/326

   **[Christopher Tubbs](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ctubbsii)** opened **[MPOM-134](https://issues.apache.org/jira/browse/MPOM-134?redirect=false)** and commented
   
   The `org.apache:apache-jar-resource-bundle:1.4` resourceBundle currently specified in the parent POM does not handle the DISCLAIMER file for incubator projects.
   
   It would be nice if there were an incubation profile, which could be activated for incubating projects, to use an incubating resource bundle which did handle this DISCLAIMER file.
   
   This could be done in several ways:
   
   1. An optional second execution of the `maven-remote-resources-plugin` could run when the profile is activated, which handles a second resource bundle for the DISCLAIMER file.
   2. The current resourceBundle could be turned into a property, which is overridden when the profile is activated, using a resourceBundle which handles everything the current one does, plus the DISCLAIMER file.
   3. The current `maven-remote-resources-plugin` execution could have the `<resourceBundles>` element changed to `<resourceBundles combine.children="append">`, and the profile could specify an additional `<resourceBundle>` to handle the DISCLAIMER file, for the same execution id of `maven-remote-resources-plugin`.
   
   
   
   ---
   
   **Affects:** ASF-18
   
   **Issue Links:**
   - [MPOM-218](https://issues.apache.org/jira/browse/MPOM-218) consider impact of maven-remote-resources-plugin in plugins not pluginManagement
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MPOM-134] Add profile to use a different resource bundle for incubator projects [maven-apache-parent]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #326:
URL: https://github.com/apache/maven-apache-parent/issues/326#issuecomment-2771683397

   **[Herve Boutemy](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=hboutemy)** commented
   
   still no solution: postponing to ASF-21
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MPOM-134] Add profile to use a different resource bundle for incubator projects [maven-apache-parent]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #326:
URL: https://github.com/apache/maven-apache-parent/issues/326#issuecomment-2771683496

   **[Slawomir Jaranowski](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=slawekjaranowski)** commented
   
   In https://github.com/apache/maven-apache-parent/pull/305 we added a property `resourceBundleArtifact`  to allow override used bundle
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MPOM-134] Add profile to use a different resource bundle for incubator projects [maven-apache-parent]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #326:
URL: https://github.com/apache/maven-apache-parent/issues/326#issuecomment-2771683274

   **[Christopher Tubbs](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ctubbsii)** commented
   
   Option 1 isn't great because a second execution slows down the build slightly, and changes nearly as much as option 3.
   
   Option 2 is the most minimal change to the parent POM, and would also allow children to override the property, but it would require a lot of duplication between the current resourceBundle and the replacement.
   
   Option 3 is probably the best because it adds a second resource bundle without a second execution.
   
   The actual second resource bundle would have to be created, to handle the DISCLAIMER file.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MPOM-134] Add profile to use a different resource bundle for incubator projects [maven-apache-parent]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #326:
URL: https://github.com/apache/maven-apache-parent/issues/326#issuecomment-2771683368

   **[Herve Boutemy](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=hboutemy)** commented
   
   we did not find any solution yet to this issue
   I'm postponing to ASF-20...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MPOM-134] Add profile to use a different resource bundle for incubator projects [maven-apache-parent]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #326:
URL: https://github.com/apache/maven-apache-parent/issues/326#issuecomment-2771683446

   **[Slawomir Jaranowski](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=slawekjaranowski)** commented
   
   Project issues moved to GitHub, please copy to it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MPOM-134] Add profile to use a different resource bundle for incubator projects [maven-apache-parent]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #326:
URL: https://github.com/apache/maven-apache-parent/issues/326#issuecomment-2771683292

   **[Herve Boutemy](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=hboutemy)** commented
   
   yes, option 3 is the way to go to add an additional `resourceBundle` value from a profile
   
   the question is: how to activate this profile?
   do you expect to add instructions to activate the profile manually through `mvn -Pincubator`?
   
   Notice: I'm struggling with an equivalent issue after MPOM-96: writing the profile was a first step, but now I see that the big issue is to make is automagically activate (and the pom property I documented just does not work...)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MPOM-134] Add profile to use a different resource bundle for incubator projects [maven-apache-parent]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #326:
URL: https://github.com/apache/maven-apache-parent/issues/326#issuecomment-2771683306

   **[Christopher Tubbs](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ctubbsii)** commented
   
   Instructions to add `-Pincubator` would work. A more complicated, but more automatic, approach would be to create a small Maven plugin to be included in the parent POM which adds the resource bundle when it detects a version number with the `-incubator` pattern.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MPOM-134] Add profile to use a different resource bundle for incubator projects [maven-apache-parent]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #326:
URL: https://github.com/apache/maven-apache-parent/issues/326#issuecomment-2771683333

   **[Christopher Tubbs](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ctubbsii)** commented
   
   A simple approach would be to make it a variable, and incubator projects would just override a property like `asf.resourceBundle` in their POM.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org