You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/08/05 03:23:14 UTC
Re: Review Request 23911: multihashmap.getKey() method (useful for fixing
MESOS-947)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23911/#review49551
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On July 28, 2014, 8:22 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23911/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 8:22 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-947
> https://issues.apache.org/jira/browse/MESOS-947
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Small extension of stout that is useful for fixing MESOS-947, but also in general. adding a getKey() method to multihashmap, which finds a key given a value in the map.
>
> A dependent Mesos patch fixing MESOS-947 will follow promptly.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp ecda6a941077b3e4f9585674b0b5d00d35c5aa1a
>
> Diff: https://reviews.apache.org/r/23911/diff/
>
>
> Testing
> -------
>
> The method behaves as expected in the unit test for MESOS-947. I did not create stout unit tests for it. (There is no precedence for testing multihashmap and this particular piece of code is very straightforward.)
>
>
> Thanks,
>
> Bernd Mathiske
>
>