DERBY-516 patch and JUnit download

["David W. Van Couvering" <Da...@Sun.COM>]

Hi, Rick.  I am working on reviewing and hopefully ultimately committing 
your patch for the compatibility tests (DERBY-516).  I noticed in 
BUILDING.txt that you are asking to download a specific version of JUnit 
from http://www.junit.org.

This site only gives you the latest version, which concerns me because 
over time the version we depend upon will drift from the version 
available on the web site.

I did some poking around, and you can get historical versions of JUnit 
from the sourceforge site:

http://sourceforge.net/projects/junit

I am going to change the documentation in BUILDING.txt to show this link 
rather than http://www.junit.org.

Somebody peep if you think this isn't a good idea.

Thanks,

David

Re: DERBY-516 patch and JUnit download

[Rick Hillegas <Ri...@Sun.COM>]

Thanks, Bryan. I'll add this warning to BUILDING.txt too.

Cheers,
-Rick

Bryan Pendleton wrote:

>> Thanks for raising and addressing this issue. In specifying the JUnit 
>> version, I was mimicking the way that BUILDING.txt treats Ant. I like 
>> Dan's suggestion and I'll amend the scripts accordingly. I'll also 
>> amend BUILDING.txt to say that the build succeeds with JUnit 3.8.1 
>> but that you can probably use the latest version available from JUnit.
>
>
> This isn't probably a problem yet, but I think I've heard that JUnit 4
> is a pretty massive change from JUnit 3. In particular, JUnit 4 switches
> to usage of Java source annotations (the "@" syntax) for specifying
> test behavior, and hence requires that you use JDK 1.5 or higher.
>
> Since Derby probably doesn't want to require JDK 1.5 yet, we may actually
> have a requirement to stick with JUnit 3 for a while.
>
> thanks,
>
> bryan
>
>
>

Re: DERBY-516 patch and JUnit download

[Bryan Pendleton <bp...@amberpoint.com>]

> Thanks for raising and addressing this issue. In specifying the JUnit 
> version, I was mimicking the way that BUILDING.txt treats Ant. I like 
> Dan's suggestion and I'll amend the scripts accordingly. I'll also amend 
> BUILDING.txt to say that the build succeeds with JUnit 3.8.1 but that 
> you can probably use the latest version available from JUnit.

This isn't probably a problem yet, but I think I've heard that JUnit 4
is a pretty massive change from JUnit 3. In particular, JUnit 4 switches
to usage of Java source annotations (the "@" syntax) for specifying
test behavior, and hence requires that you use JDK 1.5 or higher.

Since Derby probably doesn't want to require JDK 1.5 yet, we may actually
have a requirement to stick with JUnit 3 for a while.

thanks,

bryan

Re: DERBY-516 patch and JUnit download

[Rick Hillegas <Ri...@Sun.COM>]

Hi David and Dan,

Thanks for raising and addressing this issue. In specifying the JUnit 
version, I was mimicking the way that BUILDING.txt treats Ant. I like 
Dan's suggestion and I'll amend the scripts accordingly. I'll also amend 
BUILDING.txt to say that the build succeeds with JUnit 3.8.1 but that 
you can probably use the latest version available from JUnit.

Cheers,
-Rick

Daniel John Debrunner wrote:

>David W. Van Couvering wrote:
>
>  
>
>>Hi, Rick.  I am working on reviewing and hopefully ultimately committing
>>your patch for the compatibility tests (DERBY-516).  I noticed in
>>BUILDING.txt that you are asking to download a specific version of JUnit
>>from http://www.junit.org.
>>    
>>
>
>Why is a specific version needed? If there's no obvious requirement for
>a specific version then the instructions should indicate that it has
>been tested with version X but any version >= X should work.
>
>I know for downloads like jikes a specific version is needed because the
>later versions have some bug that stops it compiling Derby.
>
>Dan.
>
>  
>

Re: DERBY-516 patch and JUnit download

[Daniel John Debrunner <dj...@debrunners.com>]

David W. Van Couvering wrote:

> Hi, Rick.  I am working on reviewing and hopefully ultimately committing
> your patch for the compatibility tests (DERBY-516).  I noticed in
> BUILDING.txt that you are asking to download a specific version of JUnit
> from http://www.junit.org.

Why is a specific version needed? If there's no obvious requirement for
a specific version then the instructions should indicate that it has
been tested with version X but any version >= X should work.

I know for downloads like jikes a specific version is needed because the
later versions have some bug that stops it compiling Derby.

Dan.