You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/01/15 03:36:56 UTC
[GitHub] [incubator-doris] Sunt-ing opened a new pull request #5248: [Doc] Update PULL_REQUEST_TEMPLATE.md: a reword suggestion
Sunt-ing opened a new pull request #5248:
URL: https://github.com/apache/incubator-doris/pull/5248
## Proposed changes
A reword suggestion.
Reasons: Before my change, the statement is "If this change need a document change, I have updated the document", and there is a grammar error in it evidently: "change" cannot be paired with "need". Either "changes need" or "change need" will be ok at the grammar level.
According to the context, "changes need" will be better.
Now, the statement is "If these changes need document changes, I have updated the document".
## Types of changes
- [] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
The PR is very clear, so maybe no issue is needed.
Also, it will not break our project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #5248: [Doc] Update PULL_REQUEST_TEMPLATE.md: a reword suggestion
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #5248:
URL: https://github.com/apache/incubator-doris/pull/5248
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org