[GitHub] [storm] Ethanlm commented on a change in pull request #3346: [STORM-3650] attempt to evenly distribute ackers to workers with optional acker-per-worker config

[GitBox <gi...@apache.org>]

Ethanlm commented on a change in pull request #3346:
URL: https://github.com/apache/storm/pull/3346#discussion_r523907837



##########
File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestDefaultResourceAwareStrategy.java
##########
@@ -491,7 +653,10 @@ public void testDefaultResourceAwareStrategy() {
     /**
      * test if the scheduling logic for the DefaultResourceAwareStrategy (when made by network proximity needs.) is correct
      */
-    public void testDefaultResourceAwareStrategyInFavorOfShuffle() {
+    @ParameterizedTest
+    @ValueSource(booleans = {true, false})
+    public void testDefaultResourceAwareStrategyInFavorOfShuffle(boolean useDeprecatedConfigForProximity)

Review comment:
       Should we remove this? I don't think we have `DeprecatedConfigForProximity` in community storm




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org