You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/09/10 21:53:53 UTC
Review Request 25519: Adding "get_scheduler" admin command.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/
-----------------------------------------------------------
Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
Bugs: AURORA-692
https://issues.apache.org/jira/browse/AURORA-692
Repository: aurora
Description
-------
Adding "get_scheduler" admin command.
Diffs
-----
src/main/python/apache/aurora/client/api/scheduler_client.py 02222ba07611b1a367f7157b91a1d4b65b1af176
src/main/python/apache/aurora/client/commands/admin.py bc9a9eee9a187f2c895e70a093871f0b795931c4
src/test/python/apache/aurora/client/api/test_scheduler_client.py 630f662ad2ffb8d192299d98c612ad4892161081
src/test/python/apache/aurora/client/commands/test_admin.py 94e736fb80c3fd7f103437c24f33d7c4451a6969
src/test/python/apache/aurora/client/commands/util.py 21b8830df5a3eccc7d36067369fc16cc5fd9de2a
Diff: https://reviews.apache.org/r/25519/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 25519: Adding "get_scheduler" admin command.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review53071
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On Sept. 10, 2014, 6:43 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25519/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2014, 6:43 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
>
>
> Bugs: AURORA-692
> https://issues.apache.org/jira/browse/AURORA-692
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding "get_scheduler" admin command.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/scheduler_client.py 02222ba07611b1a367f7157b91a1d4b65b1af176
> src/main/python/apache/aurora/client/commands/admin.py bc9a9eee9a187f2c895e70a093871f0b795931c4
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 630f662ad2ffb8d192299d98c612ad4892161081
> src/test/python/apache/aurora/client/commands/test_admin.py 94e736fb80c3fd7f103437c24f33d7c4451a6969
> src/test/python/apache/aurora/client/commands/util.py 21b8830df5a3eccc7d36067369fc16cc5fd9de2a
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 989801cfcbd19109ac140b01cd3024d70c78c829
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 0965b5c8cb89eb36c6e15108c702c39dd68268be
>
> Diff: https://reviews.apache.org/r/25519/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25519: Adding "get_scheduler" admin command.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review52968
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On Sept. 10, 2014, 3:43 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25519/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2014, 3:43 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
>
>
> Bugs: AURORA-692
> https://issues.apache.org/jira/browse/AURORA-692
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding "get_scheduler" admin command.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/scheduler_client.py 02222ba07611b1a367f7157b91a1d4b65b1af176
> src/main/python/apache/aurora/client/commands/admin.py bc9a9eee9a187f2c895e70a093871f0b795931c4
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 630f662ad2ffb8d192299d98c612ad4892161081
> src/test/python/apache/aurora/client/commands/test_admin.py 94e736fb80c3fd7f103437c24f33d7c4451a6969
> src/test/python/apache/aurora/client/commands/util.py 21b8830df5a3eccc7d36067369fc16cc5fd9de2a
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 989801cfcbd19109ac140b01cd3024d70c78c829
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 0965b5c8cb89eb36c6e15108c702c39dd68268be
>
> Diff: https://reviews.apache.org/r/25519/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25519: Adding "get_scheduler" admin command.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/
-----------------------------------------------------------
(Updated Sept. 10, 2014, 10:43 p.m.)
Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
Changes
-------
Adding e2e test.
Bugs: AURORA-692
https://issues.apache.org/jira/browse/AURORA-692
Repository: aurora
Description
-------
Adding "get_scheduler" admin command.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/scheduler_client.py 02222ba07611b1a367f7157b91a1d4b65b1af176
src/main/python/apache/aurora/client/commands/admin.py bc9a9eee9a187f2c895e70a093871f0b795931c4
src/test/python/apache/aurora/client/api/test_scheduler_client.py 630f662ad2ffb8d192299d98c612ad4892161081
src/test/python/apache/aurora/client/commands/test_admin.py 94e736fb80c3fd7f103437c24f33d7c4451a6969
src/test/python/apache/aurora/client/commands/util.py 21b8830df5a3eccc7d36067369fc16cc5fd9de2a
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 989801cfcbd19109ac140b01cd3024d70c78c829
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 0965b5c8cb89eb36c6e15108c702c39dd68268be
Diff: https://reviews.apache.org/r/25519/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 25519: Adding "get_scheduler" admin command.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Sept. 10, 2014, 9:09 p.m., Joe Smith wrote:
> > can you also add e2e test coverage?
Great idea. We need to start adding admin integration tests at some point and why not now:
```...
== Testing Aurora Admin commands...
+ echo '== Getting leading scheduler'
== Getting leading scheduler
+ vagrant ssh -c 'aurora_admin get_scheduler devcluster'
+ grep http://192.168.33.7:8081
Found leading scheduler at: http://192.168.33.7:8081
Connection to 127.0.0.1 closed.
+ RETCODE=0
+ collect_result
+ [[ 0 = 0 ]]
+ echo '***'
***
+ echo 'OK (all tests passed)'
OK (all tests passed)
+ echo '***'
***
+ exit 0```
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review52945
-----------------------------------------------------------
On Sept. 10, 2014, 7:53 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25519/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2014, 7:53 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
>
>
> Bugs: AURORA-692
> https://issues.apache.org/jira/browse/AURORA-692
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding "get_scheduler" admin command.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/scheduler_client.py 02222ba07611b1a367f7157b91a1d4b65b1af176
> src/main/python/apache/aurora/client/commands/admin.py bc9a9eee9a187f2c895e70a093871f0b795931c4
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 630f662ad2ffb8d192299d98c612ad4892161081
> src/test/python/apache/aurora/client/commands/test_admin.py 94e736fb80c3fd7f103437c24f33d7c4451a6969
> src/test/python/apache/aurora/client/commands/util.py 21b8830df5a3eccc7d36067369fc16cc5fd9de2a
>
> Diff: https://reviews.apache.org/r/25519/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25519: Adding "get_scheduler" admin command.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review52945
-----------------------------------------------------------
can you also add e2e test coverage?
- Joe Smith
On Sept. 10, 2014, 12:53 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25519/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2014, 12:53 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
>
>
> Bugs: AURORA-692
> https://issues.apache.org/jira/browse/AURORA-692
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding "get_scheduler" admin command.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/scheduler_client.py 02222ba07611b1a367f7157b91a1d4b65b1af176
> src/main/python/apache/aurora/client/commands/admin.py bc9a9eee9a187f2c895e70a093871f0b795931c4
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 630f662ad2ffb8d192299d98c612ad4892161081
> src/test/python/apache/aurora/client/commands/test_admin.py 94e736fb80c3fd7f103437c24f33d7c4451a6969
> src/test/python/apache/aurora/client/commands/util.py 21b8830df5a3eccc7d36067369fc16cc5fd9de2a
>
> Diff: https://reviews.apache.org/r/25519/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25519: Adding "get_scheduler" admin command.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review52929
-----------------------------------------------------------
Ship it!
Thanks for doing this so quickly.
- Zameer Manji
On Sept. 10, 2014, 12:53 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25519/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2014, 12:53 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
>
>
> Bugs: AURORA-692
> https://issues.apache.org/jira/browse/AURORA-692
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding "get_scheduler" admin command.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/scheduler_client.py 02222ba07611b1a367f7157b91a1d4b65b1af176
> src/main/python/apache/aurora/client/commands/admin.py bc9a9eee9a187f2c895e70a093871f0b795931c4
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 630f662ad2ffb8d192299d98c612ad4892161081
> src/test/python/apache/aurora/client/commands/test_admin.py 94e736fb80c3fd7f103437c24f33d7c4451a6969
> src/test/python/apache/aurora/client/commands/util.py 21b8830df5a3eccc7d36067369fc16cc5fd9de2a
>
> Diff: https://reviews.apache.org/r/25519/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>