You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by n3llino <no...@github.com> on 2016/06/21 14:47:11 UTC

[jclouds/jclouds-labs-openstack] Added Origin Host header management (#206)

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs-openstack/pull/206

-- Commit Summary --

  * Added Origin Host header management

-- File Changes --

    A openstack-poppy/src/main/java/org/jclouds/openstack/poppy/v1/domain/HostHeaderType.java (56)
    M openstack-poppy/src/main/java/org/jclouds/openstack/poppy/v1/domain/Origin.java (55)
    M openstack-poppy/src/test/java/org/jclouds/openstack/poppy/v1/features/ServiceApiLiveTest.java (2)
    M openstack-poppy/src/test/java/org/jclouds/openstack/poppy/v1/features/ServiceApiMockTest.java (4)
    M openstack-poppy/src/test/resources/poppy_service_create_request.json (1)
    M openstack-poppy/src/test/resources/poppy_service_get_response.json (1)
    M openstack-poppy/src/test/resources/poppy_service_list_response.json (3)
    M openstack-poppy/src/test/resources/poppy_service_list_response_paged1.json (3)
    M openstack-poppy/src/test/resources/poppy_service_list_response_paged2.json (3)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-openstack/pull/206.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/206.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/206

Re: [jclouds/jclouds-labs-openstack] Added Origin Host header management (#206)

Posted by n3llino <no...@github.com>.
@n3llino pushed 1 commit.

a35cc8a  Added Origin Host header management, fixed nullable

---
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/206/files/c6796d88766fedc97aeb11f82f8a5c6a9e18ccb2..a35cc8adf6d1ffb5ddece61884bd77aaff9ea57f

Re: [jclouds/jclouds-labs-openstack] Added Origin Host header management (#206)

Posted by n3llino <no...@github.com>.
@n3llino pushed 1 commit.

702ee7b  Added Origin Host header management, changed enum


---
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/206/files/55c17a59c01a5d5a153faf13491ce7e2184ec697..702ee7b87db856d38ebe8af24e1810f81b28f7bd

Re: [jclouds/jclouds-labs-openstack] Added Origin Host header management (#206)

Posted by Ignasi Barrera <no...@github.com>.
Closed #206.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/206#event-700194502

Re: [jclouds/jclouds-labs-openstack] Added Origin Host header management (#206)

Posted by Ignasi Barrera <no...@github.com>.
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +
> +package org.jclouds.openstack.poppy.v1.domain;
> +
> +/**
> + * Specifies the "Host" header type used to access the resources on the origin. Only "domain", "origin" or "custom" are currently allowed.
> + * If "custom" the header value must also be specified.
> + * Defaults to domain.
> + */
> +public enum HostHeaderType {
> +   DOMAIN("domain"),
> +   ORIGIN("origin"),
> +   CUSTOM("custom");

Can we get rid of the name field? Just call `name().toLowerCase()` in the `toString` method and use the `name()` method elsewhere?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/206/files/55c17a59c01a5d5a153faf13491ce7e2184ec697#r67959119

Re: [jclouds/jclouds-labs-openstack] Added Origin Host header management (#206)

Posted by Ignasi Barrera <no...@github.com>.
Squashed, rebased and pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs-openstack/commit/f831f59a) and [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs-openstack/commit/54a273ba). Thanks @n3llino!

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/206#issuecomment-227687743

Re: [jclouds/jclouds-labs-openstack] Added Origin Host header management (#206)

Posted by n3llino <no...@github.com>.
@n3llino pushed 1 commit.

55c17a5  Added Origin Host header management, fixed test json

---
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/206/files/a35cc8adf6d1ffb5ddece61884bd77aaff9ea57f..55c17a59c01a5d5a153faf13491ce7e2184ec697