You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2013/05/29 10:31:01 UTC

[Bug 55024] New: [PATCH] MIRR Formula implementation

https://issues.apache.org/bugzilla/show_bug.cgi?id=55024

            Bug ID: 55024
           Summary: [PATCH] MIRR Formula implementation
           Product: POI
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HSSF
          Assignee: dev@poi.apache.org
          Reporter: carlos.del.est@gmail.com

Created attachment 30339
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30339&action=edit
Patch with source code implementation for IRR function and test case

Implementation for MIRR (Modified internal rate of return) formula for Excel
file, according to http://en.wikipedia.org/wiki/MIRR .

Includes test cases based on Irr function and Excel file to test
implementation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 55024] [PATCH] MIRR Formula implementation

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55024

--- Comment #1 from Carlos Delgado <ca...@gmail.com> ---
Created attachment 30340
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30340&action=edit
Test Spreadsheet for test case, must be added in test-data\spreadsheet

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 55024] [PATCH] MIRR Formula implementation

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55024

Cédric Walter <ce...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Cédric Walter <ce...@gmail.com> ---
I did a review, and your code is not having any error handling. I did add it
according to the specifications
(http://office.microsoft.com/en-001/excel-help/mirr-HP005209180.aspx):

* Values must contain at least one positive value and
 one negative value to calculate the modified internal rate of return.
 Otherwise, MIRR returns the #DIV/0! error value.

By the way the above specification is wrong, in an Excel sheet, i discover:

when all values are positive, excel return a #DIV/0! -> expected as stated
above
when all values are negative, excel return -1 (or -100%) -> not expected but
this behavior is implemented now and covered by tests

I also added MIRR formulas to FormulaEvalTest.xls (were missing)

you can check my changes in revision 1538795

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org