You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/23 00:39:18 UTC
[GitHub] [incubator-devlake] e2corporation opened a new pull request, #2586: `hotfix` `v0.12.0` config-ui: fix jira blanking on tab-switch + entity restrictions
e2corporation opened a new pull request, #2586:
URL: https://github.com/apache/incubator-devlake/pull/2586
### ⚠️ Config-UI / Blueprints Workflow
### Description
This PR applies another set QA Bugfixes Config-UI for the `v0.12.0` **Blueprints Release**. A workflow validation rule has also been added to prevent users from Advancing from the first step if a **disconnected** connection is selected.
- [ ] **JIRA** Transformation Settings _BLANK_ on Tab Switch (Multi-conn)
- [ ] #2580
- [ ] Data Entity Transformation Restrictions
- [ ] #2582
- [ ] **UX**: Update Integration Provider Icons Primary Color
- [ ] **Workflow Validation** - Prevent NEXT action if a Disconnected/Offline connection has been selected for the blueprint.
### Does this close any open issues?
#2580, #2582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #2586: `hotfix` `v0.12.0` config-ui: fix jira blanking on tab-switch + entity restrictions
Posted by GitBox <gi...@apache.org>.
klesh merged PR #2586:
URL: https://github.com/apache/incubator-devlake/pull/2586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #2586: `hotfix` `v0.12.0` config-ui: fix jira blanking on tab-switch + entity restrictions
Posted by GitBox <gi...@apache.org>.
klesh commented on PR #2586:
URL: https://github.com/apache/incubator-devlake/pull/2586#issuecomment-1193624175
@e2corporation I'm not sure why we need a separated "Additional Setting", those setting should be part of "Data Entity Setting" IMO.
@Startrekzky @yumengwang03 Would you mind take a look at the question?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #2586: `hotfix` `v0.12.0` config-ui: fix jira blanking on tab-switch + entity restrictions
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #2586:
URL: https://github.com/apache/incubator-devlake/pull/2586#issuecomment-1193036931
@klesh In regards to Data Entity Types and Transformation Settings, what entity scope does the "Additional Settings" section fall under? Currently, for JIRA, additional settings is grouped with Issue Tracking. For GitHub, additional settings is grouped with Code Review.
Additionally, Cross Domain or Source Code Management has no associated transformation settings rules linked to those scopes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] yumengwang03 commented on pull request #2586: `hotfix` `v0.12.0` config-ui: fix jira blanking on tab-switch + entity restrictions
Posted by GitBox <gi...@apache.org>.
yumengwang03 commented on PR #2586:
URL: https://github.com/apache/incubator-devlake/pull/2586#issuecomment-1193688952
>
Additional settings should be grouped with Source Code Management and Issue Tracking, because it is for calculating difference for commits and issues.
I noticed the copywriting also needs some adjustments accordingly:
- If Source Code Management and Issue Tracking are both selected for data entities: "Enable calculation of commit and issue difference"
- Only Source Code Management is selected: "Enable calculation of commit difference"
- Only Issue Tracking is selected: "Enable calculation of issue difference"
If this is too much work for v0.12, we can change the text to "Enable calculation of commit and/or issue difference" for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org