You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/03/11 16:00:51 UTC

Review Request 19040: 2.1.1 is hard coded in our python scripts which causes WEBHCAT install to fail.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19040/
-----------------------------------------------------------

Review request for Ambari and Eugene Chekanskiy.


Bugs: AMBARI-5021
    https://issues.apache.org/jira/browse/AMBARI-5021


Repository: ambari


Description
-------

{code}
######### HCAT
if config['hostLevelParams']['stack_version'] == '2.1.1':
  hcat_conf_dir = '/etc/hive-hcatalog/conf'
  hcat_lib = '/usr/lib/hive-hcatalog/share/hcatalog'
else:
  hcat_conf_dir = '/etc/hcatalog/conf'
  hcat_lib = '/usr/lib/hcatalog/share/hcatalog'


{code}

Since the new stacks are 2.0 and 2.1 this will cause all sorts of failures.  We need to fix and make sure we do something like: 

If stack first 2 digits match 2.0 then we use:

hcat_conf_dir = '/etc/hcatalog/conf'
  hcat_lib = '/usr/lib/hcatalog/share/hcatalog'

else we use the other defaults. 

Similar fix is needed in:
2.0.6/services/HIVE/package/scripts/params.py


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 1ddf0ad 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 033ed99 

Diff: https://reviews.apache.org/r/19040/diff/


Testing
-------


Thanks,

Andrew Onischuk


Re: Review Request 19040: 2.1.1 is hard coded in our python scripts which causes WEBHCAT install to fail.

Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19040/#review36781
-----------------------------------------------------------

Ship it!


Ship It!

- Eugene Chekanskiy


On March 11, 2014, 3:01 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19040/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 3:01 p.m.)
> 
> 
> Review request for Ambari and Eugene Chekanskiy.
> 
> 
> Bugs: AMBARI-5021
>     https://issues.apache.org/jira/browse/AMBARI-5021
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> {code}
> ######### HCAT
> if config['hostLevelParams']['stack_version'] == '2.1.1':
>   hcat_conf_dir = '/etc/hive-hcatalog/conf'
>   hcat_lib = '/usr/lib/hive-hcatalog/share/hcatalog'
> else:
>   hcat_conf_dir = '/etc/hcatalog/conf'
>   hcat_lib = '/usr/lib/hcatalog/share/hcatalog'
> 
> 
> {code}
> 
> Since the new stacks are 2.0 and 2.1 this will cause all sorts of failures.  We need to fix and make sure we do something like: 
> 
> If stack first 2 digits match 2.0 then we use:
> 
> hcat_conf_dir = '/etc/hcatalog/conf'
>   hcat_lib = '/usr/lib/hcatalog/share/hcatalog'
> 
> else we use the other defaults. 
> 
> Similar fix is needed in:
> 2.0.6/services/HIVE/package/scripts/params.py
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 1ddf0ad 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 033ed99 
> 
> Diff: https://reviews.apache.org/r/19040/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 19040: 2.1.1 is hard coded in our python scripts which causes WEBHCAT install to fail.

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19040/
-----------------------------------------------------------

(Updated March 11, 2014, 3:01 p.m.)


Review request for Ambari and Eugene Chekanskiy.


Bugs: AMBARI-5021
    https://issues.apache.org/jira/browse/AMBARI-5021


Repository: ambari


Description
-------

{code}
######### HCAT
if config['hostLevelParams']['stack_version'] == '2.1.1':
  hcat_conf_dir = '/etc/hive-hcatalog/conf'
  hcat_lib = '/usr/lib/hive-hcatalog/share/hcatalog'
else:
  hcat_conf_dir = '/etc/hcatalog/conf'
  hcat_lib = '/usr/lib/hcatalog/share/hcatalog'


{code}

Since the new stacks are 2.0 and 2.1 this will cause all sorts of failures.  We need to fix and make sure we do something like: 

If stack first 2 digits match 2.0 then we use:

hcat_conf_dir = '/etc/hcatalog/conf'
  hcat_lib = '/usr/lib/hcatalog/share/hcatalog'

else we use the other defaults. 

Similar fix is needed in:
2.0.6/services/HIVE/package/scripts/params.py


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 1ddf0ad 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 033ed99 

Diff: https://reviews.apache.org/r/19040/diff/


Testing
-------


Thanks,

Andrew Onischuk