You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/05/22 15:43:04 UTC

[GitHub] [incubator-ratis] arp7 commented on a change in pull request #103: RATIS-757. Remove native library

arp7 commented on a change in pull request #103:
URL: https://github.com/apache/incubator-ratis/pull/103#discussion_r429321445



##########
File path: ratis-server/src/main/java/org/apache/ratis/server/storage/SnapshotManager.java
##########
@@ -116,8 +116,6 @@ public void installSnapshot(StateMachine stateMachine,
           LOG.warn("The snapshot md5 digest {} does not match expected {}",
               digest, expectedDigest);
           // rename the temp snapshot file to .corrupt
-//          NativeIO.renameTo(tmpSnapshotFile, // TODO:
-//              dir.getCorruptSnapshotFile(lastIncludedTerm, lastIncludedIndex));

Review comment:
       Hi @dineshchitlangia, why is this rename no longer required?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org