You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "asl3 (via GitHub)" <gi...@apache.org> on 2023/07/12 19:31:42 UTC
[GitHub] [spark] asl3 opened a new pull request, #41967: [SPARK-44397][PYTHON] Expose assertDataFrameEqual in pyspark.testing.utils
asl3 opened a new pull request, #41967:
URL: https://github.com/apache/spark/pull/41967
### What changes were proposed in this pull request?
This PR adds the util function `assertDataFrameEqual` to the `__all__` list in `pyspark/testing/utils.py`.
### Why are the changes needed?
The change is needed to expose `assertDataFrameEqual`.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #41967: [SPARK-44397][PYTHON] Expose assertDataFrameEqual in pyspark.testing.utils
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #41967:
URL: https://github.com/apache/spark/pull/41967#issuecomment-1633390271
LGTM, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #41967: [SPARK-44397][PYTHON] Expose assertDataFrameEqual in pyspark.testing.utils
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #41967: [SPARK-44397][PYTHON] Expose assertDataFrameEqual in pyspark.testing.utils
URL: https://github.com/apache/spark/pull/41967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a diff in pull request #41967: [SPARK-44397][PYTHON] Expose assertDataFrameEqual in pyspark.testing.utils
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #41967:
URL: https://github.com/apache/spark/pull/41967#discussion_r1261677959
##########
python/pyspark/testing/utils.py:
##########
@@ -55,6 +55,7 @@
# No NumPy, but that's okay, we'll skip those tests
pass
+__all__ = ["assertDataFrameEqual"]
Review Comment:
Why do we need this? I think we already have it in `testing.__init__`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a diff in pull request #41967: [SPARK-44397][PYTHON] Expose assertDataFrameEqual in pyspark.testing.utils
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #41967:
URL: https://github.com/apache/spark/pull/41967#discussion_r1261677959
##########
python/pyspark/testing/utils.py:
##########
@@ -55,6 +55,7 @@
# No NumPy, but that's okay, we'll skip those tests
pass
+__all__ = ["assertDataFrameEqual"]
Review Comment:
Why do we need this? I think we already have it in `testing.__init__`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org