Re: [PR] OAK-11306: fix GCP bucket cleanup post running tests [jackrabbit-oak]

["rishabhdaim (via GitHub)" <gi...@apache.org>]

rishabhdaim commented on code in PR #1902:
URL: https://github.com/apache/jackrabbit-oak/pull/1902#discussion_r1883630464


##########
oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3Backend.java:
##########
@@ -1368,8 +1370,15 @@ public KeyRenameThread(String oldKey) {
     /**
      * Enum to indicate remote storage mode
      */
-    private enum RemoteStorageMode {
+    enum RemoteStorageMode {
         S3,
-        GCP
+        GCP;

Review Comment:
   ```suggestion
                   enum RemoteStorageMode {
           S3("s3"),
           GCP("gcp");
   
           RemoteStorageMode(String name) {
           }
   
           @NotNull
           static RemoteStorageMode fromString(String mode) {
   
               switch (mode.toLowerCase()) {
                   case "s3": return S3;
                   case "gcp": return GCP;
                   default: return S3;
               }
           }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org