[GitHub] [doris] zhannngchen commented on a diff in pull request #15413: [refactor]remove seek block in segmentIterator

[GitBox <gi...@apache.org>]

zhannngchen commented on code in PR #15413:
URL: https://github.com/apache/doris/pull/15413#discussion_r1058029569


##########
be/src/olap/rowset/segment_v2/segment_iterator.h:
##########
@@ -227,7 +281,10 @@ class SegmentIterator : public RowwiseIterator {
     std::unique_ptr<Schema> _seek_schema;
     // used to binary search the rowid for a given key
     // only used in `_get_row_ranges_by_keys`
-    std::unique_ptr<RowBlockV2> _seek_block;
+    vectorized::MutableColumns _seek_block;
+
+    //todo(wb) remove this field after Rowcursor is removed
+    vectorized::MutableColumns _short_key;

Review Comment:
   _short_key -> _seek_key seems better？it's not **short** actually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org