You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/09/06 17:16:03 UTC

[GitHub] vvraskin commented on a change in pull request #4006: Adjust activation metric schema to reflect reality.

vvraskin commented on a change in pull request #4006:  Adjust activation metric schema to reflect reality.
URL: https://github.com/apache/incubator-openwhisk/pull/4006#discussion_r215707405
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/connector/Message.scala
 ##########
 @@ -147,7 +147,7 @@ case class Activation(name: String,
                       kind: String,
                       conductor: Boolean,
                       memory: Int,
-                      causedBy: Boolean)
+                      causedBy: Option[String])
 
 Review comment:
   this would mean if we serialise the metric for a non-sequence, we won't have the variable in json, right?
   any benefits apart from reducing the payload size?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services