You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "ok2c (via GitHub)" <gi...@apache.org> on 2023/10/06 09:30:27 UTC
[PR] HTTPCORE-756: RFC 9110 conformance improvements [httpcomponents-core]
ok2c opened a new pull request, #439:
URL: https://github.com/apache/httpcomponents-core/pull/439
This PR contains several incremental RFC 9110 conformance improvements
* Handling of HTTPS requests over insecure (non-TLS) connections
* Support for handling connection specific headers
* `Expect` header processing imrovements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] HTTPCORE-756: RFC 9110 conformance improvements [httpcomponents-core]
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on code in PR #439:
URL: https://github.com/apache/httpcomponents-core/pull/439#discussion_r1353098659
##########
httpcore5/src/main/java/org/apache/hc/core5/http/HttpStatus.java:
##########
@@ -197,20 +188,20 @@ private HttpStatus() {
public static final int SC_UNAVAILABLE_FOR_LEGAL_REASONS = 451;
// --- 5xx Server Error ---
- /** {@code 500 Server Error} (HTTP/1.0 - RFC 7231) */
+ /** {@code 500 Server Error} (HTTP Semantics) */
public static final int SC_SERVER_ERROR = 500;
Review Comment:
I noticed multiple instances of the same error code, such as `SC_CLIENT_ERROR` and `SC_CLIENT_ERROR` . Is this intentional, or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] HTTPCORE-756: RFC 9110 conformance improvements [httpcomponents-core]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c merged PR #439:
URL: https://github.com/apache/httpcomponents-core/pull/439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] HTTPCORE-756: RFC 9110 conformance improvements [httpcomponents-core]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on code in PR #439:
URL: https://github.com/apache/httpcomponents-core/pull/439#discussion_r1354891116
##########
httpcore5/src/main/java/org/apache/hc/core5/http/HttpStatus.java:
##########
@@ -197,20 +188,20 @@ private HttpStatus() {
public static final int SC_UNAVAILABLE_FOR_LEGAL_REASONS = 451;
// --- 5xx Server Error ---
- /** {@code 500 Server Error} (HTTP/1.0 - RFC 7231) */
+ /** {@code 500 Server Error} (HTTP Semantics) */
public static final int SC_SERVER_ERROR = 500;
Review Comment:
> I noticed multiple instances of the same error code, such as `SC_CLIENT_ERROR` and `SC_CLIENT_ERROR` . Is this intentional, or am I missing something?
@arturobernalg One defines the first value in a range of status codes: 1xx, 2xx, 3xx, 4xx, 5xx and another one defines a specific status code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] HTTPCORE-756: RFC 9110 conformance improvements [httpcomponents-core]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #439:
URL: https://github.com/apache/httpcomponents-core/pull/439#issuecomment-1750281116
@arturobernalg Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org