You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Clebert Suconic <cl...@gmail.com> on 2020/10/19 14:47:49 UTC
[HEADS-UP] Release on Oct 23rd
I'm planning to finish my work on Server Connections
(https://github.com/apache/activemq-artemis/pull/3294) on the next day
or 2, and I would like to start cutting a release on Friday, with the
Vote thread sent on monday.
That means I will have everything ready to go for a vote on Friday,
and the release vote to be sent on monday.
for the github Pull Requests under review I will also make sure we
merge current relevant PRs... so, if you could make sure you send your
pending changes.. and could even nudge me with a comment on your
github pull requet tagging my name that you would like to include such
PR. (feel free to communicate here as well if you prefer).
--
Clebert Suconic
Re: [HEADS-UP] Release on Oct 23rd
Posted by Clebert Suconic <cl...@gmail.com>.
due to the disconnect issue on broker-connection (a new feature), I'm
pushing this to monday.
On Fri, Oct 30, 2020 at 7:24 AM Robbie Gemmell <ro...@gmail.com> wrote:
>
> If you are preparing a release today I'd say it makes more sense to
> also just start the vote thread today. It doesn't really help anything
> to hold it back until Monday, if it makes any difference at all (which
> it might not) it will only be to slow things down.
>
> You can always say you will close the vote at the same point as if you
> had started it on Monday if you like. It won't make the release occur
> any quicker than if you waited if everything turns out fine, but folks
> get more opportunity to test and give feedback and more chance to do
> so when it's most convenient for them (e.g those in Europe may not get
> to it until Tuesday if holding off, or some people may actually not
> test things in working hours and like having the weekend). Plus if
> there is actually anything of concern they could then get to report it
> earlier than if you held off starting the vote, giving earlier
> opportunity to assess it (e.g first thing Monday for you), and which
> may in fact lead to a release being completed quicker than it could
> have otherwise (e.g should something be decided to be a blocker).
>
> On Fri, 30 Oct 2020 at 02:10, Clebert Suconic <cl...@gmail.com> wrote:
> >
> > I think we are good enough for a release... unless there's any point
> > against, I will cut the release first thing in the morning (US EST
> > time.. kind of an afternoon in Europe)....
> > The release vote thread will be sent on monday morning (I won't be
> > around anyway to answer any email over the weekend, besides I never
> > count the weekend anyways). I will just keep everything ready to send
> > on monday.
> >
> >
> > @Anyone let me know if there's anything holding the release.
> >
> > On Wed, Oct 28, 2020 at 4:11 PM Clebert Suconic
> > <cl...@gmail.com> wrote:
> > >
> > > I would like to have a release on Friday. Let me know if there's
> > > anything still missing on the release..or if there's still any concern
> > > from the recently merged feature.
> > >
> > > On Tue, Oct 27, 2020 at 8:29 PM Clebert Suconic
> > > <cl...@gmail.com> wrote:
> > > >
> > > > New PR sent:
> > > >
> > > > https://github.com/apache/activemq-artemis/pull/3316
> > > >
> > > > On Mon, Oct 26, 2020 at 9:33 PM Clebert Suconic
> > > > <cl...@gmail.com> wrote:
> > > > >
> > > > > I will rework the docs tomorrow, close the PR and send a fresh one at
> > > > > the end of tomorrow.
> > > > >
> > > > > On Mon, Oct 26, 2020 at 12:58 PM Clebert Suconic
> > > > > <cl...@gmail.com> wrote:
> > > > > >
> > > > > > I thought you would be able to unresolve a conversation...
> > > > > >
> > > > > > So, if you could please either open a new conversation, or wait the new PR.
> > > > > >
> > > > > > I can't manage 200+ github comments without resolving conversations
> > > > > > after I deal with the conversation. (my browser actually crashed one
> > > > > > time due to the size).
> > > > > >
> > > > > > On Mon, Oct 26, 2020 at 6:54 AM Robbie Gemmell <ro...@gmail.com> wrote:
> > > > > > >
> > > > > > > On Fri, 23 Oct 2020 at 21:47, Clebert Suconic <cl...@gmail.com> wrote:
> > > > > > > >
> > > > > > > > I was thinking the same actually... I
> > > > > > > >
> > > > > > > > I will just resolve a few last comments, and I will then clone it and
> > > > > > > > open a new one...
> > > > > > > >
> > > > > > > >
> > > > > > > > just one request for now at least.. if you make a comment on a
> > > > > > > > previously resolved conversation, please unresolve it.. as I'm not
> > > > > > > > being able to look at resolved conversations.
> > > > > > > >
> > > > > > >
> > > > > > > I actually can't unresolve the conversations, even though I made most
> > > > > > > of them, I had just commented to someone else about that earlier on
> > > > > > > Friday.
> > > > > > >
> > > > > > > > As of now I finished SSL implementation and I will polish things on
> > > > > > > > monday (do a set of review from myself and open a new PR).
> > > > > > > >
> > > > > > > > Have a nice weekend!
> > > > > > > >
> > > > > > > >
> > > > > > > > On Fri, Oct 23, 2020 at 1:00 PM Robbie Gemmell <ro...@gmail.com> wrote:
> > > > > > > > >
> > > > > > > > > It might be worth raising a fresh PR for finishing off review after
> > > > > > > > > you've done the next set of polish, the existing one has seen such a
> > > > > > > > > bunch of change and as a result has got so big as to be a bit
> > > > > > > > > unmanageable :)
> > > > > > > > >
> > > > > > > > > On Fri, 23 Oct 2020 at 15:49, Clebert Suconic <cl...@gmail.com> wrote:
> > > > > > > > > >
> > > > > > > > > > I am obviously pushing back the release.. I will do as soon as I we
> > > > > > > > > > merge https://github.com/apache/activemq-artemis/pull/3294 (which will
> > > > > > > > > > include some tests before I merge it)
> > > > > > > > > >
> > > > > > > > > > On Mon, Oct 19, 2020 at 10:47 AM Clebert Suconic
> > > > > > > > > > <cl...@gmail.com> wrote:
> > > > > > > > > > >
> > > > > > > > > > > I'm planning to finish my work on Server Connections
> > > > > > > > > > > (https://github.com/apache/activemq-artemis/pull/3294) on the next day
> > > > > > > > > > > or 2, and I would like to start cutting a release on Friday, with the
> > > > > > > > > > > Vote thread sent on monday.
> > > > > > > > > > >
> > > > > > > > > > > That means I will have everything ready to go for a vote on Friday,
> > > > > > > > > > > and the release vote to be sent on monday.
> > > > > > > > > > >
> > > > > > > > > > > for the github Pull Requests under review I will also make sure we
> > > > > > > > > > > merge current relevant PRs... so, if you could make sure you send your
> > > > > > > > > > > pending changes.. and could even nudge me with a comment on your
> > > > > > > > > > > github pull requet tagging my name that you would like to include such
> > > > > > > > > > > PR. (feel free to communicate here as well if you prefer).
> > > > > > > > > > >
> > > > > > > > > > > --
> > > > > > > > > > > Clebert Suconic
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Clebert Suconic
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Clebert Suconic
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Clebert Suconic
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Clebert Suconic
> > > >
> > > >
> > > >
> > > > --
> > > > Clebert Suconic
> > >
> > >
> > >
> > > --
> > > Clebert Suconic
> >
> >
> >
> > --
> > Clebert Suconic
--
Clebert Suconic
Re: [HEADS-UP] Release on Oct 23rd
Posted by Robbie Gemmell <ro...@gmail.com>.
If you are preparing a release today I'd say it makes more sense to
also just start the vote thread today. It doesn't really help anything
to hold it back until Monday, if it makes any difference at all (which
it might not) it will only be to slow things down.
You can always say you will close the vote at the same point as if you
had started it on Monday if you like. It won't make the release occur
any quicker than if you waited if everything turns out fine, but folks
get more opportunity to test and give feedback and more chance to do
so when it's most convenient for them (e.g those in Europe may not get
to it until Tuesday if holding off, or some people may actually not
test things in working hours and like having the weekend). Plus if
there is actually anything of concern they could then get to report it
earlier than if you held off starting the vote, giving earlier
opportunity to assess it (e.g first thing Monday for you), and which
may in fact lead to a release being completed quicker than it could
have otherwise (e.g should something be decided to be a blocker).
On Fri, 30 Oct 2020 at 02:10, Clebert Suconic <cl...@gmail.com> wrote:
>
> I think we are good enough for a release... unless there's any point
> against, I will cut the release first thing in the morning (US EST
> time.. kind of an afternoon in Europe)....
> The release vote thread will be sent on monday morning (I won't be
> around anyway to answer any email over the weekend, besides I never
> count the weekend anyways). I will just keep everything ready to send
> on monday.
>
>
> @Anyone let me know if there's anything holding the release.
>
> On Wed, Oct 28, 2020 at 4:11 PM Clebert Suconic
> <cl...@gmail.com> wrote:
> >
> > I would like to have a release on Friday. Let me know if there's
> > anything still missing on the release..or if there's still any concern
> > from the recently merged feature.
> >
> > On Tue, Oct 27, 2020 at 8:29 PM Clebert Suconic
> > <cl...@gmail.com> wrote:
> > >
> > > New PR sent:
> > >
> > > https://github.com/apache/activemq-artemis/pull/3316
> > >
> > > On Mon, Oct 26, 2020 at 9:33 PM Clebert Suconic
> > > <cl...@gmail.com> wrote:
> > > >
> > > > I will rework the docs tomorrow, close the PR and send a fresh one at
> > > > the end of tomorrow.
> > > >
> > > > On Mon, Oct 26, 2020 at 12:58 PM Clebert Suconic
> > > > <cl...@gmail.com> wrote:
> > > > >
> > > > > I thought you would be able to unresolve a conversation...
> > > > >
> > > > > So, if you could please either open a new conversation, or wait the new PR.
> > > > >
> > > > > I can't manage 200+ github comments without resolving conversations
> > > > > after I deal with the conversation. (my browser actually crashed one
> > > > > time due to the size).
> > > > >
> > > > > On Mon, Oct 26, 2020 at 6:54 AM Robbie Gemmell <ro...@gmail.com> wrote:
> > > > > >
> > > > > > On Fri, 23 Oct 2020 at 21:47, Clebert Suconic <cl...@gmail.com> wrote:
> > > > > > >
> > > > > > > I was thinking the same actually... I
> > > > > > >
> > > > > > > I will just resolve a few last comments, and I will then clone it and
> > > > > > > open a new one...
> > > > > > >
> > > > > > >
> > > > > > > just one request for now at least.. if you make a comment on a
> > > > > > > previously resolved conversation, please unresolve it.. as I'm not
> > > > > > > being able to look at resolved conversations.
> > > > > > >
> > > > > >
> > > > > > I actually can't unresolve the conversations, even though I made most
> > > > > > of them, I had just commented to someone else about that earlier on
> > > > > > Friday.
> > > > > >
> > > > > > > As of now I finished SSL implementation and I will polish things on
> > > > > > > monday (do a set of review from myself and open a new PR).
> > > > > > >
> > > > > > > Have a nice weekend!
> > > > > > >
> > > > > > >
> > > > > > > On Fri, Oct 23, 2020 at 1:00 PM Robbie Gemmell <ro...@gmail.com> wrote:
> > > > > > > >
> > > > > > > > It might be worth raising a fresh PR for finishing off review after
> > > > > > > > you've done the next set of polish, the existing one has seen such a
> > > > > > > > bunch of change and as a result has got so big as to be a bit
> > > > > > > > unmanageable :)
> > > > > > > >
> > > > > > > > On Fri, 23 Oct 2020 at 15:49, Clebert Suconic <cl...@gmail.com> wrote:
> > > > > > > > >
> > > > > > > > > I am obviously pushing back the release.. I will do as soon as I we
> > > > > > > > > merge https://github.com/apache/activemq-artemis/pull/3294 (which will
> > > > > > > > > include some tests before I merge it)
> > > > > > > > >
> > > > > > > > > On Mon, Oct 19, 2020 at 10:47 AM Clebert Suconic
> > > > > > > > > <cl...@gmail.com> wrote:
> > > > > > > > > >
> > > > > > > > > > I'm planning to finish my work on Server Connections
> > > > > > > > > > (https://github.com/apache/activemq-artemis/pull/3294) on the next day
> > > > > > > > > > or 2, and I would like to start cutting a release on Friday, with the
> > > > > > > > > > Vote thread sent on monday.
> > > > > > > > > >
> > > > > > > > > > That means I will have everything ready to go for a vote on Friday,
> > > > > > > > > > and the release vote to be sent on monday.
> > > > > > > > > >
> > > > > > > > > > for the github Pull Requests under review I will also make sure we
> > > > > > > > > > merge current relevant PRs... so, if you could make sure you send your
> > > > > > > > > > pending changes.. and could even nudge me with a comment on your
> > > > > > > > > > github pull requet tagging my name that you would like to include such
> > > > > > > > > > PR. (feel free to communicate here as well if you prefer).
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Clebert Suconic
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Clebert Suconic
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Clebert Suconic
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Clebert Suconic
> > > >
> > > >
> > > >
> > > > --
> > > > Clebert Suconic
> > >
> > >
> > >
> > > --
> > > Clebert Suconic
> >
> >
> >
> > --
> > Clebert Suconic
>
>
>
> --
> Clebert Suconic
Re: [HEADS-UP] Release on Oct 23rd
Posted by Clebert Suconic <cl...@gmail.com>.
I think we are good enough for a release... unless there's any point
against, I will cut the release first thing in the morning (US EST
time.. kind of an afternoon in Europe)....
The release vote thread will be sent on monday morning (I won't be
around anyway to answer any email over the weekend, besides I never
count the weekend anyways). I will just keep everything ready to send
on monday.
@Anyone let me know if there's anything holding the release.
On Wed, Oct 28, 2020 at 4:11 PM Clebert Suconic
<cl...@gmail.com> wrote:
>
> I would like to have a release on Friday. Let me know if there's
> anything still missing on the release..or if there's still any concern
> from the recently merged feature.
>
> On Tue, Oct 27, 2020 at 8:29 PM Clebert Suconic
> <cl...@gmail.com> wrote:
> >
> > New PR sent:
> >
> > https://github.com/apache/activemq-artemis/pull/3316
> >
> > On Mon, Oct 26, 2020 at 9:33 PM Clebert Suconic
> > <cl...@gmail.com> wrote:
> > >
> > > I will rework the docs tomorrow, close the PR and send a fresh one at
> > > the end of tomorrow.
> > >
> > > On Mon, Oct 26, 2020 at 12:58 PM Clebert Suconic
> > > <cl...@gmail.com> wrote:
> > > >
> > > > I thought you would be able to unresolve a conversation...
> > > >
> > > > So, if you could please either open a new conversation, or wait the new PR.
> > > >
> > > > I can't manage 200+ github comments without resolving conversations
> > > > after I deal with the conversation. (my browser actually crashed one
> > > > time due to the size).
> > > >
> > > > On Mon, Oct 26, 2020 at 6:54 AM Robbie Gemmell <ro...@gmail.com> wrote:
> > > > >
> > > > > On Fri, 23 Oct 2020 at 21:47, Clebert Suconic <cl...@gmail.com> wrote:
> > > > > >
> > > > > > I was thinking the same actually... I
> > > > > >
> > > > > > I will just resolve a few last comments, and I will then clone it and
> > > > > > open a new one...
> > > > > >
> > > > > >
> > > > > > just one request for now at least.. if you make a comment on a
> > > > > > previously resolved conversation, please unresolve it.. as I'm not
> > > > > > being able to look at resolved conversations.
> > > > > >
> > > > >
> > > > > I actually can't unresolve the conversations, even though I made most
> > > > > of them, I had just commented to someone else about that earlier on
> > > > > Friday.
> > > > >
> > > > > > As of now I finished SSL implementation and I will polish things on
> > > > > > monday (do a set of review from myself and open a new PR).
> > > > > >
> > > > > > Have a nice weekend!
> > > > > >
> > > > > >
> > > > > > On Fri, Oct 23, 2020 at 1:00 PM Robbie Gemmell <ro...@gmail.com> wrote:
> > > > > > >
> > > > > > > It might be worth raising a fresh PR for finishing off review after
> > > > > > > you've done the next set of polish, the existing one has seen such a
> > > > > > > bunch of change and as a result has got so big as to be a bit
> > > > > > > unmanageable :)
> > > > > > >
> > > > > > > On Fri, 23 Oct 2020 at 15:49, Clebert Suconic <cl...@gmail.com> wrote:
> > > > > > > >
> > > > > > > > I am obviously pushing back the release.. I will do as soon as I we
> > > > > > > > merge https://github.com/apache/activemq-artemis/pull/3294 (which will
> > > > > > > > include some tests before I merge it)
> > > > > > > >
> > > > > > > > On Mon, Oct 19, 2020 at 10:47 AM Clebert Suconic
> > > > > > > > <cl...@gmail.com> wrote:
> > > > > > > > >
> > > > > > > > > I'm planning to finish my work on Server Connections
> > > > > > > > > (https://github.com/apache/activemq-artemis/pull/3294) on the next day
> > > > > > > > > or 2, and I would like to start cutting a release on Friday, with the
> > > > > > > > > Vote thread sent on monday.
> > > > > > > > >
> > > > > > > > > That means I will have everything ready to go for a vote on Friday,
> > > > > > > > > and the release vote to be sent on monday.
> > > > > > > > >
> > > > > > > > > for the github Pull Requests under review I will also make sure we
> > > > > > > > > merge current relevant PRs... so, if you could make sure you send your
> > > > > > > > > pending changes.. and could even nudge me with a comment on your
> > > > > > > > > github pull requet tagging my name that you would like to include such
> > > > > > > > > PR. (feel free to communicate here as well if you prefer).
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Clebert Suconic
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Clebert Suconic
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Clebert Suconic
> > > >
> > > >
> > > >
> > > > --
> > > > Clebert Suconic
> > >
> > >
> > >
> > > --
> > > Clebert Suconic
> >
> >
> >
> > --
> > Clebert Suconic
>
>
>
> --
> Clebert Suconic
--
Clebert Suconic
Re: [HEADS-UP] Release on Oct 23rd
Posted by Clebert Suconic <cl...@gmail.com>.
I would like to have a release on Friday. Let me know if there's
anything still missing on the release..or if there's still any concern
from the recently merged feature.
On Tue, Oct 27, 2020 at 8:29 PM Clebert Suconic
<cl...@gmail.com> wrote:
>
> New PR sent:
>
> https://github.com/apache/activemq-artemis/pull/3316
>
> On Mon, Oct 26, 2020 at 9:33 PM Clebert Suconic
> <cl...@gmail.com> wrote:
> >
> > I will rework the docs tomorrow, close the PR and send a fresh one at
> > the end of tomorrow.
> >
> > On Mon, Oct 26, 2020 at 12:58 PM Clebert Suconic
> > <cl...@gmail.com> wrote:
> > >
> > > I thought you would be able to unresolve a conversation...
> > >
> > > So, if you could please either open a new conversation, or wait the new PR.
> > >
> > > I can't manage 200+ github comments without resolving conversations
> > > after I deal with the conversation. (my browser actually crashed one
> > > time due to the size).
> > >
> > > On Mon, Oct 26, 2020 at 6:54 AM Robbie Gemmell <ro...@gmail.com> wrote:
> > > >
> > > > On Fri, 23 Oct 2020 at 21:47, Clebert Suconic <cl...@gmail.com> wrote:
> > > > >
> > > > > I was thinking the same actually... I
> > > > >
> > > > > I will just resolve a few last comments, and I will then clone it and
> > > > > open a new one...
> > > > >
> > > > >
> > > > > just one request for now at least.. if you make a comment on a
> > > > > previously resolved conversation, please unresolve it.. as I'm not
> > > > > being able to look at resolved conversations.
> > > > >
> > > >
> > > > I actually can't unresolve the conversations, even though I made most
> > > > of them, I had just commented to someone else about that earlier on
> > > > Friday.
> > > >
> > > > > As of now I finished SSL implementation and I will polish things on
> > > > > monday (do a set of review from myself and open a new PR).
> > > > >
> > > > > Have a nice weekend!
> > > > >
> > > > >
> > > > > On Fri, Oct 23, 2020 at 1:00 PM Robbie Gemmell <ro...@gmail.com> wrote:
> > > > > >
> > > > > > It might be worth raising a fresh PR for finishing off review after
> > > > > > you've done the next set of polish, the existing one has seen such a
> > > > > > bunch of change and as a result has got so big as to be a bit
> > > > > > unmanageable :)
> > > > > >
> > > > > > On Fri, 23 Oct 2020 at 15:49, Clebert Suconic <cl...@gmail.com> wrote:
> > > > > > >
> > > > > > > I am obviously pushing back the release.. I will do as soon as I we
> > > > > > > merge https://github.com/apache/activemq-artemis/pull/3294 (which will
> > > > > > > include some tests before I merge it)
> > > > > > >
> > > > > > > On Mon, Oct 19, 2020 at 10:47 AM Clebert Suconic
> > > > > > > <cl...@gmail.com> wrote:
> > > > > > > >
> > > > > > > > I'm planning to finish my work on Server Connections
> > > > > > > > (https://github.com/apache/activemq-artemis/pull/3294) on the next day
> > > > > > > > or 2, and I would like to start cutting a release on Friday, with the
> > > > > > > > Vote thread sent on monday.
> > > > > > > >
> > > > > > > > That means I will have everything ready to go for a vote on Friday,
> > > > > > > > and the release vote to be sent on monday.
> > > > > > > >
> > > > > > > > for the github Pull Requests under review I will also make sure we
> > > > > > > > merge current relevant PRs... so, if you could make sure you send your
> > > > > > > > pending changes.. and could even nudge me with a comment on your
> > > > > > > > github pull requet tagging my name that you would like to include such
> > > > > > > > PR. (feel free to communicate here as well if you prefer).
> > > > > > > >
> > > > > > > > --
> > > > > > > > Clebert Suconic
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Clebert Suconic
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Clebert Suconic
> > >
> > >
> > >
> > > --
> > > Clebert Suconic
> >
> >
> >
> > --
> > Clebert Suconic
>
>
>
> --
> Clebert Suconic
--
Clebert Suconic
Re: [HEADS-UP] Release on Oct 23rd
Posted by Clebert Suconic <cl...@gmail.com>.
New PR sent:
https://github.com/apache/activemq-artemis/pull/3316
On Mon, Oct 26, 2020 at 9:33 PM Clebert Suconic
<cl...@gmail.com> wrote:
>
> I will rework the docs tomorrow, close the PR and send a fresh one at
> the end of tomorrow.
>
> On Mon, Oct 26, 2020 at 12:58 PM Clebert Suconic
> <cl...@gmail.com> wrote:
> >
> > I thought you would be able to unresolve a conversation...
> >
> > So, if you could please either open a new conversation, or wait the new PR.
> >
> > I can't manage 200+ github comments without resolving conversations
> > after I deal with the conversation. (my browser actually crashed one
> > time due to the size).
> >
> > On Mon, Oct 26, 2020 at 6:54 AM Robbie Gemmell <ro...@gmail.com> wrote:
> > >
> > > On Fri, 23 Oct 2020 at 21:47, Clebert Suconic <cl...@gmail.com> wrote:
> > > >
> > > > I was thinking the same actually... I
> > > >
> > > > I will just resolve a few last comments, and I will then clone it and
> > > > open a new one...
> > > >
> > > >
> > > > just one request for now at least.. if you make a comment on a
> > > > previously resolved conversation, please unresolve it.. as I'm not
> > > > being able to look at resolved conversations.
> > > >
> > >
> > > I actually can't unresolve the conversations, even though I made most
> > > of them, I had just commented to someone else about that earlier on
> > > Friday.
> > >
> > > > As of now I finished SSL implementation and I will polish things on
> > > > monday (do a set of review from myself and open a new PR).
> > > >
> > > > Have a nice weekend!
> > > >
> > > >
> > > > On Fri, Oct 23, 2020 at 1:00 PM Robbie Gemmell <ro...@gmail.com> wrote:
> > > > >
> > > > > It might be worth raising a fresh PR for finishing off review after
> > > > > you've done the next set of polish, the existing one has seen such a
> > > > > bunch of change and as a result has got so big as to be a bit
> > > > > unmanageable :)
> > > > >
> > > > > On Fri, 23 Oct 2020 at 15:49, Clebert Suconic <cl...@gmail.com> wrote:
> > > > > >
> > > > > > I am obviously pushing back the release.. I will do as soon as I we
> > > > > > merge https://github.com/apache/activemq-artemis/pull/3294 (which will
> > > > > > include some tests before I merge it)
> > > > > >
> > > > > > On Mon, Oct 19, 2020 at 10:47 AM Clebert Suconic
> > > > > > <cl...@gmail.com> wrote:
> > > > > > >
> > > > > > > I'm planning to finish my work on Server Connections
> > > > > > > (https://github.com/apache/activemq-artemis/pull/3294) on the next day
> > > > > > > or 2, and I would like to start cutting a release on Friday, with the
> > > > > > > Vote thread sent on monday.
> > > > > > >
> > > > > > > That means I will have everything ready to go for a vote on Friday,
> > > > > > > and the release vote to be sent on monday.
> > > > > > >
> > > > > > > for the github Pull Requests under review I will also make sure we
> > > > > > > merge current relevant PRs... so, if you could make sure you send your
> > > > > > > pending changes.. and could even nudge me with a comment on your
> > > > > > > github pull requet tagging my name that you would like to include such
> > > > > > > PR. (feel free to communicate here as well if you prefer).
> > > > > > >
> > > > > > > --
> > > > > > > Clebert Suconic
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Clebert Suconic
> > > >
> > > >
> > > >
> > > > --
> > > > Clebert Suconic
> >
> >
> >
> > --
> > Clebert Suconic
>
>
>
> --
> Clebert Suconic
--
Clebert Suconic
Re: [HEADS-UP] Release on Oct 23rd
Posted by Clebert Suconic <cl...@gmail.com>.
I will rework the docs tomorrow, close the PR and send a fresh one at
the end of tomorrow.
On Mon, Oct 26, 2020 at 12:58 PM Clebert Suconic
<cl...@gmail.com> wrote:
>
> I thought you would be able to unresolve a conversation...
>
> So, if you could please either open a new conversation, or wait the new PR.
>
> I can't manage 200+ github comments without resolving conversations
> after I deal with the conversation. (my browser actually crashed one
> time due to the size).
>
> On Mon, Oct 26, 2020 at 6:54 AM Robbie Gemmell <ro...@gmail.com> wrote:
> >
> > On Fri, 23 Oct 2020 at 21:47, Clebert Suconic <cl...@gmail.com> wrote:
> > >
> > > I was thinking the same actually... I
> > >
> > > I will just resolve a few last comments, and I will then clone it and
> > > open a new one...
> > >
> > >
> > > just one request for now at least.. if you make a comment on a
> > > previously resolved conversation, please unresolve it.. as I'm not
> > > being able to look at resolved conversations.
> > >
> >
> > I actually can't unresolve the conversations, even though I made most
> > of them, I had just commented to someone else about that earlier on
> > Friday.
> >
> > > As of now I finished SSL implementation and I will polish things on
> > > monday (do a set of review from myself and open a new PR).
> > >
> > > Have a nice weekend!
> > >
> > >
> > > On Fri, Oct 23, 2020 at 1:00 PM Robbie Gemmell <ro...@gmail.com> wrote:
> > > >
> > > > It might be worth raising a fresh PR for finishing off review after
> > > > you've done the next set of polish, the existing one has seen such a
> > > > bunch of change and as a result has got so big as to be a bit
> > > > unmanageable :)
> > > >
> > > > On Fri, 23 Oct 2020 at 15:49, Clebert Suconic <cl...@gmail.com> wrote:
> > > > >
> > > > > I am obviously pushing back the release.. I will do as soon as I we
> > > > > merge https://github.com/apache/activemq-artemis/pull/3294 (which will
> > > > > include some tests before I merge it)
> > > > >
> > > > > On Mon, Oct 19, 2020 at 10:47 AM Clebert Suconic
> > > > > <cl...@gmail.com> wrote:
> > > > > >
> > > > > > I'm planning to finish my work on Server Connections
> > > > > > (https://github.com/apache/activemq-artemis/pull/3294) on the next day
> > > > > > or 2, and I would like to start cutting a release on Friday, with the
> > > > > > Vote thread sent on monday.
> > > > > >
> > > > > > That means I will have everything ready to go for a vote on Friday,
> > > > > > and the release vote to be sent on monday.
> > > > > >
> > > > > > for the github Pull Requests under review I will also make sure we
> > > > > > merge current relevant PRs... so, if you could make sure you send your
> > > > > > pending changes.. and could even nudge me with a comment on your
> > > > > > github pull requet tagging my name that you would like to include such
> > > > > > PR. (feel free to communicate here as well if you prefer).
> > > > > >
> > > > > > --
> > > > > > Clebert Suconic
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Clebert Suconic
> > >
> > >
> > >
> > > --
> > > Clebert Suconic
>
>
>
> --
> Clebert Suconic
--
Clebert Suconic
Re: [HEADS-UP] Release on Oct 23rd
Posted by Clebert Suconic <cl...@gmail.com>.
I thought you would be able to unresolve a conversation...
So, if you could please either open a new conversation, or wait the new PR.
I can't manage 200+ github comments without resolving conversations
after I deal with the conversation. (my browser actually crashed one
time due to the size).
On Mon, Oct 26, 2020 at 6:54 AM Robbie Gemmell <ro...@gmail.com> wrote:
>
> On Fri, 23 Oct 2020 at 21:47, Clebert Suconic <cl...@gmail.com> wrote:
> >
> > I was thinking the same actually... I
> >
> > I will just resolve a few last comments, and I will then clone it and
> > open a new one...
> >
> >
> > just one request for now at least.. if you make a comment on a
> > previously resolved conversation, please unresolve it.. as I'm not
> > being able to look at resolved conversations.
> >
>
> I actually can't unresolve the conversations, even though I made most
> of them, I had just commented to someone else about that earlier on
> Friday.
>
> > As of now I finished SSL implementation and I will polish things on
> > monday (do a set of review from myself and open a new PR).
> >
> > Have a nice weekend!
> >
> >
> > On Fri, Oct 23, 2020 at 1:00 PM Robbie Gemmell <ro...@gmail.com> wrote:
> > >
> > > It might be worth raising a fresh PR for finishing off review after
> > > you've done the next set of polish, the existing one has seen such a
> > > bunch of change and as a result has got so big as to be a bit
> > > unmanageable :)
> > >
> > > On Fri, 23 Oct 2020 at 15:49, Clebert Suconic <cl...@gmail.com> wrote:
> > > >
> > > > I am obviously pushing back the release.. I will do as soon as I we
> > > > merge https://github.com/apache/activemq-artemis/pull/3294 (which will
> > > > include some tests before I merge it)
> > > >
> > > > On Mon, Oct 19, 2020 at 10:47 AM Clebert Suconic
> > > > <cl...@gmail.com> wrote:
> > > > >
> > > > > I'm planning to finish my work on Server Connections
> > > > > (https://github.com/apache/activemq-artemis/pull/3294) on the next day
> > > > > or 2, and I would like to start cutting a release on Friday, with the
> > > > > Vote thread sent on monday.
> > > > >
> > > > > That means I will have everything ready to go for a vote on Friday,
> > > > > and the release vote to be sent on monday.
> > > > >
> > > > > for the github Pull Requests under review I will also make sure we
> > > > > merge current relevant PRs... so, if you could make sure you send your
> > > > > pending changes.. and could even nudge me with a comment on your
> > > > > github pull requet tagging my name that you would like to include such
> > > > > PR. (feel free to communicate here as well if you prefer).
> > > > >
> > > > > --
> > > > > Clebert Suconic
> > > >
> > > >
> > > >
> > > > --
> > > > Clebert Suconic
> >
> >
> >
> > --
> > Clebert Suconic
--
Clebert Suconic
Re: [HEADS-UP] Release on Oct 23rd
Posted by Robbie Gemmell <ro...@gmail.com>.
On Fri, 23 Oct 2020 at 21:47, Clebert Suconic <cl...@gmail.com> wrote:
>
> I was thinking the same actually... I
>
> I will just resolve a few last comments, and I will then clone it and
> open a new one...
>
>
> just one request for now at least.. if you make a comment on a
> previously resolved conversation, please unresolve it.. as I'm not
> being able to look at resolved conversations.
>
I actually can't unresolve the conversations, even though I made most
of them, I had just commented to someone else about that earlier on
Friday.
> As of now I finished SSL implementation and I will polish things on
> monday (do a set of review from myself and open a new PR).
>
> Have a nice weekend!
>
>
> On Fri, Oct 23, 2020 at 1:00 PM Robbie Gemmell <ro...@gmail.com> wrote:
> >
> > It might be worth raising a fresh PR for finishing off review after
> > you've done the next set of polish, the existing one has seen such a
> > bunch of change and as a result has got so big as to be a bit
> > unmanageable :)
> >
> > On Fri, 23 Oct 2020 at 15:49, Clebert Suconic <cl...@gmail.com> wrote:
> > >
> > > I am obviously pushing back the release.. I will do as soon as I we
> > > merge https://github.com/apache/activemq-artemis/pull/3294 (which will
> > > include some tests before I merge it)
> > >
> > > On Mon, Oct 19, 2020 at 10:47 AM Clebert Suconic
> > > <cl...@gmail.com> wrote:
> > > >
> > > > I'm planning to finish my work on Server Connections
> > > > (https://github.com/apache/activemq-artemis/pull/3294) on the next day
> > > > or 2, and I would like to start cutting a release on Friday, with the
> > > > Vote thread sent on monday.
> > > >
> > > > That means I will have everything ready to go for a vote on Friday,
> > > > and the release vote to be sent on monday.
> > > >
> > > > for the github Pull Requests under review I will also make sure we
> > > > merge current relevant PRs... so, if you could make sure you send your
> > > > pending changes.. and could even nudge me with a comment on your
> > > > github pull requet tagging my name that you would like to include such
> > > > PR. (feel free to communicate here as well if you prefer).
> > > >
> > > > --
> > > > Clebert Suconic
> > >
> > >
> > >
> > > --
> > > Clebert Suconic
>
>
>
> --
> Clebert Suconic
Re: [HEADS-UP] Release on Oct 23rd
Posted by Clebert Suconic <cl...@gmail.com>.
I was thinking the same actually... I
I will just resolve a few last comments, and I will then clone it and
open a new one...
just one request for now at least.. if you make a comment on a
previously resolved conversation, please unresolve it.. as I'm not
being able to look at resolved conversations.
As of now I finished SSL implementation and I will polish things on
monday (do a set of review from myself and open a new PR).
Have a nice weekend!
On Fri, Oct 23, 2020 at 1:00 PM Robbie Gemmell <ro...@gmail.com> wrote:
>
> It might be worth raising a fresh PR for finishing off review after
> you've done the next set of polish, the existing one has seen such a
> bunch of change and as a result has got so big as to be a bit
> unmanageable :)
>
> On Fri, 23 Oct 2020 at 15:49, Clebert Suconic <cl...@gmail.com> wrote:
> >
> > I am obviously pushing back the release.. I will do as soon as I we
> > merge https://github.com/apache/activemq-artemis/pull/3294 (which will
> > include some tests before I merge it)
> >
> > On Mon, Oct 19, 2020 at 10:47 AM Clebert Suconic
> > <cl...@gmail.com> wrote:
> > >
> > > I'm planning to finish my work on Server Connections
> > > (https://github.com/apache/activemq-artemis/pull/3294) on the next day
> > > or 2, and I would like to start cutting a release on Friday, with the
> > > Vote thread sent on monday.
> > >
> > > That means I will have everything ready to go for a vote on Friday,
> > > and the release vote to be sent on monday.
> > >
> > > for the github Pull Requests under review I will also make sure we
> > > merge current relevant PRs... so, if you could make sure you send your
> > > pending changes.. and could even nudge me with a comment on your
> > > github pull requet tagging my name that you would like to include such
> > > PR. (feel free to communicate here as well if you prefer).
> > >
> > > --
> > > Clebert Suconic
> >
> >
> >
> > --
> > Clebert Suconic
--
Clebert Suconic
Re: [HEADS-UP] Release on Oct 23rd
Posted by Robbie Gemmell <ro...@gmail.com>.
It might be worth raising a fresh PR for finishing off review after
you've done the next set of polish, the existing one has seen such a
bunch of change and as a result has got so big as to be a bit
unmanageable :)
On Fri, 23 Oct 2020 at 15:49, Clebert Suconic <cl...@gmail.com> wrote:
>
> I am obviously pushing back the release.. I will do as soon as I we
> merge https://github.com/apache/activemq-artemis/pull/3294 (which will
> include some tests before I merge it)
>
> On Mon, Oct 19, 2020 at 10:47 AM Clebert Suconic
> <cl...@gmail.com> wrote:
> >
> > I'm planning to finish my work on Server Connections
> > (https://github.com/apache/activemq-artemis/pull/3294) on the next day
> > or 2, and I would like to start cutting a release on Friday, with the
> > Vote thread sent on monday.
> >
> > That means I will have everything ready to go for a vote on Friday,
> > and the release vote to be sent on monday.
> >
> > for the github Pull Requests under review I will also make sure we
> > merge current relevant PRs... so, if you could make sure you send your
> > pending changes.. and could even nudge me with a comment on your
> > github pull requet tagging my name that you would like to include such
> > PR. (feel free to communicate here as well if you prefer).
> >
> > --
> > Clebert Suconic
>
>
>
> --
> Clebert Suconic
Re: [HEADS-UP] Release on Oct 23rd
Posted by Clebert Suconic <cl...@gmail.com>.
I am obviously pushing back the release.. I will do as soon as I we
merge https://github.com/apache/activemq-artemis/pull/3294 (which will
include some tests before I merge it)
On Mon, Oct 19, 2020 at 10:47 AM Clebert Suconic
<cl...@gmail.com> wrote:
>
> I'm planning to finish my work on Server Connections
> (https://github.com/apache/activemq-artemis/pull/3294) on the next day
> or 2, and I would like to start cutting a release on Friday, with the
> Vote thread sent on monday.
>
> That means I will have everything ready to go for a vote on Friday,
> and the release vote to be sent on monday.
>
> for the github Pull Requests under review I will also make sure we
> merge current relevant PRs... so, if you could make sure you send your
> pending changes.. and could even nudge me with a comment on your
> github pull requet tagging my name that you would like to include such
> PR. (feel free to communicate here as well if you prefer).
>
> --
> Clebert Suconic
--
Clebert Suconic