[GitHub] [netbeans] mbien commented on a diff in pull request #5535: Fixed key escaping; fixed list/map property extraction.

["mbien (via GitHub)" <gi...@apache.org>]

mbien commented on code in PR #5535:
URL: https://github.com/apache/netbeans/pull/5535#discussion_r1127238830


##########
extide/gradle/src/org/netbeans/modules/gradle/loaders/ExtensionPropertiesExtractor.java:
##########
@@ -170,7 +171,7 @@ public Collection<String> keys(BuildPropertiesSupport.Property container) {
             if (c == null) {
                 return null;
             }
-            return Arrays.asList(c.split(";;")).stream().map(s -> s.replaceAll("\\;", ";")).collect(Collectors.toList());
+            return Arrays.asList(c.split(";;")).stream().map(s -> s.replaceAll("\\\\;", ";")).collect(Collectors.toList());

Review Comment:
   `s.replace(..)` wouldn't need the double escape I believe - its also cheaper since it doesn't do regex.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists