You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by GitBox <gi...@apache.org> on 2019/11/07 09:23:25 UTC
[GitHub] [cordova-eslint] raphinesse commented on a change in pull request
#3: chore: add .npmignore
raphinesse commented on a change in pull request #3: chore: add .npmignore
URL: https://github.com/apache/cordova-eslint/pull/3#discussion_r343547457
##########
File path: .npmignore
##########
@@ -0,0 +1 @@
+.asf.yaml
Review comment:
I think we should use
```suggestion
.*
```
instead, like in our other repos. That will also remove the `.eslintrc` from the bundle which is only the lint configuration for this repo, _not_ the config we export.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org