You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yikf (via GitHub)" <gi...@apache.org> on 2023/05/05 11:38:33 UTC
[GitHub] [spark] Yikf opened a new pull request, #41064: [SPARK-43383][SQL] Add statistics rowCount for LocalRelation
Yikf opened a new pull request, #41064:
URL: https://github.com/apache/spark/pull/41064
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR aims to add statistics rowCount for `LocalRelation`
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Previously, statistics in `LocalRelation` were missing rowCount.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
new UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rednaxelafx commented on a diff in pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "rednaxelafx (via GitHub)" <gi...@apache.org>.
rednaxelafx commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1190332445
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala:
##########
@@ -79,7 +79,8 @@ case class LocalRelation(
}
override def computeStats(): Statistics =
- Statistics(sizeInBytes = EstimationUtils.getSizePerRow(output) * data.length)
+ Statistics(sizeInBytes = EstimationUtils.getSizePerRow(output) * data.length,
+ rowCount = Some(data.size))
Review Comment:
Post-hoc comment: not a big deal but I just noticed that we have `data.length` and `data.size` used on adjacent lines and they mean the same thing. It would have been better if we use the same method for the same thing, at least on the same page of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rednaxelafx commented on a diff in pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "rednaxelafx (via GitHub)" <gi...@apache.org>.
rednaxelafx commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1190337492
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/joinReorder/JoinReorderSuite.scala:
##########
@@ -228,17 +228,16 @@ class JoinReorderSuite extends JoinReorderPlanTestBase with StatsEstimationTestB
}
test("SPARK-26352: join reordering should not change the order of attributes") {
Review Comment:
Thanks for the ping, the fact that the expected plan did change its join order is good enough for the intent of the test. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41064: [SPARK-43383][SQL] Add statistics rowCount for LocalRelation
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1186774386
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/joinReorder/JoinReorderSuite.scala:
##########
@@ -235,10 +235,10 @@ class JoinReorderSuite extends JoinReorderPlanTestBase with StatsEstimationTestB
val tab3 = LocalRelation($"a".int, $"b".int)
val original =
tab1.join(tab2, Cross)
- .join(tab3, Inner, Some($"a" === $"x" && $"b" === $"i"))
+ .join(tab3, Inner, Some($"a" === $"x"))
val expected =
tab1.join(tab3, Inner, Some($"a" === $"x"))
- .join(tab2, Cross, Some($"b" === $"i"))
Review Comment:
Why do we need to touch `JoinReorderSuite`? According to the test case comment, this doesn't rely on CBO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1186956202
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala:
##########
@@ -79,7 +79,8 @@ case class LocalRelation(
}
override def computeStats(): Statistics =
- Statistics(sizeInBytes = EstimationUtils.getSizePerRow(output) * data.length)
+ Statistics(sizeInBytes = EstimationUtils.getSizePerRow(output) * data.length,
+ rowCount = Some(EstimationUtils.ceil(BigDecimal(data.size))))
Review Comment:
Why can't we just use `data.length` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikf commented on a diff in pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1187360291
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/joinReorder/JoinReorderSuite.scala:
##########
@@ -235,10 +235,10 @@ class JoinReorderSuite extends JoinReorderPlanTestBase with StatsEstimationTestB
val tab3 = LocalRelation($"a".int, $"b".int)
val original =
tab1.join(tab2, Cross)
- .join(tab3, Inner, Some($"a" === $"x" && $"b" === $"i"))
+ .join(tab3, Inner, Some($"a" === $"x"))
val expected =
tab1.join(tab3, Inner, Some($"a" === $"x"))
- .join(tab2, Cross, Some($"b" === $"i"))
Review Comment:
Now, this test case is affected by CBO because of this PR. Since this PR adds rowCount statistics to LocalRelation, it will be affected by CBO according to [this code](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala#L64).
```scala
private def reorder(plan: LogicalPlan, output: Seq[Attribute]): LogicalPlan = {
val (items, conditions) = extractInnerJoins(plan)
val result =
// Do reordering if the number of items is appropriate and join conditions exist.
// We also need to check if costs of all items can be evaluated.
if (items.size > 2 && items.size <= conf.joinReorderDPThreshold && conditions.nonEmpty &&
items.forall(_.stats.rowCount.isDefined)) {
JoinReorderDP.search(conf, items, conditions, output)
} else {
plan
}
// Set consecutive join nodes ordered.
replaceWithOrderedJoin(result)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikf commented on a diff in pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1190566505
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/joinReorder/JoinReorderSuite.scala:
##########
@@ -228,17 +228,16 @@ class JoinReorderSuite extends JoinReorderPlanTestBase with StatsEstimationTestB
}
test("SPARK-26352: join reordering should not change the order of attributes") {
Review Comment:
Thank you for your confirmation, : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1187641964
##########
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala:
##########
@@ -37,7 +37,6 @@ import org.apache.spark.sql.test.SQLTestData.ArrayData
import org.apache.spark.sql.types._
import org.apache.spark.util.Utils
-
Review Comment:
Please revert this style change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikf commented on a diff in pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1188054313
##########
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala:
##########
@@ -37,7 +37,6 @@ import org.apache.spark.sql.test.SQLTestData.ArrayData
import org.apache.spark.sql.types._
import org.apache.spark.util.Utils
-
Review Comment:
Thanks for your point :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1187643200
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/joinReorder/JoinReorderSuite.scala:
##########
@@ -228,17 +228,16 @@ class JoinReorderSuite extends JoinReorderPlanTestBase with StatsEstimationTestB
}
test("SPARK-26352: join reordering should not change the order of attributes") {
Review Comment:
What happens in this test case's original test coverage? Is it preserved?
```
test("SPARK-26352: join reordering should not change the order of attributes") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikf commented on pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on PR #41064:
URL: https://github.com/apache/spark/pull/41064#issuecomment-1541193866
Thank you @dongjoon-hyun @HyukjinKwon ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikf commented on a diff in pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1188055701
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/joinReorder/JoinReorderSuite.scala:
##########
@@ -228,17 +228,16 @@ class JoinReorderSuite extends JoinReorderPlanTestBase with StatsEstimationTestB
}
test("SPARK-26352: join reordering should not change the order of attributes") {
Review Comment:
I don't think the test coverage has changed. The intent of this test case is that check the project attributes should not change after ReorderJoin. In fact, after this PR, it also achieved this goal. also cc @rednaxelafx since you file this test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1187643200
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/joinReorder/JoinReorderSuite.scala:
##########
@@ -228,17 +228,16 @@ class JoinReorderSuite extends JoinReorderPlanTestBase with StatsEstimationTestB
}
test("SPARK-26352: join reordering should not change the order of attributes") {
Review Comment:
What happens in this test case's original test coverage? Is it preserved after this PR?
```
test("SPARK-26352: join reordering should not change the order of attributes") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
URL: https://github.com/apache/spark/pull/41064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikf commented on a diff in pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1187376595
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala:
##########
@@ -79,7 +79,8 @@ case class LocalRelation(
}
override def computeStats(): Statistics =
- Statistics(sizeInBytes = EstimationUtils.getSizePerRow(output) * data.length)
+ Statistics(sizeInBytes = EstimationUtils.getSizePerRow(output) * data.length,
+ rowCount = Some(EstimationUtils.ceil(BigDecimal(data.size))))
Review Comment:
Thank you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1187641298
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/joinReorder/JoinReorderSuite.scala:
##########
@@ -235,10 +235,10 @@ class JoinReorderSuite extends JoinReorderPlanTestBase with StatsEstimationTestB
val tab3 = LocalRelation($"a".int, $"b".int)
val original =
tab1.join(tab2, Cross)
- .join(tab3, Inner, Some($"a" === $"x" && $"b" === $"i"))
+ .join(tab3, Inner, Some($"a" === $"x"))
val expected =
tab1.join(tab3, Inner, Some($"a" === $"x"))
- .join(tab2, Cross, Some($"b" === $"i"))
Review Comment:
Thanks for removing that comment via https://github.com/apache/spark/pull/41064/commits/d60a23c49044df773c87e6c9d69183174436afe1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikf commented on pull request #41064: [SPARK-43383][SQL] Add statistics rowCount for LocalRelation
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on PR #41064:
URL: https://github.com/apache/spark/pull/41064#issuecomment-1536143460
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikf commented on a diff in pull request #41064: [SPARK-43383][SQL] Add `rowCount` statistics to LocalRelation
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on code in PR #41064:
URL: https://github.com/apache/spark/pull/41064#discussion_r1190567006
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala:
##########
@@ -79,7 +79,8 @@ case class LocalRelation(
}
override def computeStats(): Statistics =
- Statistics(sizeInBytes = EstimationUtils.getSizePerRow(output) * data.length)
+ Statistics(sizeInBytes = EstimationUtils.getSizePerRow(output) * data.length,
+ rowCount = Some(data.size))
Review Comment:
Good point, thank you, will file a followup to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org