You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/07/28 13:06:30 UTC

[GitHub] flink pull request #4419: [hotfix][tests] fix IncrementalRocksDbBackendEvent...

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4419

    [hotfix][tests] fix IncrementalRocksDbBackendEventTimeWindowCheckpointingITCase taking too long for the TravisCI output check

    ## What is the purpose of the change
    
    Fix test failures due to `IncrementalRocksDbBackendEventTimeWindowCheckpointingITCase` not producing an output for 300s on Travis.
    
    ## Brief change log
    
      - provide output in the form of progress messages regarding the execution of test cases
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (JavaDocs)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink hotfix_rocksdb_tests_no_output

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4419.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4419
    
----
commit f3b0b669996515fab09f55ffd14330fa089d0d32
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-07-28T13:00:15Z

    [hotfix][tests] fix IncrementalRocksDbBackendEventTimeWindowCheckpointingITCase taking too long for the TravisCI output check
    
    Travis checks how long maven did not produce an output and we assume that a
    test hangs if no output is produces within 300s.
    IncrementalRocksDbBackendEventTimeWindowCheckpointingITCase executes several
    tests but output is only generated at the end of the whole suite which may,
    under certain circumstances, already take longer than 300s. Therefore, simply
    provide some output in the form of progress messages regarding the execution
    of test cases.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4419: [hotfix][tests] fix IncrementalRocksDbBackendEventTimeWin...

Posted by NicoK <gi...@git.apache.org>.

Github user NicoK commented on the issue:

    https://github.com/apache/flink/pull/4419
  
    sure, it does not hurt at least, although probably at the moment, only the two RocksDB tests may be affected (also the non-incremental one that I missed)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4419: [FLINK-7346][tests] fix IncrementalRocksDbBackendE...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4419


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4419: [FLINK-7346][tests] fix IncrementalRocksDbBackendEventTim...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4419
  
    merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4419: [hotfix][tests] fix IncrementalRocksDbBackendEventTimeWin...

Posted by StefanRRichter <gi...@git.apache.org>.

Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/4419
  
    @NicoK and I discussed this fix as preferable over reducing the amount of produced test data, because the test of RocksDB should actually put a decent amount of state into the backend.
    
    After the change that @zentol suggested, this looks got for me now. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---