You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "chengxilo (via GitHub)" <gi...@apache.org> on 2026/05/29 03:09:04 UTC

[I] Implement Golang SDK logger [iggy]

chengxilo opened a new issue, #3364:
URL: https://github.com/apache/iggy/issues/3364

   ### Description
   
   
   The Go SDK currently uses `log.Printf` for internal logging, which writes directly to stdout. This is problematic.
   
   Proposed solution (I am not a expert in logger so I believe you can come up with a better solution):
   - Define a minimal logger interface:
   ```go
   type Logger interface {
        Debug()
        Info()
        Error()
        Warning()
        ....
   }
   ```
   
   - Accept it as a client option: `WithLogger(logger Logger)`
   - Default to a no-op logger (silent by default), but we still need to have a default, implemented log system that user can use by simply modify the log level, for example, set the level to WARNING so we can see the warnings.
   - Replace all `log.Printf` calls with c.logger.Printf, mirror the logger with rust sdk.
   
   ### Component
   
   None
   
   ### Proposed solution
   
   _No response_
   
   ### Alternatives considered
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Implement Golang SDK logger [iggy]

Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio closed issue #3364: Implement Golang SDK logger
URL: https://github.com/apache/iggy/issues/3364


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Implement Golang SDK logger [iggy]

Posted by "slash-init (via GitHub)" <gi...@apache.org>.
slash-init commented on issue #3364:
URL: https://github.com/apache/iggy/issues/3364#issuecomment-4575480784

   I'd like to work on this issue. Could you assign it to me if it's still available?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Implement Golang SDK logger [iggy]

Posted by "chengxilo (via GitHub)" <gi...@apache.org>.
chengxilo commented on issue #3364:
URL: https://github.com/apache/iggy/issues/3364#issuecomment-4580982406

   @slash-init I don't have the privilege  to assign it to you but it's fine, just start implement it. @hubcio would  u mind to assign @slash-init if you saw this comment?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org