You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by br...@apache.org on 2011/03/23 19:05:28 UTC

svn commit: r1084656 - in /thrift/trunk/lib/cpp/src/async: TAsyncBufferProcessor.h TAsyncProtocolProcessor.h

Author: bryanduxbury
Date: Wed Mar 23 18:05:27 2011
New Revision: 1084656

URL: http://svn.apache.org/viewvc?rev=1084656&view=rev
Log:
THRIFT-1106. cpp: C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall

Patch: Fasih

Modified:
    thrift/trunk/lib/cpp/src/async/TAsyncBufferProcessor.h
    thrift/trunk/lib/cpp/src/async/TAsyncProtocolProcessor.h

Modified: thrift/trunk/lib/cpp/src/async/TAsyncBufferProcessor.h
URL: http://svn.apache.org/viewvc/thrift/trunk/lib/cpp/src/async/TAsyncBufferProcessor.h?rev=1084656&r1=1084655&r2=1084656&view=diff
==============================================================================
--- thrift/trunk/lib/cpp/src/async/TAsyncBufferProcessor.h (original)
+++ thrift/trunk/lib/cpp/src/async/TAsyncBufferProcessor.h Wed Mar 23 18:05:27 2011
@@ -38,6 +38,7 @@ class TAsyncBufferProcessor {
       std::tr1::function<void(bool healthy)> _return,
       boost::shared_ptr<apache::thrift::transport::TBufferBase> ibuf,
       boost::shared_ptr<apache::thrift::transport::TBufferBase> obuf) = 0;
+  virtual ~TAsyncBufferProcessor() {}
 };
 
 }}} // apache::thrift::async

Modified: thrift/trunk/lib/cpp/src/async/TAsyncProtocolProcessor.h
URL: http://svn.apache.org/viewvc/thrift/trunk/lib/cpp/src/async/TAsyncProtocolProcessor.h?rev=1084656&r1=1084655&r2=1084656&view=diff
==============================================================================
--- thrift/trunk/lib/cpp/src/async/TAsyncProtocolProcessor.h (original)
+++ thrift/trunk/lib/cpp/src/async/TAsyncProtocolProcessor.h Wed Mar 23 18:05:27 2011
@@ -40,6 +40,8 @@ class TAsyncProtocolProcessor : public T
       boost::shared_ptr<apache::thrift::transport::TBufferBase> ibuf,
       boost::shared_ptr<apache::thrift::transport::TBufferBase> obuf);
 
+  virtual ~TAsyncProtocolProcessor() {}
+
  private:
   static void finish(
       std::tr1::function<void(bool healthy)> _return,