You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "f1amingo (via GitHub)" <gi...@apache.org> on 2026/07/01 03:00:44 UTC
[PR] [Go] Fix LitePushConsumer.WrapReceiveMessageRequest using wrong AutoRenew value [rocketmq-clients]
f1amingo opened a new pull request, #1291:
URL: https://github.com/apache/rocketmq-clients/pull/1291
### Summary
`defaultLitePushConsumer.WrapReceiveMessageRequest` was a copy-paste override
that incorrectly set `AutoRenew: false` and omitted `FilterExpression`.
This PR removes the redundant override so that `defaultLitePushConsumer`
delegates to the embedded `*defaultPushConsumer` implementation, which
correctly sets `AutoRenew: true` and includes `FilterExpression`.
### Changes
- Remove `WrapReceiveMessageRequest` from `defaultLitePushConsumer`
- Drop unused imports: `uuid`, `durationpb`
- Fix test assertion: `AutoRenew` should be `true` for lite push consumer
### How Did You Test This Change?
Unit test updated and passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Go] Fix LitePushConsumer.WrapReceiveMessageRequest using wrong AutoRenew value [rocketmq-clients]
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #1291:
URL: https://github.com/apache/rocketmq-clients/pull/1291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org