You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "mystic-lama (via GitHub)" <gi...@apache.org> on 2023/08/09 14:51:53 UTC

[GitHub] [orc] mystic-lama commented on a diff in pull request #1575: ORC-1474: replaced deprecated methods in TestColumnStatistics

mystic-lama commented on code in PR #1575:
URL: https://github.com/apache/orc/pull/1575#discussion_r1288648471


##########
java/core/src/test/org/apache/orc/TestColumnStatistics.java:
##########
@@ -28,6 +27,7 @@
 import org.apache.hadoop.hive.serde2.io.DateWritable;
 import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
 import org.apache.hadoop.io.Text;
+import org.apache.hadoop.shaded.org.apache.commons.text.StringEscapeUtils;

Review Comment:
   @wgtmac StringEscapeUtils is deprecated. I am split on this change, hence left a note in the PR description above, as commons-text is not available as direct dependency in ORC, and not inclined to add it just for one class.
   Open to suggestions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org