You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2016/12/14 20:13:44 UTC

[Toolchain-CR] IMPALA-4651: Add libev 4.20 to toolchain

Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5504

Change subject: IMPALA-4651: Add libev 4.20 to toolchain
......................................................................

IMPALA-4651: Add libev 4.20 to toolchain

Change-Id: I4c179741253d009984e2715ab2f2f9a5c47288ec
---
M buildall.sh
A source/libev/build.sh
2 files changed, 40 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/04/5504/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c179741253d009984e2715ab2f2f9a5c47288ec
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>

[Toolchain-CR] IMPALA-4651: Add libev 4.20 to toolchain

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has submitted this change and it was merged.

Change subject: IMPALA-4651: Add libev 4.20 to toolchain
......................................................................


IMPALA-4651: Add libev 4.20 to toolchain

Change-Id: I4c179741253d009984e2715ab2f2f9a5c47288ec
---
M buildall.sh
A source/libev/build.sh
2 files changed, 40 insertions(+), 0 deletions(-)

Approvals:
  Henry Robinson: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4c179741253d009984e2715ab2f2f9a5c47288ec
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Toolchain-CR] IMPALA-4651: Add libev 4.20 to toolchain

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4651: Add libev 4.20 to toolchain
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c179741253d009984e2715ab2f2f9a5c47288ec
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Toolchain-CR] IMPALA-4651: Add libev 4.20 to toolchain

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4651: Add libev 4.20 to toolchain
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5504/1/source/libev/build.sh
File source/libev/build.sh:

Line 30: if needs_build_package ; then
> It's nice these are turning out to be easy to build.
Yeah - I'm taking advantage of a lot of the work done by the Kudu community who already have the compilation work sorted out.


-- 
To view, visit http://gerrit.cloudera.org:8080/5504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c179741253d009984e2715ab2f2f9a5c47288ec
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Toolchain-CR] IMPALA-4651: Add libev 4.20 to toolchain

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4651: Add libev 4.20 to toolchain
......................................................................


Patch Set 1:

This already passed a toolchain build. The SLES build got wedged building LLVM, but I restarted it and it completed successfully, so my guess is an environmental issue.

-- 
To view, visit http://gerrit.cloudera.org:8080/5504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c179741253d009984e2715ab2f2f9a5c47288ec
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No

[Toolchain-CR] IMPALA-4651: Add libev 4.20 to toolchain

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4651: Add libev 4.20 to toolchain
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5504/1/source/libev/build.sh
File source/libev/build.sh:

Line 30: if needs_build_package ; then
It's nice these are turning out to be easy to build.


-- 
To view, visit http://gerrit.cloudera.org:8080/5504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c179741253d009984e2715ab2f2f9a5c47288ec
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes