You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bb...@apache.org on 2018/01/05 15:08:56 UTC
mesos git commit: Changed 'ConstantEndpointDetector' to have value
semantics.
Repository: mesos
Updated Branches:
refs/heads/master 82a631911 -> 625189058
Changed 'ConstantEndpointDetector' to have value semantics.
The class 'ConstantEndpointDetector' was holding a reference to one of
its constructor parameters which introduces unnecessary brittleness.
In this patch we adjust the class to just hold a copy of the
originally passed value instead.
Review: https://reviews.apache.org/r/64805/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/62518905
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/62518905
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/62518905
Branch: refs/heads/master
Commit: 62518905824558f2569f11e2cd0e0c40775138de
Parents: 82a6319
Author: Benjamin Bannier <be...@mesosphere.io>
Authored: Fri Jan 5 15:22:49 2018 +0100
Committer: Benjamin Bannier <bb...@apache.org>
Committed: Fri Jan 5 15:22:49 2018 +0100
----------------------------------------------------------------------
src/resource_provider/detector.hpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/62518905/src/resource_provider/detector.hpp
----------------------------------------------------------------------
diff --git a/src/resource_provider/detector.hpp b/src/resource_provider/detector.hpp
index 68ea8cf..a4c094c 100644
--- a/src/resource_provider/detector.hpp
+++ b/src/resource_provider/detector.hpp
@@ -42,7 +42,7 @@ public:
const Option<process::http::URL>& previous) override;
private:
- const process::http::URL& url;
+ process::http::URL url;
};
} // namespace internal {