You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/04 08:56:44 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #320: Explore Test Automation
utchoang opened a new pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
Open for #299
cc @svenvogel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-632594115
@rhtyd cc @svenvogel I've completed explore test automation. Please review and let me know your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-639263516
Still failing, let's revisit this later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-630077683
* Views > AutogenView.vue - processing 43%
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-668473881
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-633861730
* Views > compute > MigrateWizard.vue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-756724623
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-634410881
Thanks @utchoang I'll review and merge over due course.
@DaanHoogland - you want to review this? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-638009786
@DaanHoogland any concerns on this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-759849880
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-668484065
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/320 (JID-2863)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-649497423
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/320 (JID-2131)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-756724623
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-759852912
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/320 (JID-3806)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-759849699
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-639282834
@rhtyd I get the following error but I don't understand where the problem is? Do you have any ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-623918168
If possible could you also explore a way to add some unit test for other components/widgets (an example for a small form, or tab component) and the autogenview component. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-671843420
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/320 (JID-3054)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-623917840
@utchoang thanks, can you also check if Travis runs these test? Maybe add test/run command in the .travis.yml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-671836143
Thanks @utchoang I'll merge this soon after the last few open PRs towards 1.0/GA milestone
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-638125373
To be extra clear, I have no objections with this PR. code looks good as far as I can judge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-763244143
Manually tested build passes ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-629106952
* Views > AutogenView.vue - processing 31%
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-638048003
@DaanHoogland The purpose currently is limited to introduce some unit testing early in the project and add few example test (esp. for core components to act as a quick smoketest that run with Travis for each PR).
- we've eslint to do several of the conventions related checks
- the way we write a component is pretty standard (we use a single-file-component, where within the component we've html, css and js code)
- the link is on the readme for the overall VueJS guide, https://vuejs.org/v2/guide/unit-testing.html (I'll add links and maybe a wiki page with some docs later)
- at the moment we don't want developers breaking some core components, so for starters this is largely to guard those components (esp the AutogenView); we'll identify and explore other critical components and write tests for that but the project will still require some manual QA
@utchoang can you add a markdown file under `docs` say `docs/test.md` to document how to write a unit test for a component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd edited a comment on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-633016957
Tests should run slightly faster now, 3x faster in my env: (from over 90s)
```
PASS tests/unit/components/widgets/Status.spec.js
PASS tests/unit/components/view/ActionButton.spec.js
PASS tests/unit/views/AutogenView.spec.js (14.795s)
=============================== Coverage summary ===============================
Statements : 5.22% ( 570/10914 )
Branches : 6.91% ( 346/5005 )
Functions : 2.36% ( 86/3639 )
Lines : 5.22% ( 566/10849 )
================================================================================
Test Suites: 3 passed, 3 total
Tests: 104 passed, 104 total
Snapshots: 0 total
Time: 28.74s
Ran all test suites.
```
@utchoang can you make the following changes:
- in the `it()` and any `describe()` please use a full human-readable sentence to say what your test is doing (instead of short strings are `testCase...`)
- Can you add more one example unit test for a form or tab component in `src/views/` path, for example src/views/compute/MigrateWizard.vue (I picked smallest by file size)
- Exclude from coverage: locales
Thanks for the effort, this looks good overall.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-631352212
* Views > AutogenView.vue - processing 91%
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-763238986
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-623919476
@rhtyd OK, got it I'm still in progress after completing https://github.com/apache/cloudstack-primate/pull/324 first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-646966973
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/320 (JID-2061)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-631355555
@rhtyd cc @svenvogel OK, I got it. I think some further adjustments are needed to complete it.
I will notify after completion. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-638675673
Closing/opening PR to rekick Travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-639291901
@rhtyd Completed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-677612050
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/320 (JID-3289)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-763255179
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/320 (JID-3817)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-649493287
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-671836645
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-677598964
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-756729019
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/320 (JID-3797)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-668474623
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-649492555
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-631353360
Let me know if you're going further or when this PR reaches a state to be merged? cc @svenvogel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-756724950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-756724950
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-638045055
code itself looks rather good @utchoang @rhtyd . It is not clear from the outside that this is meant to be extended. It is, is it? I'm would like to see some entry point that helps contributing, except for internal developer drive.
- Is there a Howto write your first component test?
- do we have conventions specific to the project?
- is there a link that will help understand the underlying test framework?
and as future policy to all that
- will we start requiring developers to extend/contribute?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-629347190
Good progress @utchoang keep it up!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-646966203
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-630649462
* Views > AutogenView.vue - processing 65%
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-763239329
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-677600702
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-631352904
Great work @utchoang I think some coverage (80+%) is a good start!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-633016957
Tests should run slightly faster now, 3x faster in my env: (from over 90s)
```
PASS tests/unit/components/widgets/Status.spec.js
PASS tests/unit/components/view/ActionButton.spec.js
PASS tests/unit/views/AutogenView.spec.js (14.795s)
=============================== Coverage summary ===============================
Statements : 5.22% ( 570/10914 )
Branches : 6.91% ( 346/5005 )
Functions : 2.36% ( 86/3639 )
Lines : 5.22% ( 566/10849 )
================================================================================
Test Suites: 3 passed, 3 total
Tests: 104 passed, 104 total
Snapshots: 0 total
Time: 28.74s
Ran all test suites.
```
@utchoang can you make the following changes:
- in the `it()` and any `describe()` please use a full human-readable sentence to say what your test is doing (instead of short strings are `testCase...`)
- Can you add more one example unit test for a form or tab component in `src/views/` path, for example src/views/compute/MigrateWizard.vue (I picked smallest by file size)
Thanks for the effort, this looks good overall.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #320:
URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-646966075
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org