You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Stepan Mishura <st...@gmail.com> on 2006/08/14 13:35:33 UTC

Re: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Hi Nathan,

I saw that you've changed tests layout (consolidated) tests in luni module.
But I don't understand what the purpose for the change. Is this a first step
for migrating to TestNG? (May be I missed something important - sorry for
stupid question then.)

BTW did we agree on that we won't follow directory-based tests layout [1]?
IMHO, not yet. IIRC we agreed that directory-based tests layout is not quite
convenient for our needs and we'll try TestNG. But for me it doesn't mean
that we'll migrate to TestNG for sure. Also I assume that mixed approach
(directory-based layout + annotations) is possible. So it is not time for
doing massive tests moves and merges.

And the minor comment to the commit log. It says: "remove unused folders".
But there are a lot of other unrelated changes. Was it possible to make
separate commits?

Thanks,
Stepan.

[1]
http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.html

-----Original Message-----
From: ndbeyer@apache.org [mailto:ndbeyer@apache.org]
Sent: Monday, August 14, 2006 2:56 AM
To: harmony-commits@incubator.apache.org
Subject: svn commit: r431219 - in
/incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/
java/org/apache/harmony/luni/tests/java/lang/

Author: ndbeyer
Date: Sun Aug 13 12:55:54 2006
New Revision: 431219

URL: http://svn.apache.org/viewvc?rev=431219&view=rev
Log:
remove unused folders

Removed:
    incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/
    incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/
Modified:

incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java

incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java

incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/ThreadGroupTest.java

Modified:
incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
URL:
http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java?rev=431219&r1=431218&r2=431219&view=diff
==============================================================================


---
incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
(original)
+++
incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
Sun Aug 13 12:55:54 2006
@@ -441,7 +441,7 @@
      */
     public void test_parseDoubleLjava_lang_String() {
         assertEquals("Incorrect double returned, expected zero.", 0.0,
Double
-                .parseDouble("2.4703282292062327208828439643411e-324"));
+                .parseDouble("2.4703282292062327208828439643411e-324"), 0.0
);
         assertTrue("Incorrect double returned, expected minimum double.",
Double
                 .parseDouble("2.4703282292062327208828439643412e-324") ==
Double.MIN_VALUE);


Modified:
incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java
<SNIP>


------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Re: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Alexei Zakharov <al...@gmail.com>.
FYI these topics are currently being discussed here [1]

[1] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200608.mbox/%3c2c9597b90608140453oe4c9231sa7b28ffd5c3982c0@mail.gmail.com%3e

With Best Regards,

2006/8/14, Alexei Zakharov <al...@gmail.com>:
> Our current builds does not allow to run TestNG 5.0 yet. And AFAIK we
> have not finished the discussion about directory based approach vs
> metadata based approach.
>
> With Best Regards,
>
> 2006/8/14, Geir Magnusson Jr <ge...@pobox.com>:
> > I haven't been following the test discussion too closely, but please
> > don't make it so that only tooling can tell us what is what...
> >
> > geir
> >
> >
> > Stepan Mishura wrote:
> > > Hi Nathan,
> > >
> > > I saw that you've changed tests layout (consolidated) tests in luni module.
> > > But I don't understand what the purpose for the change. Is this a first
> > > step
> > > for migrating to TestNG? (May be I missed something important - sorry for
> > > stupid question then.)
> > >
> > > BTW did we agree on that we won't follow directory-based tests layout [1]?
> > > IMHO, not yet. IIRC we agreed that directory-based tests layout is not
> > > quite
> > > convenient for our needs and we'll try TestNG. But for me it doesn't mean
> > > that we'll migrate to TestNG for sure. Also I assume that mixed approach
> > > (directory-based layout + annotations) is possible. So it is not time for
> > > doing massive tests moves and merges.
> > >
> > > And the minor comment to the commit log. It says: "remove unused folders".
> > > But there are a lot of other unrelated changes. Was it possible to make
> > > separate commits?
> > >
> > > Thanks,
> > > Stepan.
> > >
> > > [1]
> > > http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.html
> > >
> > > -----Original Message-----
> > > From: ndbeyer@apache.org [mailto:ndbeyer@apache.org]
> > > Sent: Monday, August 14, 2006 2:56 AM
> > > To: harmony-commits@incubator.apache.org
> > > Subject: svn commit: r431219 - in
> > > /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> > > impl/
> > > java/org/apache/harmony/luni/tests/java/lang/
> > >
> > > Author: ndbeyer
> > > Date: Sun Aug 13 12:55:54 2006
> > > New Revision: 431219
> > >
> > > URL: http://svn.apache.org/viewvc?rev=431219&view=rev
> > > Log:
> > > remove unused folders
> > >
> > > Removed:
> > >    incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/
> > >    incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/
> > > Modified:
> > >
> > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
> > >
> > >
> > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> > >
> > >
> > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/ThreadGroupTest.java
> > >
> > >
> > > Modified:
> > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
> > >
> > > URL:
> > > http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java?rev=431219&r1=431218&r2=431219&view=diff
> > >
> > > ==============================================================================
> > >
> > >
> > >
> > > ---
> > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
> > >
> > > (original)
> > > +++
> > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
> > >
> > > Sun Aug 13 12:55:54 2006
> > > @@ -441,7 +441,7 @@
> > >      */
> > >     public void test_parseDoubleLjava_lang_String() {
> > >         assertEquals("Incorrect double returned, expected zero.", 0.0,
> > > Double
> > > -                .parseDouble("2.4703282292062327208828439643411e-324"));
> > > +                .parseDouble("2.4703282292062327208828439643411e-324"),
> > > 0.0
> > > );
> > >         assertTrue("Incorrect double returned, expected minimum double.",
> > > Double
> > >                 .parseDouble("2.4703282292062327208828439643412e-324") ==
> > > Double.MIN_VALUE);
> > >
> > >
> > > Modified:
> > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> > >
> > > <SNIP>
> > >
> > >
> > > ------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Alexei Zakharov,
> Intel Middleware Product Division
>


-- 
Alexei Zakharov,
Intel Middleware Product Division

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Re: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Alexei Zakharov <al...@gmail.com>.
Our current builds does not allow to run TestNG 5.0 yet. And AFAIK we
have not finished the discussion about directory based approach vs
metadata based approach.

With Best Regards,

2006/8/14, Geir Magnusson Jr <ge...@pobox.com>:
> I haven't been following the test discussion too closely, but please
> don't make it so that only tooling can tell us what is what...
>
> geir
>
>
> Stepan Mishura wrote:
> > Hi Nathan,
> >
> > I saw that you've changed tests layout (consolidated) tests in luni module.
> > But I don't understand what the purpose for the change. Is this a first
> > step
> > for migrating to TestNG? (May be I missed something important - sorry for
> > stupid question then.)
> >
> > BTW did we agree on that we won't follow directory-based tests layout [1]?
> > IMHO, not yet. IIRC we agreed that directory-based tests layout is not
> > quite
> > convenient for our needs and we'll try TestNG. But for me it doesn't mean
> > that we'll migrate to TestNG for sure. Also I assume that mixed approach
> > (directory-based layout + annotations) is possible. So it is not time for
> > doing massive tests moves and merges.
> >
> > And the minor comment to the commit log. It says: "remove unused folders".
> > But there are a lot of other unrelated changes. Was it possible to make
> > separate commits?
> >
> > Thanks,
> > Stepan.
> >
> > [1]
> > http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.html
> >
> > -----Original Message-----
> > From: ndbeyer@apache.org [mailto:ndbeyer@apache.org]
> > Sent: Monday, August 14, 2006 2:56 AM
> > To: harmony-commits@incubator.apache.org
> > Subject: svn commit: r431219 - in
> > /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> > impl/
> > java/org/apache/harmony/luni/tests/java/lang/
> >
> > Author: ndbeyer
> > Date: Sun Aug 13 12:55:54 2006
> > New Revision: 431219
> >
> > URL: http://svn.apache.org/viewvc?rev=431219&view=rev
> > Log:
> > remove unused folders
> >
> > Removed:
> >    incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/
> >    incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/
> > Modified:
> >
> > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
> >
> >
> > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> >
> >
> > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/ThreadGroupTest.java
> >
> >
> > Modified:
> > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
> >
> > URL:
> > http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java?rev=431219&r1=431218&r2=431219&view=diff
> >
> > ==============================================================================
> >
> >
> >
> > ---
> > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
> >
> > (original)
> > +++
> > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
> >
> > Sun Aug 13 12:55:54 2006
> > @@ -441,7 +441,7 @@
> >      */
> >     public void test_parseDoubleLjava_lang_String() {
> >         assertEquals("Incorrect double returned, expected zero.", 0.0,
> > Double
> > -                .parseDouble("2.4703282292062327208828439643411e-324"));
> > +                .parseDouble("2.4703282292062327208828439643411e-324"),
> > 0.0
> > );
> >         assertTrue("Incorrect double returned, expected minimum double.",
> > Double
> >                 .parseDouble("2.4703282292062327208828439643412e-324") ==
> > Double.MIN_VALUE);
> >
> >
> > Modified:
> > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> >
> > <SNIP>
> >
> >
> > ------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Alexei Zakharov,
Intel Middleware Product Division

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Re: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Geir Magnusson Jr <ge...@pobox.com>.
I haven't been following the test discussion too closely, but please
don't make it so that only tooling can tell us what is what...

geir


Stepan Mishura wrote:
> Hi Nathan,
> 
> I saw that you've changed tests layout (consolidated) tests in luni module.
> But I don't understand what the purpose for the change. Is this a first
> step
> for migrating to TestNG? (May be I missed something important - sorry for
> stupid question then.)
> 
> BTW did we agree on that we won't follow directory-based tests layout [1]?
> IMHO, not yet. IIRC we agreed that directory-based tests layout is not
> quite
> convenient for our needs and we'll try TestNG. But for me it doesn't mean
> that we'll migrate to TestNG for sure. Also I assume that mixed approach
> (directory-based layout + annotations) is possible. So it is not time for
> doing massive tests moves and merges.
> 
> And the minor comment to the commit log. It says: "remove unused folders".
> But there are a lot of other unrelated changes. Was it possible to make
> separate commits?
> 
> Thanks,
> Stepan.
> 
> [1]
> http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.html
> 
> -----Original Message-----
> From: ndbeyer@apache.org [mailto:ndbeyer@apache.org]
> Sent: Monday, August 14, 2006 2:56 AM
> To: harmony-commits@incubator.apache.org
> Subject: svn commit: r431219 - in
> /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> impl/
> java/org/apache/harmony/luni/tests/java/lang/
> 
> Author: ndbeyer
> Date: Sun Aug 13 12:55:54 2006
> New Revision: 431219
> 
> URL: http://svn.apache.org/viewvc?rev=431219&view=rev
> Log:
> remove unused folders
> 
> Removed:
>    incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/
>    incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/
> Modified:
> 
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
> 
> 
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> 
> 
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/ThreadGroupTest.java
> 
> 
> Modified:
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
> 
> URL:
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java?rev=431219&r1=431218&r2=431219&view=diff
> 
> ==============================================================================
> 
> 
> 
> ---
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
> 
> (original)
> +++
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
> 
> Sun Aug 13 12:55:54 2006
> @@ -441,7 +441,7 @@
>      */
>     public void test_parseDoubleLjava_lang_String() {
>         assertEquals("Incorrect double returned, expected zero.", 0.0,
> Double
> -                .parseDouble("2.4703282292062327208828439643411e-324"));
> +                .parseDouble("2.4703282292062327208828439643411e-324"),
> 0.0
> );
>         assertTrue("Incorrect double returned, expected minimum double.",
> Double
>                 .parseDouble("2.4703282292062327208828439643412e-324") ==
> Double.MIN_VALUE);
> 
> 
> Modified:
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> 
> <SNIP>
> 
> 
> ------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

RE: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Nathan Beyer <nb...@kc.rr.com>.
> -----Original Message-----
> From: Stepan Mishura [mailto:stepan.mishura@gmail.com]
> Sent: Monday, August 14, 2006 11:02 PM
> To: harmony-dev@incubator.apache.org
> Subject: Re: svn commit: r431219 - in
> /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> impl/ java/org/apache/harmony/luni/tests/java/lang/
> 
> On 8/15/06, Nathan Beyer wrote:
> 
> > <SNIP>
> > Right now and since the LUNI module has existed, there hasn't been any
> > difference between API tests, impl tests or any other tests. The only
> > separation there is now are tests that run and pass on classlib+j9 and
> > those
> > that are excluded. Even the tests that are in the "tests.api" package
> > don't
> > run on the RI -- it's about 50/50 right now. Note: there is ONE known
> > implementation specific test, which I created and that's
> > "org.apache.harmony.luni.tests.java.lang.CharacterImplTest".
> >
> > If you look back in the version history, all of the tests were under
> > "src/test/java" at one point. I rearranged the folder to try out the
> > proposal, which is where the 'api' and 'impl' folders came from. I also
> > modified the build.xml to setup the multiple tests runs and everything
> > that
> > was in 'src/test/java' and 'src/test/java/impl' was run considered a
> > Harmony
> > implementation test.
> >
> > I was waiting for a conclusion to come to the testing layout, but
> nothing
> > has happened so far and I wanted to move ahead with cleaning up the mess
> > that is currently the test case. As such, I decided to move forward with
> > some of the testing proposal (the package naming convention) and just
> keep
> > the folder layout simple by having just one folder. This greatly
> > simplified
> > the code layout as well as the build script.
> 
> 
> Sorry again, but I was a little bit confused. Because the reason for this
> radical (for me of course) change was not clear for me. So you completely
> disappointed with directory-based approach, right?
> 
> 
> 
> > When an actual test scheme is finalized, we can move the tests to
> whatever
> > folder is appropriate. SVN handles file and folder moves extremely well
> > and
> > tracks every change with ease.
> >
> > Right now, what I'm trying to do is:
> > * Consolidate all LUNI tests into "org.apache.harmony.luni.tests.**".
> 
> 
> Agree.
> 
> 
> 
> > * Get as many LUNI tests as possible to run on an RI JRE. Those that are
> > specific implementation tests will be segregated. I'd say we'd be lucky
> if
> > 50% of the tests that are API tests actually pass on an RI JRE.
> 
> 
> Not clear how you are going to distinguish implementation specific and
> independent tests. By name?
> 
> BWT, I was thinking about separating them by package. For example,
> 'o.a.h.luni.tests.api' - implementation independent tests
>  'o.a.h.luni.tests.impl' - harmony specific tests
> 
> Then there will be no need in 'ImplTest' ending.

The only test I've actually separated uses the "ImplTest" postfix, but I'm
not tied to that. I would prefer using package naming conventions over
multiple root folders.

-Nathan
> 
> Thanks,
> Stepan.
> 
> 
> 
> 
> > >
> > > >
> > > > > BTW did we agree on that we won't follow directory-based tests
> > layout
> > > > [1]?
> > > > > IMHO, not yet. IIRC we agreed that directory-based tests layout is
> > not
> > > > > quite
> > > > > convenient for our needs and we'll try TestNG. But for me it
> doesn't
> > > > mean
> > > > > that we'll migrate to TestNG for sure. Also I assume that mixed
> > > approach
> > > > > (directory-based layout + annotations) is possible. So it is not
> > time
> > > > for
> > > > > doing massive tests moves and merges.
> > > >
> > > > I've been watching the test layout/approach threads, but I haven't
> > seen
> > > > anything substantial fall out. I'm still waiting to see a simple and
> > > clear
> > > > suggestion. In any case, the current state is, frankly, a bit of a
> > mess
> > > > and
> > > > any cleanup can't hurt.
> > >
> > >
> > > Yes, I agree that clean up is required. But I'm not sure about
> changing
> > > tests layout. IMHO we should wait for results of tests layout/approach
> > > threads (Or it is possible to follow test layout proposal[1] - at
> least
> > > I'd
> > > follow section "Package and class names for different types of the
> > > tests".)
> >
> > As I mentioned above, I am following the package and class naming
> > conventions. In fact a majority of the changes have been to consolidate
> > the
> > duplicate tests into single tests under these naming conventions.
> >
> > >
> > > Additionally, I was trying the separated directory layout to see what
> > it's
> > > > like and I can tell you first hand it's just not that great. It just
> > > adds
> > > > complexity in the repository and the build script. This may be
> needed
> > > for
> > > > some modules, but I don't see it as the norm. Also, I've been
> > > > experimenting
> > > > with just using plain-old JUnit TestSuites to separate pure-API
> tests
> > > from
> > > > implementation tests and it works very well. It works equally well
> for
> > > > creating a failing-tests test suite. It also seems to make the tests
> > run
> > > > much faster, but I'm not sure why; maybe it's because Ant doesn't
> > search
> > > > for
> > > > all tests, it just runs the single test that's an aggregate.
> > > >
> > > > >
> > > > > And the minor comment to the commit log. It says: "remove unused
> > > > folders".
> > > > > But there are a lot of other unrelated changes. Was it possible to
> > > make
> > > > > separate commits?
> > > >
> > > > This was a mistake. I accidentally committed extra files with that
> > > > revision.
> > >
> > >
> > > OK, no problem.
> > >
> > > Thanks,
> > > Stepan.
> > >
> > > [1]
> > >
> >
> http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.htm
> > > l
> > >
> > > >
> > > > -----Original Message-----
> > > > From: ndbeyer@apache.org [mailto:ndbeyer@apache.org]
> > > > Sent: Monday, August 14, 2006 2:56 AM
> > > > To: harmony-commits@incubator.apache.org
> > > > Subject: svn commit: r431219 - in
> > > > /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test:
> api/
> > > > impl/
> > > > java/org/apache/harmony/luni/tests/java/lang/
> > > >
> > > > Author: ndbeyer
> > > > Date: Sun Aug 13 12:55:54 2006
> > > > New Revision: 431219
> > > >
> > > > URL: http://svn.apache.org/viewvc?rev=431219&view=rev
> > > > Log:
> > > > remove unused folders
> > > >
> > > > Removed:
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/
> > > >
> > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/
> > > > Modified:
> > > >
> > > >
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > > pache/harmony/luni/tests/java/lang/DoubleTest.java
> > > >
> > > >
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > > pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> > > >
> > > >
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > > pache/harmony/luni/tests/java/lang/ThreadGroupTest.java
> > > >
> > > > Modified:
> > > >
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > > pache/harmony/luni/tests/java/lang/DoubleTest.java
> > > > URL:
> > > >
> > >
> >
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/mod
> > > >
> > >
> >
> ules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest
> > > > .java?rev=431219&r1=431218&r2=431219&view=diff
> > > >
> > >
> >
> ==========================================================================
> > > > ====
> > > >
> > > >
> > > > ---
> > > >
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > > pache/harmony/luni/tests/java/lang/DoubleTest.java
> > > > (original)
> > > > +++
> > > >
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > > pache/harmony/luni/tests/java/lang/DoubleTest.java
> > > > Sun Aug 13 12:55:54 2006
> > > > @@ -441,7 +441,7 @@
> > > >       */
> > > >      public void test_parseDoubleLjava_lang_String() {
> > > >          assertEquals("Incorrect double returned, expected zero.",
> 0.0
> > ,
> > > > Double
> > > > -                .parseDouble("2.4703282292062327208828439643411e-
> > > 324"));
> > > > +                .parseDouble("2.4703282292062327208828439643411e-
> 324
> > "),
> > > > 0.0
> > > > );
> > > >          assertTrue("Incorrect double returned, expected minimum
> > > double.",
> > > > Double
> > > >                  .parseDouble("2.4703282292062327208828439643412e-
> 324
> > ")
> > > ==
> > > > Double.MIN_VALUE);
> > > >
> > > >
> > > > Modified:
> > > >
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > > pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> > > > <SNIP>
> >
> >
> 
> --
> Thanks,
> Stepan Mishura
> Intel Middleware Products Division
> 
> ------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Re: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Stepan Mishura <st...@gmail.com>.
On 8/15/06, Nathan Beyer wrote:

> <SNIP>
> Right now and since the LUNI module has existed, there hasn't been any
> difference between API tests, impl tests or any other tests. The only
> separation there is now are tests that run and pass on classlib+j9 and
> those
> that are excluded. Even the tests that are in the "tests.api" package
> don't
> run on the RI -- it's about 50/50 right now. Note: there is ONE known
> implementation specific test, which I created and that's
> "org.apache.harmony.luni.tests.java.lang.CharacterImplTest".
>
> If you look back in the version history, all of the tests were under
> "src/test/java" at one point. I rearranged the folder to try out the
> proposal, which is where the 'api' and 'impl' folders came from. I also
> modified the build.xml to setup the multiple tests runs and everything
> that
> was in 'src/test/java' and 'src/test/java/impl' was run considered a
> Harmony
> implementation test.
>
> I was waiting for a conclusion to come to the testing layout, but nothing
> has happened so far and I wanted to move ahead with cleaning up the mess
> that is currently the test case. As such, I decided to move forward with
> some of the testing proposal (the package naming convention) and just keep
> the folder layout simple by having just one folder. This greatly
> simplified
> the code layout as well as the build script.


Sorry again, but I was a little bit confused. Because the reason for this
radical (for me of course) change was not clear for me. So you completely
disappointed with directory-based approach, right?



> When an actual test scheme is finalized, we can move the tests to whatever
> folder is appropriate. SVN handles file and folder moves extremely well
> and
> tracks every change with ease.
>
> Right now, what I'm trying to do is:
> * Consolidate all LUNI tests into "org.apache.harmony.luni.tests.**".


Agree.



> * Get as many LUNI tests as possible to run on an RI JRE. Those that are
> specific implementation tests will be segregated. I'd say we'd be lucky if
> 50% of the tests that are API tests actually pass on an RI JRE.


Not clear how you are going to distinguish implementation specific and
independent tests. By name?

BWT, I was thinking about separating them by package. For example,
'o.a.h.luni.tests.api' - implementation independent tests
 'o.a.h.luni.tests.impl' - harmony specific tests

Then there will be no need in 'ImplTest' ending.

Thanks,
Stepan.




> >
> > >
> > > > BTW did we agree on that we won't follow directory-based tests
> layout
> > > [1]?
> > > > IMHO, not yet. IIRC we agreed that directory-based tests layout is
> not
> > > > quite
> > > > convenient for our needs and we'll try TestNG. But for me it doesn't
> > > mean
> > > > that we'll migrate to TestNG for sure. Also I assume that mixed
> > approach
> > > > (directory-based layout + annotations) is possible. So it is not
> time
> > > for
> > > > doing massive tests moves and merges.
> > >
> > > I've been watching the test layout/approach threads, but I haven't
> seen
> > > anything substantial fall out. I'm still waiting to see a simple and
> > clear
> > > suggestion. In any case, the current state is, frankly, a bit of a
> mess
> > > and
> > > any cleanup can't hurt.
> >
> >
> > Yes, I agree that clean up is required. But I'm not sure about changing
> > tests layout. IMHO we should wait for results of tests layout/approach
> > threads (Or it is possible to follow test layout proposal[1] - at least
> > I'd
> > follow section "Package and class names for different types of the
> > tests".)
>
> As I mentioned above, I am following the package and class naming
> conventions. In fact a majority of the changes have been to consolidate
> the
> duplicate tests into single tests under these naming conventions.
>
> >
> > Additionally, I was trying the separated directory layout to see what
> it's
> > > like and I can tell you first hand it's just not that great. It just
> > adds
> > > complexity in the repository and the build script. This may be needed
> > for
> > > some modules, but I don't see it as the norm. Also, I've been
> > > experimenting
> > > with just using plain-old JUnit TestSuites to separate pure-API tests
> > from
> > > implementation tests and it works very well. It works equally well for
> > > creating a failing-tests test suite. It also seems to make the tests
> run
> > > much faster, but I'm not sure why; maybe it's because Ant doesn't
> search
> > > for
> > > all tests, it just runs the single test that's an aggregate.
> > >
> > > >
> > > > And the minor comment to the commit log. It says: "remove unused
> > > folders".
> > > > But there are a lot of other unrelated changes. Was it possible to
> > make
> > > > separate commits?
> > >
> > > This was a mistake. I accidentally committed extra files with that
> > > revision.
> >
> >
> > OK, no problem.
> >
> > Thanks,
> > Stepan.
> >
> > [1]
> >
> http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.htm
> > l
> >
> > >
> > > -----Original Message-----
> > > From: ndbeyer@apache.org [mailto:ndbeyer@apache.org]
> > > Sent: Monday, August 14, 2006 2:56 AM
> > > To: harmony-commits@incubator.apache.org
> > > Subject: svn commit: r431219 - in
> > > /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> > > impl/
> > > java/org/apache/harmony/luni/tests/java/lang/
> > >
> > > Author: ndbeyer
> > > Date: Sun Aug 13 12:55:54 2006
> > > New Revision: 431219
> > >
> > > URL: http://svn.apache.org/viewvc?rev=431219&view=rev
> > > Log:
> > > remove unused folders
> > >
> > > Removed:
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/
> > > Modified:
> > >
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > pache/harmony/luni/tests/java/lang/DoubleTest.java
> > >
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> > >
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > pache/harmony/luni/tests/java/lang/ThreadGroupTest.java
> > >
> > > Modified:
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > pache/harmony/luni/tests/java/lang/DoubleTest.java
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/mod
> > >
> >
> ules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest
> > > .java?rev=431219&r1=431218&r2=431219&view=diff
> > >
> >
> ==========================================================================
> > > ====
> > >
> > >
> > > ---
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > pache/harmony/luni/tests/java/lang/DoubleTest.java
> > > (original)
> > > +++
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > pache/harmony/luni/tests/java/lang/DoubleTest.java
> > > Sun Aug 13 12:55:54 2006
> > > @@ -441,7 +441,7 @@
> > >       */
> > >      public void test_parseDoubleLjava_lang_String() {
> > >          assertEquals("Incorrect double returned, expected zero.", 0.0
> ,
> > > Double
> > > -                .parseDouble("2.4703282292062327208828439643411e-
> > 324"));
> > > +                .parseDouble("2.4703282292062327208828439643411e-324
> "),
> > > 0.0
> > > );
> > >          assertTrue("Incorrect double returned, expected minimum
> > double.",
> > > Double
> > >                  .parseDouble("2.4703282292062327208828439643412e-324
> ")
> > ==
> > > Double.MIN_VALUE);
> > >
> > >
> > > Modified:
> > >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > > pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> > > <SNIP>
>
>

-- 
Thanks,
Stepan Mishura
Intel Middleware Products Division

------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Re: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Stepan Mishura <st...@gmail.com>.
On 8/16/06, Mikhail Loenko wrote:
>
> You've probably meant x-net, because
> IIRC 'security' was relayout before these conversations started
>
> x-net layout could have changed after some conversations started,
> but after that all the modules weren't changed I believe


Yes, that's true.

As result of this discussion: can we agree on not changing tests layout
until we reach an agreement on using TestNG? (Or at least discuss it here
before doing).

Thanks,
Stepan.

Thanks,
> Mikhail
>
> 2006/8/16, Nathan Beyer <nb...@kc.rr.com>:
> >
> >
> > > -----Original Message-----
> > > From: Geir Magnusson Jr. [mailto:geir@pobox.com]
> > > Sent: Tuesday, August 15, 2006 11:41 PM
> > >
> > > On Aug 14, 2006, at 11:24 PM, Nathan Beyer wrote:
> > >
> > > >
> > > > I was waiting for a conclusion to come to the testing layout, but
> > > > nothing
> > > > has happened so far and I wanted to move ahead with cleaning up the
> > > > mess
> > > > that is currently the test case. As such, I decided to move forward
> > > > with
> > > > some of the testing proposal (the package naming convention) and
> > > > just keep
> > > > the folder layout simple by having just one folder. This greatly
> > > > simplified
> > > > the code layout as well as the build script.
> > >
> > > I think you should try to get some consensus on this, even as just a
> > > temporary step.
> >
> > We've had dozens of conversations about the directory layout for tests,
> > specifically about using folders like "src/test/api" and "src/test/impl"
> > (both for and against) and I have yet to see any consensus there, but
> this
> > hasn't stopped the 'security' module from being completely refactored to
> > follow this layout.
> >
> > >
> > > >
> > > > When an actual test scheme is finalized, we can move the tests to
> > > > whatever
> > > > folder is appropriate. SVN handles file and folder moves extremely
> > > > well and
> > > > tracks every change with ease.
> > > >
> > > > Right now, what I'm trying to do is:
> > > > * Consolidate all LUNI tests into "org.apache.harmony.luni.tests.**
> ".
> > > > * Get as many LUNI tests as possible to run on an RI JRE. Those
> > > > that are
> > > > specific implementation tests will be segregated. I'd say we'd be
> > > > lucky if
> > > > 50% of the tests that are API tests actually pass on an RI JRE.
> > >
> > > Anyone disagree with point 1?
> > >
> > > geir
> > >
>
>


-- 
Thanks,
Stepan Mishura
Intel Middleware Products Division

------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Re: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Mikhail Loenko <ml...@gmail.com>.
You've probably meant x-net, because
IIRC 'security' was relayout before these conversations started

x-net layout could have changed after some conversations started,
but after that all the modules weren't changed I believe

Thanks,
Mikhail

2006/8/16, Nathan Beyer <nb...@kc.rr.com>:
>
>
> > -----Original Message-----
> > From: Geir Magnusson Jr. [mailto:geir@pobox.com]
> > Sent: Tuesday, August 15, 2006 11:41 PM
> >
> > On Aug 14, 2006, at 11:24 PM, Nathan Beyer wrote:
> >
> > >
> > > I was waiting for a conclusion to come to the testing layout, but
> > > nothing
> > > has happened so far and I wanted to move ahead with cleaning up the
> > > mess
> > > that is currently the test case. As such, I decided to move forward
> > > with
> > > some of the testing proposal (the package naming convention) and
> > > just keep
> > > the folder layout simple by having just one folder. This greatly
> > > simplified
> > > the code layout as well as the build script.
> >
> > I think you should try to get some consensus on this, even as just a
> > temporary step.
>
> We've had dozens of conversations about the directory layout for tests,
> specifically about using folders like "src/test/api" and "src/test/impl"
> (both for and against) and I have yet to see any consensus there, but this
> hasn't stopped the 'security' module from being completely refactored to
> follow this layout.
>
> >
> > >
> > > When an actual test scheme is finalized, we can move the tests to
> > > whatever
> > > folder is appropriate. SVN handles file and folder moves extremely
> > > well and
> > > tracks every change with ease.
> > >
> > > Right now, what I'm trying to do is:
> > > * Consolidate all LUNI tests into "org.apache.harmony.luni.tests.**".
> > > * Get as many LUNI tests as possible to run on an RI JRE. Those
> > > that are
> > > specific implementation tests will be segregated. I'd say we'd be
> > > lucky if
> > > 50% of the tests that are API tests actually pass on an RI JRE.
> >
> > Anyone disagree with point 1?
> >
> > geir
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

RE: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Nathan Beyer <nb...@kc.rr.com>.

> -----Original Message-----
> From: Geir Magnusson Jr. [mailto:geir@pobox.com]
> Sent: Tuesday, August 15, 2006 11:41 PM
> 
> On Aug 14, 2006, at 11:24 PM, Nathan Beyer wrote:
> 
> >
> > I was waiting for a conclusion to come to the testing layout, but
> > nothing
> > has happened so far and I wanted to move ahead with cleaning up the
> > mess
> > that is currently the test case. As such, I decided to move forward
> > with
> > some of the testing proposal (the package naming convention) and
> > just keep
> > the folder layout simple by having just one folder. This greatly
> > simplified
> > the code layout as well as the build script.
> 
> I think you should try to get some consensus on this, even as just a
> temporary step.

We've had dozens of conversations about the directory layout for tests,
specifically about using folders like "src/test/api" and "src/test/impl"
(both for and against) and I have yet to see any consensus there, but this
hasn't stopped the 'security' module from being completely refactored to
follow this layout.

> 
> >
> > When an actual test scheme is finalized, we can move the tests to
> > whatever
> > folder is appropriate. SVN handles file and folder moves extremely
> > well and
> > tracks every change with ease.
> >
> > Right now, what I'm trying to do is:
> > * Consolidate all LUNI tests into "org.apache.harmony.luni.tests.**".
> > * Get as many LUNI tests as possible to run on an RI JRE. Those
> > that are
> > specific implementation tests will be segregated. I'd say we'd be
> > lucky if
> > 50% of the tests that are API tests actually pass on an RI JRE.
> 
> Anyone disagree with point 1?
> 
> geir
> 
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Re: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
On Aug 14, 2006, at 11:24 PM, Nathan Beyer wrote:

>
> I was waiting for a conclusion to come to the testing layout, but  
> nothing
> has happened so far and I wanted to move ahead with cleaning up the  
> mess
> that is currently the test case. As such, I decided to move forward  
> with
> some of the testing proposal (the package naming convention) and  
> just keep
> the folder layout simple by having just one folder. This greatly  
> simplified
> the code layout as well as the build script.

I think you should try to get some consensus on this, even as just a  
temporary step.

>
> When an actual test scheme is finalized, we can move the tests to  
> whatever
> folder is appropriate. SVN handles file and folder moves extremely  
> well and
> tracks every change with ease.
>
> Right now, what I'm trying to do is:
> * Consolidate all LUNI tests into "org.apache.harmony.luni.tests.**".
> * Get as many LUNI tests as possible to run on an RI JRE. Those  
> that are
> specific implementation tests will be segregated. I'd say we'd be  
> lucky if
> 50% of the tests that are API tests actually pass on an RI JRE.

Anyone disagree with point 1?

geir


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

RE: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Nathan Beyer <nb...@kc.rr.com>.
> -----Original Message-----
> From: Stepan Mishura [mailto:stepan.mishura@gmail.com]
> Sent: Monday, August 14, 2006 10:00 PM
> To: harmony-dev@incubator.apache.org
> Subject: Re: svn commit: r431219 - in
> /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> impl/ java/org/apache/harmony/luni/tests/java/lang/
> 
> On 8/15/06, Nathan Beyer wrote:
> >
> > > -----Original Message-----
> > > From: Stepan Mishura
> > > Sent: Monday, August 14, 2006 6:36 AM
> > > To: harmony-dev
> > > Subject: Re: svn commit: r431219 - in
> > > /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> > > impl/ java/org/apache/harmony/luni/tests/java/lang/
> > >
> > > Hi Nathan,
> > >
> > > I saw that you've changed tests layout (consolidated) tests in luni
> > > module.
> > > But I don't understand what the purpose for the change. Is this a
> first
> > > step
> > > for migrating to TestNG? (May be I missed something important - sorry
> > for
> > > stupid question then.)
> >
> > No, I'm just trying to put all of the tests into what I would consider
> is
> > a
> > defacto standard "src/test/java" and "src/test/resources". The actual
> goal
> > of this consolidation is to pull together all of the duplicated tests
> and
> > similar tests. This is reducing the test run time for luni and making
> > patch
> > creation/application much easier. At the same time, I've been cleaning
> up
> > the tests so that those that don't run can be run and anything that
> > doesn't
> > run on a RI is fixed, so that it does.
> 
> 
> I agree with that tests layout in luni module is really confusing and it
> should be fixed.
> But I'd follow tests layout proposal [1] or discuss it here how luni tests
> will be reorganizaed.
> For example, I don't understand moving tests from 'api' and 'impl' to
> 'java'
> folder - how implementation specific tests are differ from implementation
> independent tests now? I guess that implementation specific tests ends
> with
> 'ImplTest', right? But why they are running together with implementation
> independent tests?

Right now and since the LUNI module has existed, there hasn't been any
difference between API tests, impl tests or any other tests. The only
separation there is now are tests that run and pass on classlib+j9 and those
that are excluded. Even the tests that are in the "tests.api" package don't
run on the RI -- it's about 50/50 right now. Note: there is ONE known
implementation specific test, which I created and that's
"org.apache.harmony.luni.tests.java.lang.CharacterImplTest".

If you look back in the version history, all of the tests were under
"src/test/java" at one point. I rearranged the folder to try out the
proposal, which is where the 'api' and 'impl' folders came from. I also
modified the build.xml to setup the multiple tests runs and everything that
was in 'src/test/java' and 'src/test/java/impl' was run considered a Harmony
implementation test.

I was waiting for a conclusion to come to the testing layout, but nothing
has happened so far and I wanted to move ahead with cleaning up the mess
that is currently the test case. As such, I decided to move forward with
some of the testing proposal (the package naming convention) and just keep
the folder layout simple by having just one folder. This greatly simplified
the code layout as well as the build script.

When an actual test scheme is finalized, we can move the tests to whatever
folder is appropriate. SVN handles file and folder moves extremely well and
tracks every change with ease.

Right now, what I'm trying to do is:
* Consolidate all LUNI tests into "org.apache.harmony.luni.tests.**".
* Get as many LUNI tests as possible to run on an RI JRE. Those that are
specific implementation tests will be segregated. I'd say we'd be lucky if
50% of the tests that are API tests actually pass on an RI JRE.

> 
> >
> > > BTW did we agree on that we won't follow directory-based tests layout
> > [1]?
> > > IMHO, not yet. IIRC we agreed that directory-based tests layout is not
> > > quite
> > > convenient for our needs and we'll try TestNG. But for me it doesn't
> > mean
> > > that we'll migrate to TestNG for sure. Also I assume that mixed
> approach
> > > (directory-based layout + annotations) is possible. So it is not time
> > for
> > > doing massive tests moves and merges.
> >
> > I've been watching the test layout/approach threads, but I haven't seen
> > anything substantial fall out. I'm still waiting to see a simple and
> clear
> > suggestion. In any case, the current state is, frankly, a bit of a mess
> > and
> > any cleanup can't hurt.
> 
> 
> Yes, I agree that clean up is required. But I'm not sure about changing
> tests layout. IMHO we should wait for results of tests layout/approach
> threads (Or it is possible to follow test layout proposal[1] - at least
> I'd
> follow section "Package and class names for different types of the
> tests".)

As I mentioned above, I am following the package and class naming
conventions. In fact a majority of the changes have been to consolidate the
duplicate tests into single tests under these naming conventions.

> 
> Additionally, I was trying the separated directory layout to see what it's
> > like and I can tell you first hand it's just not that great. It just
> adds
> > complexity in the repository and the build script. This may be needed
> for
> > some modules, but I don't see it as the norm. Also, I've been
> > experimenting
> > with just using plain-old JUnit TestSuites to separate pure-API tests
> from
> > implementation tests and it works very well. It works equally well for
> > creating a failing-tests test suite. It also seems to make the tests run
> > much faster, but I'm not sure why; maybe it's because Ant doesn't search
> > for
> > all tests, it just runs the single test that's an aggregate.
> >
> > >
> > > And the minor comment to the commit log. It says: "remove unused
> > folders".
> > > But there are a lot of other unrelated changes. Was it possible to
> make
> > > separate commits?
> >
> > This was a mistake. I accidentally committed extra files with that
> > revision.
> 
> 
> OK, no problem.
> 
> Thanks,
> Stepan.
> 
> [1]
> http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.htm
> l
> 
> >
> > -----Original Message-----
> > From: ndbeyer@apache.org [mailto:ndbeyer@apache.org]
> > Sent: Monday, August 14, 2006 2:56 AM
> > To: harmony-commits@incubator.apache.org
> > Subject: svn commit: r431219 - in
> > /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> > impl/
> > java/org/apache/harmony/luni/tests/java/lang/
> >
> > Author: ndbeyer
> > Date: Sun Aug 13 12:55:54 2006
> > New Revision: 431219
> >
> > URL: http://svn.apache.org/viewvc?rev=431219&view=rev
> > Log:
> > remove unused folders
> >
> > Removed:
> >     incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/
> > Modified:
> >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > pache/harmony/luni/tests/java/lang/DoubleTest.java
> >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> >
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > pache/harmony/luni/tests/java/lang/ThreadGroupTest.java
> >
> > Modified:
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > pache/harmony/luni/tests/java/lang/DoubleTest.java
> > URL:
> >
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/mod
> >
> ules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest
> > .java?rev=431219&r1=431218&r2=431219&view=diff
> >
> ==========================================================================
> > ====
> >
> >
> > ---
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > pache/harmony/luni/tests/java/lang/DoubleTest.java
> > (original)
> > +++
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > pache/harmony/luni/tests/java/lang/DoubleTest.java
> > Sun Aug 13 12:55:54 2006
> > @@ -441,7 +441,7 @@
> >       */
> >      public void test_parseDoubleLjava_lang_String() {
> >          assertEquals("Incorrect double returned, expected zero.", 0.0,
> > Double
> > -                .parseDouble("2.4703282292062327208828439643411e-
> 324"));
> > +                .parseDouble("2.4703282292062327208828439643411e-324"),
> > 0.0
> > );
> >          assertTrue("Incorrect double returned, expected minimum
> double.",
> > Double
> >                  .parseDouble("2.4703282292062327208828439643412e-324")
> ==
> > Double.MIN_VALUE);
> >
> >
> > Modified:
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> > <SNIP>
> >
> >
> > ------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 
> 
> 
> 
> --
> Thanks,
> Stepan Mishura
> Intel Middleware Products Division
> 
> ------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Re: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Stepan Mishura <st...@gmail.com>.
On 8/15/06, Nathan Beyer wrote:
>
> > -----Original Message-----
> > From: Stepan Mishura
> > Sent: Monday, August 14, 2006 6:36 AM
> > To: harmony-dev
> > Subject: Re: svn commit: r431219 - in
> > /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> > impl/ java/org/apache/harmony/luni/tests/java/lang/
> >
> > Hi Nathan,
> >
> > I saw that you've changed tests layout (consolidated) tests in luni
> > module.
> > But I don't understand what the purpose for the change. Is this a first
> > step
> > for migrating to TestNG? (May be I missed something important - sorry
> for
> > stupid question then.)
>
> No, I'm just trying to put all of the tests into what I would consider is
> a
> defacto standard "src/test/java" and "src/test/resources". The actual goal
> of this consolidation is to pull together all of the duplicated tests and
> similar tests. This is reducing the test run time for luni and making
> patch
> creation/application much easier. At the same time, I've been cleaning up
> the tests so that those that don't run can be run and anything that
> doesn't
> run on a RI is fixed, so that it does.


I agree with that tests layout in luni module is really confusing and it
should be fixed.
But I'd follow tests layout proposal [1] or discuss it here how luni tests
will be reorganizaed.
For example, I don't understand moving tests from 'api' and 'impl' to 'java'
folder - how implementation specific tests are differ from implementation
independent tests now? I guess that implementation specific tests ends with
'ImplTest', right? But why they are running together with implementation
independent tests?

>
> > BTW did we agree on that we won't follow directory-based tests layout
> [1]?
> > IMHO, not yet. IIRC we agreed that directory-based tests layout is not
> > quite
> > convenient for our needs and we'll try TestNG. But for me it doesn't
> mean
> > that we'll migrate to TestNG for sure. Also I assume that mixed approach
> > (directory-based layout + annotations) is possible. So it is not time
> for
> > doing massive tests moves and merges.
>
> I've been watching the test layout/approach threads, but I haven't seen
> anything substantial fall out. I'm still waiting to see a simple and clear
> suggestion. In any case, the current state is, frankly, a bit of a mess
> and
> any cleanup can't hurt.


Yes, I agree that clean up is required. But I'm not sure about changing
tests layout. IMHO we should wait for results of tests layout/approach
threads (Or it is possible to follow test layout proposal[1] - at least I'd
follow section "Package and class names for different types of the tests".)

Additionally, I was trying the separated directory layout to see what it's
> like and I can tell you first hand it's just not that great. It just adds
> complexity in the repository and the build script. This may be needed for
> some modules, but I don't see it as the norm. Also, I've been
> experimenting
> with just using plain-old JUnit TestSuites to separate pure-API tests from
> implementation tests and it works very well. It works equally well for
> creating a failing-tests test suite. It also seems to make the tests run
> much faster, but I'm not sure why; maybe it's because Ant doesn't search
> for
> all tests, it just runs the single test that's an aggregate.
>
> >
> > And the minor comment to the commit log. It says: "remove unused
> folders".
> > But there are a lot of other unrelated changes. Was it possible to make
> > separate commits?
>
> This was a mistake. I accidentally committed extra files with that
> revision.


OK, no problem.

Thanks,
Stepan.

[1]
http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.html

>
> -----Original Message-----
> From: ndbeyer@apache.org [mailto:ndbeyer@apache.org]
> Sent: Monday, August 14, 2006 2:56 AM
> To: harmony-commits@incubator.apache.org
> Subject: svn commit: r431219 - in
> /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> impl/
> java/org/apache/harmony/luni/tests/java/lang/
>
> Author: ndbeyer
> Date: Sun Aug 13 12:55:54 2006
> New Revision: 431219
>
> URL: http://svn.apache.org/viewvc?rev=431219&view=rev
> Log:
> remove unused folders
>
> Removed:
>     incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/
>     incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/
> Modified:
>
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/DoubleTest.java
>
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
>
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/ThreadGroupTest.java
>
> Modified:
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/DoubleTest.java
> URL:
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/mod
> ules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest
> .java?rev=431219&r1=431218&r2=431219&view=diff
> ==========================================================================
> ====
>
>
> ---
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/DoubleTest.java
> (original)
> +++
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/DoubleTest.java
> Sun Aug 13 12:55:54 2006
> @@ -441,7 +441,7 @@
>       */
>      public void test_parseDoubleLjava_lang_String() {
>          assertEquals("Incorrect double returned, expected zero.", 0.0,
> Double
> -                .parseDouble("2.4703282292062327208828439643411e-324"));
> +                .parseDouble("2.4703282292062327208828439643411e-324"),
> 0.0
> );
>          assertTrue("Incorrect double returned, expected minimum double.",
> Double
>                  .parseDouble("2.4703282292062327208828439643412e-324") ==
> Double.MIN_VALUE);
>
>
> Modified:
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> <SNIP>
>
>
> ------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org





-- 
Thanks,
Stepan Mishura
Intel Middleware Products Division

------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

RE: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Nathan Beyer <nb...@kc.rr.com>.

> -----Original Message-----
> From: Stepan Mishura [mailto:stepan.mishura@gmail.com]
> Sent: Monday, August 14, 2006 10:07 PM
> To: harmony-dev@incubator.apache.org
> Subject: Re: svn commit: r431219 - in
> /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> impl/ java/org/apache/harmony/luni/tests/java/lang/
> 
> On 8/15/06, Paulex Yang wrote:
> >
> > I agree it's not right time to re-layout test case right now, but
> > actually LUNI is a different case, whose test layout is a little....too
> > confusing...
> 
> 
> I agree with you and Nathan that the layout is confusing. But how it
> should
> be changed?
> Currently we have only one complete proposal [1]. But the change doesn't
> follow it. Is this a new apporach for luni tests?

Most of what I've done has little to do with layout. About 10% of the tests
were NOT under the "src/test/java" folder. There just wasn't any value to
having the other folders for this module, at least not yet, so I just backed
up a bit and put ALL tests back under the one folder.

The particular changes you've picked out are just minor moves. The majority
of the work I've done is moving and fixing tests in packages "tests.api" to
"org.apache.harmony.luni.tests.**". Note, even though the packages say
"tests.api", the majority of them fail miserable when run on an RI JRE.

-Nathan

> 
> Thanks,
> Stepan.
> 
> [1] *
> http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.htm
> l*<http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.
> html>
> 
> For example, there is package name o.a.h.luni.tests.java.lang as well as
> > o.a.h.tests.java.lang, IMHO, what ever methods we take at last, it's
> > hard to understand what difference between them...further, there are
> > another several packages named as tests.api.java.lang(it's worse before
> > Nathan removed another two source folders), I myself always failed to
> > find any test class at first try even in Eclipse(and it's nightmare if
> > in explorer). So I believe some merge work is necessary, after all we
> > must understand what's going on in that LUNI labyrinth before we apply
> > any layout/metadata approach to it.
> >
> > Nathan Beyer wrote:
> > >
> > >> -----Original Message-----
> > >> From: Stepan Mishura [mailto:stepan.mishura@gmail.com]
> > >> Sent: Monday, August 14, 2006 6:36 AM
> > >> To: harmony-dev
> > >> Subject: Re: svn commit: r431219 - in
> > >> /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test:
> api/
> > >> impl/ java/org/apache/harmony/luni/tests/java/lang/
> > >>
> > >> Hi Nathan,
> > >>
> > >> I saw that you've changed tests layout (consolidated) tests in luni
> > >> module.
> > >> But I don't understand what the purpose for the change. Is this a
> first
> > >> step
> > >> for migrating to TestNG? (May be I missed something important - sorry
> > for
> > >> stupid question then.)
> > >>
> > >
> > > No, I'm just trying to put all of the tests into what I would consider
> > is a
> > > defacto standard "src/test/java" and "src/test/resources". The actual
> > goal
> > > of this consolidation is to pull together all of the duplicated tests
> > and
> > > similar tests. This is reducing the test run time for luni and making
> > patch
> > > creation/application much easier. At the same time, I've been cleaning
> > up
> > > the tests so that those that don't run can be run and anything that
> > doesn't
> > > run on a RI is fixed, so that it does.
> > >
> > >
> > >> BTW did we agree on that we won't follow directory-based tests layout
> > [1]?
> > >> IMHO, not yet. IIRC we agreed that directory-based tests layout is
> not
> > >> quite
> > >> convenient for our needs and we'll try TestNG. But for me it doesn't
> > mean
> > >> that we'll migrate to TestNG for sure. Also I assume that mixed
> > approach
> > >> (directory-based layout + annotations) is possible. So it is not time
> > for
> > >> doing massive tests moves and merges.
> > >>
> > >
> > > I've been watching the test layout/approach threads, but I haven't
> seen
> > > anything substantial fall out. I'm still waiting to see a simple and
> > clear
> > > suggestion. In any case, the current state is, frankly, a bit of a
> mess
> > and
> > > any cleanup can't hurt.
> > >
> > > Additionally, I was trying the separated directory layout to see what
> > it's
> > > like and I can tell you first hand it's just not that great. It just
> > adds
> > > complexity in the repository and the build script. This may be needed
> > for
> > > some modules, but I don't see it as the norm. Also, I've been
> > experimenting
> > > with just using plain-old JUnit TestSuites to separate pure-API tests
> > from
> > > implementation tests and it works very well. It works equally well for
> > > creating a failing-tests test suite. It also seems to make the tests
> run
> > > much faster, but I'm not sure why; maybe it's because Ant doesn't
> search
> > for
> > > all tests, it just runs the single test that's an aggregate.
> > >
> > >
> > >> And the minor comment to the commit log. It says: "remove unused
> > folders".
> > >> But there are a lot of other unrelated changes. Was it possible to
> make
> > >> separate commits?
> > >>
> > >
> > > This was a mistake. I accidentally committed extra files with that
> > revision.
> > >
> > >
> > >> Thanks,
> > >> Stepan.
> > >>
> > >> [1]
> > >>
> >
> http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.htm
> > >> l
> > >>
> > >> -----Original Message-----
> > >> From: ndbeyer@apache.org [mailto:ndbeyer@apache.org]
> > >> Sent: Monday, August 14, 2006 2:56 AM
> > >> To: harmony-commits@incubator.apache.org
> > >> Subject: svn commit: r431219 - in
> > >> /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test:
> api/
> > >> impl/
> > >> java/org/apache/harmony/luni/tests/java/lang/
> > >>
> > >> Author: ndbeyer
> > >> Date: Sun Aug 13 12:55:54 2006
> > >> New Revision: 431219
> > >>
> > >> URL: http://svn.apache.org/viewvc?rev=431219&view=rev
> > >> Log:
> > >> remove unused folders
> > >>
> > >> Removed:
> > >>
> > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/
> > >>
> > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/
> > >> Modified:
> > >>
> > >>
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > >> pache/harmony/luni/tests/java/lang/DoubleTest.java
> > >>
> > >>
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > >> pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> > >>
> > >>
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > >> pache/harmony/luni/tests/java/lang/ThreadGroupTest.java
> > >>
> > >> Modified:
> > >>
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > >> pache/harmony/luni/tests/java/lang/DoubleTest.java
> > >> URL:
> > >>
> >
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/mod
> > >>
> >
> ules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest
> > >> .java?rev=431219&r1=431218&r2=431219&view=diff
> > >>
> >
> ==========================================================================
> > >> ====
> > >>
> > >>
> > >> ---
> > >>
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > >> pache/harmony/luni/tests/java/lang/DoubleTest.java
> > >> (original)
> > >> +++
> > >>
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > >> pache/harmony/luni/tests/java/lang/DoubleTest.java
> > >> Sun Aug 13 12:55:54 2006
> > >> @@ -441,7 +441,7 @@
> > >>       */
> > >>      public void test_parseDoubleLjava_lang_String() {
> > >>          assertEquals("Incorrect double returned, expected zero.",
> 0.0,
> > >> Double
> > >> -                .parseDouble("2.4703282292062327208828439643411e-324
> > "));
> > >> +                .parseDouble("2.4703282292062327208828439643411e-324
> > "),
> > >> 0.0
> > >> );
> > >>          assertTrue("Incorrect double returned, expected minimum
> > double.",
> > >> Double
> > >>                  .parseDouble("2.4703282292062327208828439643412e-
> 324")
> > ==
> > >> Double.MIN_VALUE);
> > >>
> > >>
> > >> Modified:
> > >>
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> > >> pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> > >> <SNIP>
> > >>
> > >>
> > >> ------------------------------------------------------
> > >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > >> For additional commands, e-mail: harmony-dev-
> help@incubator.apache.org
> > >>
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> > >
> >
> >
> > --
> > Paulex Yang
> > China Software Development Lab
> > IBM
> >
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
> 
> 
> --
> Thanks,
> Stepan Mishura
> Intel Middleware Products Division
> 
> ------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Re: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Stepan Mishura <st...@gmail.com>.
On 8/15/06, Paulex Yang wrote:
>
> I agree it's not right time to re-layout test case right now, but
> actually LUNI is a different case, whose test layout is a little....too
> confusing...


I agree with you and Nathan that the layout is confusing. But how it should
be changed?
Currently we have only one complete proposal [1]. But the change doesn't
follow it. Is this a new apporach for luni tests?

Thanks,
Stepan.

[1] *
http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.html*<http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.html>

For example, there is package name o.a.h.luni.tests.java.lang as well as
> o.a.h.tests.java.lang, IMHO, what ever methods we take at last, it's
> hard to understand what difference between them...further, there are
> another several packages named as tests.api.java.lang(it's worse before
> Nathan removed another two source folders), I myself always failed to
> find any test class at first try even in Eclipse(and it's nightmare if
> in explorer). So I believe some merge work is necessary, after all we
> must understand what's going on in that LUNI labyrinth before we apply
> any layout/metadata approach to it.
>
> Nathan Beyer wrote:
> >
> >> -----Original Message-----
> >> From: Stepan Mishura [mailto:stepan.mishura@gmail.com]
> >> Sent: Monday, August 14, 2006 6:36 AM
> >> To: harmony-dev
> >> Subject: Re: svn commit: r431219 - in
> >> /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> >> impl/ java/org/apache/harmony/luni/tests/java/lang/
> >>
> >> Hi Nathan,
> >>
> >> I saw that you've changed tests layout (consolidated) tests in luni
> >> module.
> >> But I don't understand what the purpose for the change. Is this a first
> >> step
> >> for migrating to TestNG? (May be I missed something important - sorry
> for
> >> stupid question then.)
> >>
> >
> > No, I'm just trying to put all of the tests into what I would consider
> is a
> > defacto standard "src/test/java" and "src/test/resources". The actual
> goal
> > of this consolidation is to pull together all of the duplicated tests
> and
> > similar tests. This is reducing the test run time for luni and making
> patch
> > creation/application much easier. At the same time, I've been cleaning
> up
> > the tests so that those that don't run can be run and anything that
> doesn't
> > run on a RI is fixed, so that it does.
> >
> >
> >> BTW did we agree on that we won't follow directory-based tests layout
> [1]?
> >> IMHO, not yet. IIRC we agreed that directory-based tests layout is not
> >> quite
> >> convenient for our needs and we'll try TestNG. But for me it doesn't
> mean
> >> that we'll migrate to TestNG for sure. Also I assume that mixed
> approach
> >> (directory-based layout + annotations) is possible. So it is not time
> for
> >> doing massive tests moves and merges.
> >>
> >
> > I've been watching the test layout/approach threads, but I haven't seen
> > anything substantial fall out. I'm still waiting to see a simple and
> clear
> > suggestion. In any case, the current state is, frankly, a bit of a mess
> and
> > any cleanup can't hurt.
> >
> > Additionally, I was trying the separated directory layout to see what
> it's
> > like and I can tell you first hand it's just not that great. It just
> adds
> > complexity in the repository and the build script. This may be needed
> for
> > some modules, but I don't see it as the norm. Also, I've been
> experimenting
> > with just using plain-old JUnit TestSuites to separate pure-API tests
> from
> > implementation tests and it works very well. It works equally well for
> > creating a failing-tests test suite. It also seems to make the tests run
> > much faster, but I'm not sure why; maybe it's because Ant doesn't search
> for
> > all tests, it just runs the single test that's an aggregate.
> >
> >
> >> And the minor comment to the commit log. It says: "remove unused
> folders".
> >> But there are a lot of other unrelated changes. Was it possible to make
> >> separate commits?
> >>
> >
> > This was a mistake. I accidentally committed extra files with that
> revision.
> >
> >
> >> Thanks,
> >> Stepan.
> >>
> >> [1]
> >>
> http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.htm
> >> l
> >>
> >> -----Original Message-----
> >> From: ndbeyer@apache.org [mailto:ndbeyer@apache.org]
> >> Sent: Monday, August 14, 2006 2:56 AM
> >> To: harmony-commits@incubator.apache.org
> >> Subject: svn commit: r431219 - in
> >> /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> >> impl/
> >> java/org/apache/harmony/luni/tests/java/lang/
> >>
> >> Author: ndbeyer
> >> Date: Sun Aug 13 12:55:54 2006
> >> New Revision: 431219
> >>
> >> URL: http://svn.apache.org/viewvc?rev=431219&view=rev
> >> Log:
> >> remove unused folders
> >>
> >> Removed:
> >>
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/
> >>
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/
> >> Modified:
> >>
> >>
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> >> pache/harmony/luni/tests/java/lang/DoubleTest.java
> >>
> >>
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> >> pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> >>
> >>
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> >> pache/harmony/luni/tests/java/lang/ThreadGroupTest.java
> >>
> >> Modified:
> >>
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> >> pache/harmony/luni/tests/java/lang/DoubleTest.java
> >> URL:
> >>
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/mod
> >>
> ules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest
> >> .java?rev=431219&r1=431218&r2=431219&view=diff
> >>
> ==========================================================================
> >> ====
> >>
> >>
> >> ---
> >>
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> >> pache/harmony/luni/tests/java/lang/DoubleTest.java
> >> (original)
> >> +++
> >>
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> >> pache/harmony/luni/tests/java/lang/DoubleTest.java
> >> Sun Aug 13 12:55:54 2006
> >> @@ -441,7 +441,7 @@
> >>       */
> >>      public void test_parseDoubleLjava_lang_String() {
> >>          assertEquals("Incorrect double returned, expected zero.", 0.0,
> >> Double
> >> -                .parseDouble("2.4703282292062327208828439643411e-324
> "));
> >> +                .parseDouble("2.4703282292062327208828439643411e-324
> "),
> >> 0.0
> >> );
> >>          assertTrue("Incorrect double returned, expected minimum
> double.",
> >> Double
> >>                  .parseDouble("2.4703282292062327208828439643412e-324")
> ==
> >> Double.MIN_VALUE);
> >>
> >>
> >> Modified:
> >>
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> >> pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> >> <SNIP>
> >>
> >>
> >> ------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
> >
>
>
> --
> Paulex Yang
> China Software Development Lab
> IBM
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Thanks,
Stepan Mishura
Intel Middleware Products Division

------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Re: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Paulex Yang <pa...@gmail.com>.
I agree it's not right time to re-layout test case right now, but 
actually LUNI is a different case, whose test layout is a little....too 
confusing...

For example, there is package name o.a.h.luni.tests.java.lang as well as 
o.a.h.tests.java.lang, IMHO, what ever methods we take at last, it's 
hard to understand what difference between them...further, there are 
another several packages named as tests.api.java.lang(it's worse before 
Nathan removed another two source folders), I myself always failed to 
find any test class at first try even in Eclipse(and it's nightmare if 
in explorer). So I believe some merge work is necessary, after all we 
must understand what's going on in that LUNI labyrinth before we apply 
any layout/metadata approach to it.

Nathan Beyer wrote:
>   
>> -----Original Message-----
>> From: Stepan Mishura [mailto:stepan.mishura@gmail.com]
>> Sent: Monday, August 14, 2006 6:36 AM
>> To: harmony-dev
>> Subject: Re: svn commit: r431219 - in
>> /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
>> impl/ java/org/apache/harmony/luni/tests/java/lang/
>>
>> Hi Nathan,
>>
>> I saw that you've changed tests layout (consolidated) tests in luni
>> module.
>> But I don't understand what the purpose for the change. Is this a first
>> step
>> for migrating to TestNG? (May be I missed something important - sorry for
>> stupid question then.)
>>     
>
> No, I'm just trying to put all of the tests into what I would consider is a
> defacto standard "src/test/java" and "src/test/resources". The actual goal
> of this consolidation is to pull together all of the duplicated tests and
> similar tests. This is reducing the test run time for luni and making patch
> creation/application much easier. At the same time, I've been cleaning up
> the tests so that those that don't run can be run and anything that doesn't
> run on a RI is fixed, so that it does.
>
>   
>> BTW did we agree on that we won't follow directory-based tests layout [1]?
>> IMHO, not yet. IIRC we agreed that directory-based tests layout is not
>> quite
>> convenient for our needs and we'll try TestNG. But for me it doesn't mean
>> that we'll migrate to TestNG for sure. Also I assume that mixed approach
>> (directory-based layout + annotations) is possible. So it is not time for
>> doing massive tests moves and merges.
>>     
>
> I've been watching the test layout/approach threads, but I haven't seen
> anything substantial fall out. I'm still waiting to see a simple and clear
> suggestion. In any case, the current state is, frankly, a bit of a mess and
> any cleanup can't hurt.
>
> Additionally, I was trying the separated directory layout to see what it's
> like and I can tell you first hand it's just not that great. It just adds
> complexity in the repository and the build script. This may be needed for
> some modules, but I don't see it as the norm. Also, I've been experimenting
> with just using plain-old JUnit TestSuites to separate pure-API tests from
> implementation tests and it works very well. It works equally well for
> creating a failing-tests test suite. It also seems to make the tests run
> much faster, but I'm not sure why; maybe it's because Ant doesn't search for
> all tests, it just runs the single test that's an aggregate.
>
>   
>> And the minor comment to the commit log. It says: "remove unused folders".
>> But there are a lot of other unrelated changes. Was it possible to make
>> separate commits?
>>     
>
> This was a mistake. I accidentally committed extra files with that revision.
>
>   
>> Thanks,
>> Stepan.
>>
>> [1]
>> http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.htm
>> l
>>
>> -----Original Message-----
>> From: ndbeyer@apache.org [mailto:ndbeyer@apache.org]
>> Sent: Monday, August 14, 2006 2:56 AM
>> To: harmony-commits@incubator.apache.org
>> Subject: svn commit: r431219 - in
>> /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
>> impl/
>> java/org/apache/harmony/luni/tests/java/lang/
>>
>> Author: ndbeyer
>> Date: Sun Aug 13 12:55:54 2006
>> New Revision: 431219
>>
>> URL: http://svn.apache.org/viewvc?rev=431219&view=rev
>> Log:
>> remove unused folders
>>
>> Removed:
>>     incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/
>>     incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/
>> Modified:
>>
>> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
>> pache/harmony/luni/tests/java/lang/DoubleTest.java
>>
>> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
>> pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
>>
>> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
>> pache/harmony/luni/tests/java/lang/ThreadGroupTest.java
>>
>> Modified:
>> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
>> pache/harmony/luni/tests/java/lang/DoubleTest.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/mod
>> ules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest
>> .java?rev=431219&r1=431218&r2=431219&view=diff
>> ==========================================================================
>> ====
>>
>>
>> ---
>> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
>> pache/harmony/luni/tests/java/lang/DoubleTest.java
>> (original)
>> +++
>> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
>> pache/harmony/luni/tests/java/lang/DoubleTest.java
>> Sun Aug 13 12:55:54 2006
>> @@ -441,7 +441,7 @@
>>       */
>>      public void test_parseDoubleLjava_lang_String() {
>>          assertEquals("Incorrect double returned, expected zero.", 0.0,
>> Double
>> -                .parseDouble("2.4703282292062327208828439643411e-324"));
>> +                .parseDouble("2.4703282292062327208828439643411e-324"),
>> 0.0
>> );
>>          assertTrue("Incorrect double returned, expected minimum double.",
>> Double
>>                  .parseDouble("2.4703282292062327208828439643412e-324") ==
>> Double.MIN_VALUE);
>>
>>
>> Modified:
>> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
>> pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
>> <SNIP>
>>
>>
>> ------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>     
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
>   


-- 
Paulex Yang
China Software Development Lab
IBM



---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

RE: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/

Posted by Nathan Beyer <nb...@kc.rr.com>.

> -----Original Message-----
> From: Stepan Mishura [mailto:stepan.mishura@gmail.com]
> Sent: Monday, August 14, 2006 6:36 AM
> To: harmony-dev
> Subject: Re: svn commit: r431219 - in
> /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> impl/ java/org/apache/harmony/luni/tests/java/lang/
> 
> Hi Nathan,
> 
> I saw that you've changed tests layout (consolidated) tests in luni
> module.
> But I don't understand what the purpose for the change. Is this a first
> step
> for migrating to TestNG? (May be I missed something important - sorry for
> stupid question then.)

No, I'm just trying to put all of the tests into what I would consider is a
defacto standard "src/test/java" and "src/test/resources". The actual goal
of this consolidation is to pull together all of the duplicated tests and
similar tests. This is reducing the test run time for luni and making patch
creation/application much easier. At the same time, I've been cleaning up
the tests so that those that don't run can be run and anything that doesn't
run on a RI is fixed, so that it does.

> 
> BTW did we agree on that we won't follow directory-based tests layout [1]?
> IMHO, not yet. IIRC we agreed that directory-based tests layout is not
> quite
> convenient for our needs and we'll try TestNG. But for me it doesn't mean
> that we'll migrate to TestNG for sure. Also I assume that mixed approach
> (directory-based layout + annotations) is possible. So it is not time for
> doing massive tests moves and merges.

I've been watching the test layout/approach threads, but I haven't seen
anything substantial fall out. I'm still waiting to see a simple and clear
suggestion. In any case, the current state is, frankly, a bit of a mess and
any cleanup can't hurt.

Additionally, I was trying the separated directory layout to see what it's
like and I can tell you first hand it's just not that great. It just adds
complexity in the repository and the build script. This may be needed for
some modules, but I don't see it as the norm. Also, I've been experimenting
with just using plain-old JUnit TestSuites to separate pure-API tests from
implementation tests and it works very well. It works equally well for
creating a failing-tests test suite. It also seems to make the tests run
much faster, but I'm not sure why; maybe it's because Ant doesn't search for
all tests, it just runs the single test that's an aggregate.

> 
> And the minor comment to the commit log. It says: "remove unused folders".
> But there are a lot of other unrelated changes. Was it possible to make
> separate commits?

This was a mistake. I accidentally committed extra files with that revision.

> 
> Thanks,
> Stepan.
> 
> [1]
> http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.htm
> l
> 
> -----Original Message-----
> From: ndbeyer@apache.org [mailto:ndbeyer@apache.org]
> Sent: Monday, August 14, 2006 2:56 AM
> To: harmony-commits@incubator.apache.org
> Subject: svn commit: r431219 - in
> /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/
> impl/
> java/org/apache/harmony/luni/tests/java/lang/
> 
> Author: ndbeyer
> Date: Sun Aug 13 12:55:54 2006
> New Revision: 431219
> 
> URL: http://svn.apache.org/viewvc?rev=431219&view=rev
> Log:
> remove unused folders
> 
> Removed:
>     incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/
>     incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/
> Modified:
> 
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/DoubleTest.java
> 
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> 
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/ThreadGroupTest.java
> 
> Modified:
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/DoubleTest.java
> URL:
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/mod
> ules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest
> .java?rev=431219&r1=431218&r2=431219&view=diff
> ==========================================================================
> ====
> 
> 
> ---
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/DoubleTest.java
> (original)
> +++
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/DoubleTest.java
> Sun Aug 13 12:55:54 2006
> @@ -441,7 +441,7 @@
>       */
>      public void test_parseDoubleLjava_lang_String() {
>          assertEquals("Incorrect double returned, expected zero.", 0.0,
> Double
> -                .parseDouble("2.4703282292062327208828439643411e-324"));
> +                .parseDouble("2.4703282292062327208828439643411e-324"),
> 0.0
> );
>          assertTrue("Incorrect double returned, expected minimum double.",
> Double
>                  .parseDouble("2.4703282292062327208828439643412e-324") ==
> Double.MIN_VALUE);
> 
> 
> Modified:
> incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/a
> pache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> <SNIP>
> 
> 
> ------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org