You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "ByteYue (via GitHub)" <gi...@apache.org> on 2023/02/11 15:58:45 UTC
[GitHub] [doris] ByteYue opened a new pull request, #16641: [Bug](Cooldown) fix load balance causing no cooldown replica
ByteYue opened a new pull request, #16641:
URL: https://github.com/apache/doris/pull/16641
# Proposed changes
Issue Number: close #xxx
Currently cooldown's implementation would compare the replica id of the local replica and cooldown_replica_id inside the cooldown conf, unfortunately the `Tablet::revise_tablet_meta` didn't set the right replica id due to the lack of copy of replica id when using copy constructor of tablet meta. Which would end up tablet meta with replica id equals to 0. And the subsequent comparison would fail, neither would the cooldown operation.
Plus, this pr add some log for better replica tracing when doing cloning.
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [x] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16641: [Bug](Cooldown) fix load balance causing no cooldown replica
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16641:
URL: https://github.com/apache/doris/pull/16641#issuecomment-1426808096
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16641: [Bug](Cooldown) fix load balance causing no cooldown replica
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16641:
URL: https://github.com/apache/doris/pull/16641#issuecomment-1426809325
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] platoneko commented on a diff in pull request #16641: [Bug](Cooldown) fix load balance causing no cooldown replica
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on code in PR #16641:
URL: https://github.com/apache/doris/pull/16641#discussion_r1103844641
##########
be/src/olap/task/engine_clone_task.cpp:
##########
@@ -537,7 +539,8 @@ Status EngineCloneTask::_finish_incremental_clone(Tablet* tablet,
const TabletMeta& cloned_tablet_meta,
int64_t committed_version) {
LOG(INFO) << "begin to finish incremental clone. tablet=" << tablet->full_name()
- << ", committed_version=" << committed_version;
+ << ", committed_version=" << committed_version
+ << ", cloned_tablet_replica_id=" << cloned_tablet_meta.tablet_id();
Review Comment:
`tablet_id()` or `replica_id()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] ByteYue commented on a diff in pull request #16641: [Bug](Cooldown) fix load balance causing no cooldown replica
Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on code in PR #16641:
URL: https://github.com/apache/doris/pull/16641#discussion_r1103917449
##########
be/src/olap/task/engine_clone_task.cpp:
##########
@@ -537,7 +539,8 @@ Status EngineCloneTask::_finish_incremental_clone(Tablet* tablet,
const TabletMeta& cloned_tablet_meta,
int64_t committed_version) {
LOG(INFO) << "begin to finish incremental clone. tablet=" << tablet->full_name()
- << ", committed_version=" << committed_version;
+ << ", committed_version=" << committed_version
+ << ", cloned_tablet_replica_id=" << cloned_tablet_meta.tablet_id();
Review Comment:
fix it in #16644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16641: [Bug](Cooldown) fix load balance causing no cooldown replica
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #16641:
URL: https://github.com/apache/doris/pull/16641#issuecomment-1426823861
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.12 seconds
stream load tsv: 475 seconds loaded 74807831229 Bytes, about 150 MB/s
stream load json: 39 seconds loaded 2358488459 Bytes, about 57 MB/s
stream load orc: 69 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230211165631_clickbench_pr_94582.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #16641: [Bug](Cooldown) fix load balance causing no cooldown replica
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #16641:
URL: https://github.com/apache/doris/pull/16641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org