You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tkobayas (via GitHub)" <gi...@apache.org> on 2024/09/20 09:11:02 UTC
[PR] [incubator-kie-drools-6093] flaky test: org.drools.compiler.integrati… [incubator-kie-drools]
tkobayas opened a new pull request, #6096:
URL: https://github.com/apache/incubator-kie-drools/pull/6096
…ontests.TimerAndCalendarFireUntilHaltTest
**Issue**:
* https://github.com/apache/incubator-kie-drools/issues/6093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6093] flaky test: org.drools.compiler.integrati… [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #6096:
URL: https://github.com/apache/incubator-kie-drools/pull/6096#issuecomment-2363333387
Draft PR to be used for investigation: https://github.com/apache/incubator-kie-drools/pull/6095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6093] flaky test: org.drools.compiler.integrati… [incubator-kie-drools]
Posted by "mariofusco (via GitHub)" <gi...@apache.org>.
mariofusco merged PR #6096:
URL: https://github.com/apache/incubator-kie-drools/pull/6096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6093] flaky test: org.drools.compiler.integrati… [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6096:
URL: https://github.com/apache/incubator-kie-drools/pull/6096#discussion_r1768335141
##########
drools-test-coverage/test-compiler-integration/src/test/java/org/drools/compiler/integrationtests/TimerAndCalendarFireUntilHaltTest.java:
##########
@@ -109,9 +109,12 @@ public void testTimerRuleFires() throws Exception {
startEngine();
activateRule();
- advanceTimerOneSecond();
-
await().until(ruleHasFired("TimerRule", 1));
+
+ advanceTimerOneSecond();
+ await().until(ruleHasFired("TimerRule", 2));
Review Comment:
The flakiness was that `fireUntilHalt` may or may not fire a match between `activateRule()` and `advanceTimerOneSecond()`. Usually, it doesn't fire, so the assertion worked with `ruleHasFired("TimerRule", 1)`. However, to be stable, the test has to wait the first firing before `advanceTimerOneSecond()`. So the subsequent assertions are changed accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6093] flaky test: org.drools.compiler.integrati… [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6096:
URL: https://github.com/apache/incubator-kie-drools/pull/6096#discussion_r1768336694
##########
drools-test-coverage/test-compiler-integration/src/test/java/org/drools/compiler/integrationtests/TimerAndCalendarFireUntilHaltTest.java:
##########
@@ -109,9 +109,12 @@ public void testTimerRuleFires() throws Exception {
startEngine();
activateRule();
- advanceTimerOneSecond();
-
await().until(ruleHasFired("TimerRule", 1));
+
+ advanceTimerOneSecond();
+ await().until(ruleHasFired("TimerRule", 2));
+
+ stopEngine();
Review Comment:
This `stopEngine` is not related to the issue. But make sure to clean up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org