[GitHub] spark pull request #16724: [SPARK-19352][SQL] Preserve sort order when savin...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16724#discussion_r100687150
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala ---
    @@ -369,7 +371,78 @@ object FileFormatWriter extends Logging {
             context = taskAttemptContext)
         }
     
    +    // Returns the partition path given a partition key.
    +    private val getPartitionStringFunc = UnsafeProjection.create(
    +      Seq(Concat(partitionStringExpression)), description.partitionColumns)
    +
    +    // Returns the data columns to be written given an input row
    +    private val getOutputRow = UnsafeProjection.create(
    +      description.dataColumns, description.allColumns)
    +
         override def execute(iter: Iterator[InternalRow]): Set[String] = {
    +      val outputOrderingExprs = description.outputOrdering.map(_.child)
    --- End diff --
    
    this duplicates too much code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org