[GitHub] [beam] mrkm4ntr commented on a diff in pull request #26424: Handle response exception from Elasticsearch client

["mrkm4ntr (via GitHub)" <gi...@apache.org>]

mrkm4ntr commented on code in PR #26424:
URL: https://github.com/apache/beam/pull/26424#discussion_r1224985484


##########
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java:
##########
@@ -373,6 +376,8 @@ abstract static class Builder {
 
       abstract Builder setTrustSelfSignedCerts(boolean trustSelfSignedCerts);
 
+      abstract Builder setInvalidBulkEndpoint(boolean invalidBulkEndpoint);

Review Comment:
   I think this method and [this](https://github.com/apache/beam/pull/26424/files#diff-e119923661d41dfc1911da8f6e29cc0e2e9a0a50129718c1c20c7d1aa32119bfR658) are not visible from users.  Same approach as [this](https://github.com/apache/beam/blob/6ad2b12c0997ad70f54fe8367918f5a47d482b1b/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java#L1191-L1196).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org