You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HHoflittlefish777 (via GitHub)" <gi...@apache.org> on 2023/11/13 14:24:23 UTC
[PR] [improvement](log) log desensitization without displaying user info [doris]
HHoflittlefish777 opened a new pull request, #26912:
URL: https://github.com/apache/doris/pull/26912
## Proposed changes
redirect will record user name and password in log.For example:
```
redirect url: http://test%40default_cluster:123456@127.0.0.1:8030/api/db/lineitem/_stream_load?
```
This pr is is to desensitize logs without displaying username and password.For example:
```
Redirect url: http://127.0.0.1:8030/api/db/lineitem/_stream_load
```
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](log) log desensitization without displaying user info [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26912:
URL: https://github.com/apache/doris/pull/26912#issuecomment-1808319606
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](log) log desensitization without displaying user info [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26912:
URL: https://github.com/apache/doris/pull/26912#issuecomment-1808498978
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit d1bad3e8b25a273c60e5e7461867def5ee8a6036, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5252 5154 5204 5154
q2 360 156 167 156
q3 2037 2024 2001 2001
q4 1412 1366 1369 1366
q5 3970 3977 3974 3974
q6 256 130 129 129
q7 1464 893 880 880
q8 2799 2811 2774 2774
q9 9683 9428 9438 9428
q10 3420 3529 3523 3523
q11 388 267 261 261
q12 439 282 284 282
q13 4574 4092 4117 4092
q14 333 284 285 284
q15 660 575 552 552
q16 687 591 595 591
q17 1122 1099 1091 1091
q18 8034 7673 7482 7482
q19 1672 1690 1671 1671
q20 546 306 290 290
q21 4687 4374 4368 4368
q22 520 414 423 414
Total cold run time: 54315 ms
Total hot run time: 50763 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5020 5013 5079 5013
q2 355 249 262 249
q3 4109 4035 3988 3988
q4 2807 2773 2745 2745
q5 9616 9546 9561 9546
q6 250 126 127 126
q7 2715 2248 2287 2248
q8 4890 4820 4874 4820
q9 13088 13055 12938 12938
q10 4069 4176 4123 4123
q11 735 663 661 661
q12 1017 787 800 787
q13 4285 3858 3852 3852
q14 393 349 348 348
q15 608 563 558 558
q16 799 657 719 657
q17 3908 3949 3899 3899
q18 9621 9422 9469 9422
q19 1830 1814 1787 1787
q20 2410 2053 2035 2035
q21 8978 8812 8850 8812
q22 959 836 864 836
Total cold run time: 82462 ms
Total hot run time: 79450 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](log) log desensitization without displaying user info [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #26912:
URL: https://github.com/apache/doris/pull/26912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](log) log desensitization without displaying user info [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26912:
URL: https://github.com/apache/doris/pull/26912#issuecomment-1808319674
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](log) log desensitization without displaying user info [doris]
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #26912:
URL: https://github.com/apache/doris/pull/26912#issuecomment-1808263412
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](log) log desensitization without displaying user info [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26912:
URL: https://github.com/apache/doris/pull/26912#issuecomment-1808505290
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.61 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.7 seconds inserted 10000000 Rows, about 336K ops/s
storage size: 17162363686 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org