You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by James Long <jl...@mozilla.com> on 2014/01/09 20:24:22 UTC
merging PR for cordova-mobile-spec
Hey guys,
I hope this is the right place for this. I'm with Mozilla working on
Firefox OS support for cordova. Piotr is working with me on this. He
opened up a PR on the cordova-mobile-spec project that improves the
contacts automatic tests, and this is needed for the tests to pass on
Firefox OS. Accessing contacts on Firefox OS requires a "privileged"
app type which enforces CSP.
Can this be merged in?
https://github.com/apache/cordova-mobile-spec/pull/44
- James
Re: merging PR for cordova-mobile-spec
Posted by Shazron <sh...@gmail.com>.
Well yes of course - its just that a PR should have a corresponding Jira
issue (PR/patchfile definitely required for non-committers)
On Thu, Jan 9, 2014 at 2:20 PM, James Long <jl...@mozilla.com> wrote:
> Done: https://issues.apache.org/jira/browse/CB-5757 (created as
> sub-task of the task tracking all our work)
>
> Thanks, it's still nice to create a PR so we can keep track of what
> hasn't been merged but should be. Otherwise it's really hard to make
> sure everything gets merged.
>
> On Thu, Jan 9, 2014 at 2:56 PM, Shazron <sh...@gmail.com> wrote:
> > Hi James,
> > If you can create the corresponding Jira issue that would be great (as
> per
> > this workflow):
> > http://wiki.apache.org/cordova/ProcessingPullRequests
> >
> > The problem in general with pull requests from Github is, we don't get
> > notifications that someone filed one...
> >
> >
> > On Thu, Jan 9, 2014 at 11:24 AM, James Long <jl...@mozilla.com> wrote:
> >
> >> Hey guys,
> >>
> >> I hope this is the right place for this. I'm with Mozilla working on
> >> Firefox OS support for cordova. Piotr is working with me on this. He
> >> opened up a PR on the cordova-mobile-spec project that improves the
> >> contacts automatic tests, and this is needed for the tests to pass on
> >> Firefox OS. Accessing contacts on Firefox OS requires a "privileged"
> >> app type which enforces CSP.
> >>
> >> Can this be merged in?
> >>
> >> https://github.com/apache/cordova-mobile-spec/pull/44
> >>
> >> - James
> >>
>
Re: merging PR for cordova-mobile-spec
Posted by James Long <jl...@mozilla.com>.
Done: https://issues.apache.org/jira/browse/CB-5757 (created as
sub-task of the task tracking all our work)
Thanks, it's still nice to create a PR so we can keep track of what
hasn't been merged but should be. Otherwise it's really hard to make
sure everything gets merged.
On Thu, Jan 9, 2014 at 2:56 PM, Shazron <sh...@gmail.com> wrote:
> Hi James,
> If you can create the corresponding Jira issue that would be great (as per
> this workflow):
> http://wiki.apache.org/cordova/ProcessingPullRequests
>
> The problem in general with pull requests from Github is, we don't get
> notifications that someone filed one...
>
>
> On Thu, Jan 9, 2014 at 11:24 AM, James Long <jl...@mozilla.com> wrote:
>
>> Hey guys,
>>
>> I hope this is the right place for this. I'm with Mozilla working on
>> Firefox OS support for cordova. Piotr is working with me on this. He
>> opened up a PR on the cordova-mobile-spec project that improves the
>> contacts automatic tests, and this is needed for the tests to pass on
>> Firefox OS. Accessing contacts on Firefox OS requires a "privileged"
>> app type which enforces CSP.
>>
>> Can this be merged in?
>>
>> https://github.com/apache/cordova-mobile-spec/pull/44
>>
>> - James
>>
Re: merging PR for cordova-mobile-spec
Posted by Shazron <sh...@gmail.com>.
Hi James,
If you can create the corresponding Jira issue that would be great (as per
this workflow):
http://wiki.apache.org/cordova/ProcessingPullRequests
The problem in general with pull requests from Github is, we don't get
notifications that someone filed one...
On Thu, Jan 9, 2014 at 11:24 AM, James Long <jl...@mozilla.com> wrote:
> Hey guys,
>
> I hope this is the right place for this. I'm with Mozilla working on
> Firefox OS support for cordova. Piotr is working with me on this. He
> opened up a PR on the cordova-mobile-spec project that improves the
> contacts automatic tests, and this is needed for the tests to pass on
> Firefox OS. Accessing contacts on Firefox OS requires a "privileged"
> app type which enforces CSP.
>
> Can this be merged in?
>
> https://github.com/apache/cordova-mobile-spec/pull/44
>
> - James
>