Re: [PR] [ISSUE #776] Add push consumer for normal/fifo message, namespace support, reentrant message receiving support in C# SDK [rocketmq-clients]

["fuyou001 (via GitHub)" <gi...@apache.org>]

fuyou001 commented on code in PR #777:
URL: https://github.com/apache/rocketmq-clients/pull/777#discussion_r1740293806


##########
csharp/rocketmq-client-csharp/StandardConsumeService.cs:
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System.Collections.Generic;
+using System.Threading;
+using System.Threading.Tasks;
+using Microsoft.Extensions.Logging;
+
+namespace Org.Apache.Rocketmq
+{
+    public class StandardConsumeService : ConsumeService
+    {
+        private static readonly ILogger Logger = MqLogManager.CreateLogger<StandardConsumeService>();
+        
+        public StandardConsumeService(string clientId, IMessageListener messageListener,
+            TaskScheduler consumptionTaskScheduler, CancellationToken consumptionCtsToken) :
+            base(clientId, messageListener, consumptionTaskScheduler, consumptionCtsToken)
+        {
+        }
+
+        public override void Consume(ProcessQueue pq, List<MessageView> messageViews)
+        {
+            foreach (var messageView in messageViews)
+            {
+                if (messageView.IsCorrupted())
+                {
+                    Logger.LogError("Message is corrupted for standard consumption, prepare to discard it," +
+                                    $" mq={pq.GetMessageQueue()}, messageId={messageView.MessageId}, clientId={ClientId}");
+                    pq.DiscardMessage(messageView);
+                    continue;
+                }
+        
+                var consumeTask = Consume(messageView);
+        
+                consumeTask.ContinueWith(task =>
+                {
+                    if (!task.IsFaulted)

Review Comment:
   Replace IsFaulted with IsCompletedSuccessfully



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org