[GitHub] [geode] galen-pivotal opened pull request #2464: GEODE-5734: allow extensibility of Docker build mounts.

["galen-pivotal (GitHub)" <gi...@apache.org>]

If a user wants to extend Gradle's Docker plugin with their own tests,
setting dunitDockerVolumes to some value, then that value will be
overridden in docker.gradle. For better extensibility, do not set this
property if it is already set.


[ Full content available at: https://github.com/apache/geode/pull/2464 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] galen-pivotal closed pull request #2464: GEODE-5734: allow extensibility of Docker build mounts.

["galen-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by galen-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/2464 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #2464: GEODE-5734: allow extensibility of Docker build mounts.

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

This `if` block used to live in `build.gradle`. I believe the correct fix is to push it back there. Any 'other' projects, pulling in geode would then have the ability to override the `dunitDockerVolumes` variable. As it stands, it is _always_ going to be reset here which is incorrect.

[ Full content available at: https://github.com/apache/geode/pull/2464 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org