[jira] [Commented] (TAP5-2028) org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages with UTF-8 encoding

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676100#comment-13676100 ] 

Hudson commented on TAP5-2028:
------------------------------

Integrated in tapestry-trunk-freestyle #1078 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1078/])
    TAP5-2028: Hide the alert container after transient alert auto-dismisses (Revision b39079c846152bdd47e1f529b81dd1f206522cc7)

     Result = SUCCESS
hlship : 
Files : 
* tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/AlertsTests.groovy
* tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/alert.coffee

                
> org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages with UTF-8 encoding
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-2028
>                 URL: https://issues.apache.org/jira/browse/TAP5-2028
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3.6
>            Reporter: Balázs Palcsó
>              Labels: patch
>         Attachments: MessagesImplUTF8.patch
>
>
> In my tests I'd like to verify the content of the generated HTML. Instead of duplicating and hard coding the output messages that already exist in properties file I would like to load the messages from the properties file of the page classes I am testing.
> I was looking around the possibilities and I found that MessagesImpl would fit my needs. (and also asked on the users list: http://tapestry.1045711.n5.nabble.com/Unable-to-load-messages-in-UTF-8-encoding-in-test-class-in-different-class-than-messages-belong-to-tp5717808.html)
> private final Messages messages = MessagesImpl.forClass(Registration.class);
> would be the proper solution to load messages of my Registration page if
> MessagesImpl.forClass(Class) used UTF-8 encoding instead of the default
> ISO-8859-1 (latin1) when loading properties files.
> In pages and components my UTF-8 encoded properties files work correctly as
> documented at http://tapestry.apache.org/localization.html
> Currently MessagesImpl is part of the internal package, but I think this class would be useful wider usage therefore I would suggest moving this class to a "public" package.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira