[jira] [Comment Edited] (THRIFT-5109) Misc CMake improvements

["Jens Geyer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078998#comment-17078998 ] 

Jens Geyer edited comment on THRIFT-5109 at 4/9/20, 7:17 AM:
-------------------------------------------------------------

{quote}
And would you like all commits in a single PR, or split out like before?
{quote}

Depends whether they are independent and how large each one is. The drastic example woiuld be: Nobody needs 10 PRs each changing 2 lines, especially when they all build upon each other. OTOH nobody wants to review 120 changed files in one PR unless absolutely necessary.

PS: I should make a FAQ out of this. I answered that question 3 times in two months.



was (Author: jensg):
{quote}
And would you like all commits in a single PR, or split out like before?
{quote}

Depends whether they are independent and how lareg each one is. The drastic example woiuld be: Nobody needs 10 PRs each changing 2 lines, especially when they all build upon each other. OTOH nobody wants to review 120 changed files in one PR unless absolutely necessary.


> Misc CMake improvements
> -----------------------
>
>                 Key: THRIFT-5109
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5109
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Build Process
>            Reporter: Jens Geyer
>            Assignee: Mario Emmenlauer
>            Priority: Major
>             Fix For: 0.14.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
>  * compiler/cpp/CMakeLists.txt: Install compiler after build, like automake does
>  * Added NodeJS to cmake build
>  * Added Javascript to cmake build
>  * build/cmake/DefineInstallationPaths.cmake: fixed the library path
>  * build/cmake/ThriftMacros.cmake: do not enforce debug suffix 'd' 
>  * lib/java/CMakeLists.txt: allow to override JAVA_INSTALL_DIR 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)