[GitHub] [arrow] lidavidm commented on a diff in pull request #12719: ARROW-16032: [C++] Migrate FlightClient API to Result<>

[GitBox <gi...@apache.org>]

lidavidm commented on code in PR #12719:
URL: https://github.com/apache/arrow/pull/12719#discussion_r841877618


##########
cpp/src/arrow/flight/integration_tests/test_integration_client.cc:
##########
@@ -94,7 +94,7 @@ Status ConsumeFlightLocation(
     FlightClient* read_client, const Ticket& ticket,
     const std::vector<std::shared_ptr<RecordBatch>>& retrieved_data) {
   std::unique_ptr<FlightStreamReader> stream;
-  RETURN_NOT_OK(read_client->DoGet(ticket, &stream));
+  RETURN_NOT_OK(read_client->DoGet(ticket).Value(&stream));

Review Comment:
   Did you mean to resolve this?



##########
cpp/src/arrow/flight/flight_benchmark.cc:
##########
@@ -124,7 +124,7 @@ Status WaitForReady(FlightClient* client, const FlightCallOptions& call_options)
   Action action{"ping", nullptr};
   for (int attempt = 0; attempt < 10; attempt++) {
     std::unique_ptr<ResultStream> stream;
-    if (client->DoAction(call_options, action, &stream).ok()) {
+    if (client->DoAction(call_options, action).Value(&stream).ok()) {

Review Comment:
   Did you mean to resolve this? (Or did I miss something, is stream required?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org