[GitHub] [activemq-artemis] FrederikP commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol

[GitBox <gi...@apache.org>]

FrederikP commented on a change in pull request #2577: ARTEMIS-1604 Artemis deadlock using MQTT Protocol
URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264563803
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ##########
 @@ -249,7 +253,7 @@
 
    private volatile boolean directDeliver = true;
 
-   private volatile boolean supportsDirectDeliver = true;
+   private volatile boolean supportsDirectDeliver = false;
 
 Review comment:
   > I'm not sure though.. this issue was reported Jan last year.. I thought I had worked on it after then. I didn't know it was still an issue until Franz worked on it today.
   > 
   > I didn't close the original JIRA before because the user never reported what version he was working on...
   > 
   > So, I guess it's important to find a test replicating the issue, as we may be fixing something that was already fixed.
   
   Hi,
   I'm the guy who uploaded the thread dump to the jira issue last friday. Just want to make sure it's clear that we experienced this dead lock with version 2.6.4. Maybe I should've opened a new issue because it might have nothing to do with mqtt and it might be a different issue than the one the original reporter encountered a year ago with an older version.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services