You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/12 03:00:35 UTC

[GitHub] [iceberg] hililiwei commented on pull request #4246: Flink: Add support for ResolvedSchema

hililiwei commented on PR #4246:
URL: https://github.com/apache/iceberg/pull/4246#issuecomment-1124479258

   short-term, the transformation to ResolvedTable maintains certain compatibility in API.
   As [FLIP-164](https://cwiki.apache.org/confluence/display/FLINK/FLIP-164%3A+Improve+Schema+Handling+in+Catalogs) mentioned by @kbendick said:
   > Since TableSchema is a hybrid of both, it would not be a smooth experience in any case.
   > It is saver and more user-friendly to build up a separate stack with better class hierarchy in correct package.
   
   In order to better evolve in the future, in my humble opinion, it is necessary to add `ResolvedSchema` and related content support, . For ex, we currently have some PR that wants to add computed Colums and other new features to Iceberg-Flink.
   
   Of course, the updated related to `Schema`\`ResolvedSchema` are more underlying architecture changes, is not directly visible.
   
   In @Wuwenchi 's PR, try to perform the transition action early and explicitly. I think it's a good idea to try this transformation and it will give us some convenience, we can change very little code to provide better compatibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org